[wasm-custom-desc] Import spec tests [v8/v8 : main]

0 views
Skip to first unread message

Thomas Lively (Gerrit)

unread,
Oct 22, 2025, 6:19:46 PM (17 hours ago) Oct 22
to Jakob Kummerow, Matthias Liedtke, Francis McCabe, Thibaud Michaud, v8-re...@googlegroups.com
Attention needed from Jakob Kummerow and Matthias Liedtke

Thomas Lively added 1 comment

Patchset-level comments
File-level comment, Patchset 1 (Latest):
Thomas Lively . resolved

cc Francis and Thibaud as FYI for the newly ignored stack switching test.

Open in Gerrit

Related details

Attention is currently required from:
  • Jakob Kummerow
  • Matthias Liedtke
Submit Requirements:
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: v8/v8
Gerrit-Branch: main
Gerrit-Change-Id: I4dcead9ead0e146c3442c4d3e2ce5f57d62457fa
Gerrit-Change-Number: 7076306
Gerrit-PatchSet: 1
Gerrit-Owner: Thomas Lively <tli...@google.com>
Gerrit-Reviewer: Jakob Kummerow <jkum...@chromium.org>
Gerrit-Reviewer: Matthias Liedtke <mlie...@chromium.org>
Gerrit-CC: Francis McCabe <f...@chromium.org>
Gerrit-CC: Thibaud Michaud <thib...@chromium.org>
Gerrit-Attention: Matthias Liedtke <mlie...@chromium.org>
Gerrit-Attention: Jakob Kummerow <jkum...@chromium.org>
Gerrit-Comment-Date: Wed, 22 Oct 2025 22:19:43 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
unsatisfied_requirement
open
diffy

Matthias Liedtke (Gerrit)

unread,
4:16 AM (7 hours ago) 4:16 AM
to Thomas Lively, Jakob Kummerow, Francis McCabe, Thibaud Michaud, v8-re...@googlegroups.com
Attention needed from Jakob Kummerow and Thomas Lively

Matthias Liedtke voted and added 2 comments

Votes added by Matthias Liedtke

Code-Review+1

2 comments

Patchset-level comments
Matthias Liedtke . resolved

LGTM

File tools/wasm/update-wasm-spec-tests.sh
Line 70, Patchset 1 (Latest):TOOLS_WASM_DIR=$(cd $(dirname ${BASH_SOURCE[0]}) > /dev/null && pwd)
Matthias Liedtke . unresolved

Why is this needed? Or was the script just too verbose for your taste? 😊

Open in Gerrit

Related details

Attention is currently required from:
  • Jakob Kummerow
  • Thomas Lively
Submit Requirements:
  • requirement satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedNo-Unresolved-Comments
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: v8/v8
Gerrit-Branch: main
Gerrit-Change-Id: I4dcead9ead0e146c3442c4d3e2ce5f57d62457fa
Gerrit-Change-Number: 7076306
Gerrit-PatchSet: 1
Gerrit-Owner: Thomas Lively <tli...@google.com>
Gerrit-Reviewer: Jakob Kummerow <jkum...@chromium.org>
Gerrit-Reviewer: Matthias Liedtke <mlie...@chromium.org>
Gerrit-CC: Francis McCabe <f...@chromium.org>
Gerrit-CC: Thibaud Michaud <thib...@chromium.org>
Gerrit-Attention: Thomas Lively <tli...@google.com>
Gerrit-Attention: Jakob Kummerow <jkum...@chromium.org>
Gerrit-Comment-Date: Thu, 23 Oct 2025 08:16:14 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

Jakob Kummerow (Gerrit)

unread,
6:12 AM (5 hours ago) 6:12 AM
to Thomas Lively, Jakob Kummerow, Matthias Liedtke, Francis McCabe, Thibaud Michaud, v8-re...@googlegroups.com
Attention needed from Thomas Lively

Jakob Kummerow voted Code-Review+1

Code-Review+1
Open in Gerrit

Related details

Attention is currently required from:
  • Thomas Lively
Submit Requirements:
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement is not satisfiedNo-Unresolved-Comments
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: v8/v8
Gerrit-Branch: main
Gerrit-Change-Id: I4dcead9ead0e146c3442c4d3e2ce5f57d62457fa
Gerrit-Change-Number: 7076306
Gerrit-PatchSet: 1
Gerrit-Owner: Thomas Lively <tli...@google.com>
Gerrit-Reviewer: Jakob Kummerow <jkum...@chromium.org>
Gerrit-Reviewer: Matthias Liedtke <mlie...@chromium.org>
Gerrit-CC: Francis McCabe <f...@chromium.org>
Gerrit-CC: Thibaud Michaud <thib...@chromium.org>
Gerrit-Attention: Thomas Lively <tli...@google.com>
Gerrit-Comment-Date: Thu, 23 Oct 2025 10:12:46 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

Matthias Liedtke (Gerrit)

unread,
6:21 AM (5 hours ago) 6:21 AM
to Thomas Lively, Jakob Kummerow, Francis McCabe, Thibaud Michaud, v8-re...@googlegroups.com

Matthias Liedtke abandoned this change

Related details

Attention set is empty
Submit Requirements:
  • requirement satisfiedCode-Review
  • requirement is not satisfiedNo-Unresolved-Comments
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: abandon
satisfied_requirement
unsatisfied_requirement
open
diffy

Matthias Liedtke (Gerrit)

unread,
6:22 AM (5 hours ago) 6:22 AM
to Thomas Lively, Jakob Kummerow, Francis McCabe, Thibaud Michaud, v8-re...@googlegroups.com

Matthias Liedtke added 1 comment

File tools/wasm/update-wasm-spec-tests.sh
Line 70, Patchset 1 (Latest):TOOLS_WASM_DIR=$(cd $(dirname ${BASH_SOURCE[0]}) > /dev/null && pwd)
Matthias Liedtke . resolved

Why is this needed? Or was the script just too verbose for your taste? 😊

Matthias Liedtke

Anyways not blocking, resolving, I'll +1/+2 the other change.

Open in Gerrit

Related details

Attention set is empty
Submit Requirements:
  • requirement satisfiedCode-Review
  • requirement is not satisfiedNo-Unresolved-Comments
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: v8/v8
Gerrit-Branch: main
Gerrit-Change-Id: I4dcead9ead0e146c3442c4d3e2ce5f57d62457fa
Gerrit-Change-Number: 7076306
Gerrit-PatchSet: 1
Gerrit-Owner: Thomas Lively <tli...@google.com>
Gerrit-Reviewer: Jakob Kummerow <jkum...@chromium.org>
Gerrit-Reviewer: Matthias Liedtke <mlie...@chromium.org>
Gerrit-CC: Francis McCabe <f...@chromium.org>
Gerrit-CC: Thibaud Michaud <thib...@chromium.org>
Gerrit-Comment-Date: Thu, 23 Oct 2025 10:22:17 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Matthias Liedtke <mlie...@chromium.org>
satisfied_requirement
unsatisfied_requirement
open
diffy

Matthias Liedtke (Gerrit)

unread,
6:22 AM (5 hours ago) 6:22 AM
to Thomas Lively, Jakob Kummerow, v8-re...@googlegroups.com, was...@google.com
Attention needed from Jakob Kummerow and Thomas Lively

Matthias Liedtke voted and added 1 comment

Votes added by Matthias Liedtke

Code-Review+1

1 comment

Patchset-level comments
File-level comment, Patchset 1 (Latest):
Matthias Liedtke . resolved

LGTM

Open in Gerrit

Related details

Attention is currently required from:
  • Jakob Kummerow
  • Thomas Lively
Submit Requirements:
  • requirement satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: v8/v8
Gerrit-Branch: main
Gerrit-Change-Id: I41c9ca8a2a89edeebfcc3a27e093658227c5e399
Gerrit-Change-Number: 7076309
Gerrit-PatchSet: 1
Gerrit-Owner: Thomas Lively <tli...@google.com>
Gerrit-Reviewer: Jakob Kummerow <jkum...@chromium.org>
Gerrit-Reviewer: Matthias Liedtke <mlie...@chromium.org>
Gerrit-Attention: Thomas Lively <tli...@google.com>
Gerrit-Attention: Jakob Kummerow <jkum...@chromium.org>
Gerrit-Comment-Date: Thu, 23 Oct 2025 10:22:43 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

Jakob Kummerow (Gerrit)

unread,
6:23 AM (5 hours ago) 6:23 AM
to Thomas Lively, Jakob Kummerow, Matthias Liedtke, v8-re...@googlegroups.com, was...@google.com
Attention needed from Thomas Lively

Jakob Kummerow voted

Code-Review+1
Commit-Queue+2
Open in Gerrit

Related details

Attention is currently required from:
  • Thomas Lively
Submit Requirements:
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: v8/v8
Gerrit-Branch: main
Gerrit-Change-Id: I41c9ca8a2a89edeebfcc3a27e093658227c5e399
Gerrit-Change-Number: 7076309
Gerrit-PatchSet: 1
Gerrit-Owner: Thomas Lively <tli...@google.com>
Gerrit-Reviewer: Jakob Kummerow <jkum...@chromium.org>
Gerrit-Reviewer: Matthias Liedtke <mlie...@chromium.org>
Gerrit-Attention: Thomas Lively <tli...@google.com>
Gerrit-Comment-Date: Thu, 23 Oct 2025 10:23:40 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

V8 LUCI CQ (Gerrit)

unread,
6:54 AM (5 hours ago) 6:54 AM
to Thomas Lively, Jakob Kummerow, Matthias Liedtke, v8-re...@googlegroups.com, was...@google.com

V8 LUCI CQ submitted the change

Change information

Commit message:
[wasm-custom-desc] Import spec tests

Update update-wasm-spec-tests.sh to pull tests from the
custom-descriptors proposal repo. Add failing tests and reasons to
wasm-spec-tests.status.
Bug: 403372470
Change-Id: I41c9ca8a2a89edeebfcc3a27e093658227c5e399
Reviewed-by: Matthias Liedtke <mlie...@chromium.org>
Reviewed-by: Jakob Kummerow <jkum...@chromium.org>
Commit-Queue: Jakob Kummerow <jkum...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#103310}
Files:
  • M test/wasm-js/tests.tar.gz.sha1
  • M test/wasm-spec-tests/testcfg.py
  • M test/wasm-spec-tests/tests.tar.gz.sha1
  • M test/wasm-spec-tests/wasm-spec-tests.status
  • M tools/wasm/update-wasm-spec-tests.sh
Change size: S
Delta: 5 files changed, 18 insertions(+), 4 deletions(-)
Branch: refs/heads/main
Submit Requirements:
  • requirement satisfiedCode-Review: +1 by Jakob Kummerow, +1 by Matthias Liedtke
Open in Gerrit
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: merged
Gerrit-Project: v8/v8
Gerrit-Branch: main
Gerrit-Change-Id: I41c9ca8a2a89edeebfcc3a27e093658227c5e399
Gerrit-Change-Number: 7076309
Gerrit-PatchSet: 2
Gerrit-Owner: Thomas Lively <tli...@google.com>
Gerrit-Reviewer: Jakob Kummerow <jkum...@chromium.org>
Gerrit-Reviewer: Matthias Liedtke <mlie...@chromium.org>
open
diffy
satisfied_requirement

Thomas Lively (Gerrit)

unread,
10:56 AM (1 hour ago) 10:56 AM
to Jakob Kummerow, Matthias Liedtke, Francis McCabe, Thibaud Michaud, v8-re...@googlegroups.com

Thomas Lively added 1 comment

File tools/wasm/update-wasm-spec-tests.sh
Line 70, Patchset 1 (Latest):TOOLS_WASM_DIR=$(cd $(dirname ${BASH_SOURCE[0]}) > /dev/null && pwd)
Matthias Liedtke . resolved

Why is this needed? Or was the script just too verbose for your taste? 😊

Matthias Liedtke

Anyways not blocking, resolving, I'll +1/+2 the other change.

Thomas Lively

Somehow `cd` on my machine ends up printing a directory name, so this was setting TOOLS_WASM_DIR to a string containing _two_ directories. This caused problems later.

Open in Gerrit

Related details

Attention set is empty
Submit Requirements:
  • requirement satisfiedCode-Review
  • requirement is not satisfiedNo-Unresolved-Comments
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: v8/v8
Gerrit-Branch: main
Gerrit-Change-Id: I4dcead9ead0e146c3442c4d3e2ce5f57d62457fa
Gerrit-Change-Number: 7076306
Gerrit-PatchSet: 1
Gerrit-Owner: Thomas Lively <tli...@google.com>
Gerrit-Reviewer: Jakob Kummerow <jkum...@chromium.org>
Gerrit-Reviewer: Matthias Liedtke <mlie...@chromium.org>
Gerrit-CC: Francis McCabe <f...@chromium.org>
Gerrit-CC: Thibaud Michaud <thib...@chromium.org>
Gerrit-Comment-Date: Thu, 23 Oct 2025 14:56:13 +0000
satisfied_requirement
unsatisfied_requirement
open
diffy
Reply all
Reply to author
Forward
0 new messages