cc Francis and Thibaud as FYI for the newly ignored stack switching test.
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Code-Review | +1 |
LGTM
TOOLS_WASM_DIR=$(cd $(dirname ${BASH_SOURCE[0]}) > /dev/null && pwd)
Why is this needed? Or was the script just too verbose for your taste? 😊
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
TOOLS_WASM_DIR=$(cd $(dirname ${BASH_SOURCE[0]}) > /dev/null && pwd)
Why is this needed? Or was the script just too verbose for your taste? 😊
Anyways not blocking, resolving, I'll +1/+2 the other change.
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Code-Review | +1 |
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
[wasm-custom-desc] Import spec tests
Update update-wasm-spec-tests.sh to pull tests from the
custom-descriptors proposal repo. Add failing tests and reasons to
wasm-spec-tests.status.
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
TOOLS_WASM_DIR=$(cd $(dirname ${BASH_SOURCE[0]}) > /dev/null && pwd)
Matthias LiedtkeWhy is this needed? Or was the script just too verbose for your taste? 😊
Anyways not blocking, resolving, I'll +1/+2 the other change.
Somehow `cd` on my machine ends up printing a directory name, so this was setting TOOLS_WASM_DIR to a string containing _two_ directories. This caused problems later.
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |