Sam Parker-Haynes voted Commit-Queue+1

Related details

Attention is currently required from:

Nico Hartmann

Submit Requirements:

Code-Owners
Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

unsatisfied_requirement

open

diffy

chromeperf@appspot.gserviceaccount.com (Gerrit)

unread,

Jun 2, 2026, 7:06:33 AM (8 days ago) Jun 2

to Sam Parker-Haynes, Nico Hartmann, v8-s...@luci-project-accounts.iam.gserviceaccount.com, dmercadi...@chromium.org, v8-flag...@chromium.org, v8-re...@googlegroups.com

Attention needed from Nico Hartmann and Sam Parker-Haynes

Message from chrom...@appspot.gserviceaccount.com

📍 Job linux-r350-perf/jetstream-main.crossbench complete.

sync-fs: base median = 550.3591488025738 -> patched median = 476.02727069819207

See results at: https://pinpoint-dot-chromeperf.appspot.com/job/13fda419490000

Related details

Attention is currently required from:

Nico Hartmann
Sam Parker-Haynes

Submit Requirements:

Code-Owners
Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

unsatisfied_requirement

open

diffy

chromeperf@appspot.gserviceaccount.com (Gerrit)

unread,

Jun 2, 2026, 7:28:13 AM (8 days ago) Jun 2

to Sam Parker-Haynes, Nico Hartmann, v8-s...@luci-project-accounts.iam.gserviceaccount.com, dmercadi...@chromium.org, v8-flag...@chromium.org, v8-re...@googlegroups.com

Attention needed from Nico Hartmann and Sam Parker-Haynes

Message from chrom...@appspot.gserviceaccount.com

📍 Job mac-m4-pro-perf/jetstream-main.crossbench complete.

See results at: https://pinpoint-dot-chromeperf.appspot.com/job/142f9cc9490000

Related details

Attention is currently required from:

Nico Hartmann
Sam Parker-Haynes

Submit Requirements:

Code-Owners
Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

unsatisfied_requirement

open

diffy

Darius Mercadier (Gerrit)

unread,

Jun 2, 2026, 7:31:41 AM (8 days ago) Jun 2

to Sam Parker-Haynes, chrom...@appspot.gserviceaccount.com, Nico Hartmann, v8-s...@luci-project-accounts.iam.gserviceaccount.com, dmercadi...@chromium.org, v8-flag...@chromium.org, v8-re...@googlegroups.com

Attention needed from Nico Hartmann and Sam Parker-Haynes

Darius Mercadier added 1 comment

Patchset-level comments

Darius Mercadier . resolved

pinpoint doesn't seem super happy about this CL, in particular on x64...

Related details

Attention is currently required from:

Nico Hartmann
Sam Parker-Haynes

Submit Requirements:

Code-Owners
Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

unsatisfied_requirement

open

diffy

Sam Parker-Haynes (Gerrit)

unread,

Jun 2, 2026, 7:47:45 AM (8 days ago) Jun 2

to Darius Mercadier, chrom...@appspot.gserviceaccount.com, Nico Hartmann, v8-s...@luci-project-accounts.iam.gserviceaccount.com, dmercadi...@chromium.org, v8-flag...@chromium.org, v8-re...@googlegroups.com

Attention needed from Darius Mercadier and Nico Hartmann

Sam Parker-Haynes added 1 comment

Patchset-level comments

Darius Mercadier . resolved

pinpoint doesn't seem super happy about this CL, in particular on x64...

Sam Parker-Haynes

I haven't really looked a pinpoint before... is it just sync-fs for x64 that is the problem?

Related details

Attention is currently required from:

Darius Mercadier
Nico Hartmann

Submit Requirements:

Code-Owners
Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

unsatisfied_requirement

open

diffy

Darius Mercadier (Gerrit)

unread,

Jun 2, 2026, 7:52:31 AM (8 days ago) Jun 2

to Sam Parker-Haynes, chrom...@appspot.gserviceaccount.com, Nico Hartmann, v8-s...@luci-project-accounts.iam.gserviceaccount.com, dmercadi...@chromium.org, v8-flag...@chromium.org, v8-re...@googlegroups.com

Attention needed from Nico Hartmann and Sam Parker-Haynes

Darius Mercadier added 1 comment

Patchset-level comments

Darius Mercadier . resolved

pinpoint doesn't seem super happy about this CL, in particular on x64...

Sam Parker-Haynes

I haven't really looked a pinpoint before... is it just sync-fs for x64 that is the problem?

Darius Mercadier

Not just sync-fs:
navier-stokes -3.8%
sync-fs -3.1%
gaussian-blur -2.8%
js-tokens -2.2%
threejs -1.6%
mandreel -1.4%
espree-wtb -1.2%

If you have access to the pinpoint links, then you can select "base: ..." where it says "Select a reference column" at the top, the sort the "exp" column, and then all lines with a red down arrow are regressions, and lines with a green up arrow are improvements (and the other lines you can kinda ignore: their changes are not statistically significant).

Worth noting that I'm running pinpoint with `--turbo-instruction-scheduling`, which is disabled by default. If the point of this CL was to improve builtins (since --turbo-instruction-scheduling is enabled by default in mksnapshot), then the pinpoints I've ran are useless to show whether this CL is effective or not.

Related details

Attention is currently required from:

Nico Hartmann
Sam Parker-Haynes

Submit Requirements:

Code-Owners
Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

unsatisfied_requirement

open

diffy

Sam Parker-Haynes (Gerrit)

unread,

Jun 2, 2026, 8:26:30 AM (8 days ago) Jun 2

to Darius Mercadier, chrom...@appspot.gserviceaccount.com, Nico Hartmann, v8-s...@luci-project-accounts.iam.gserviceaccount.com, dmercadi...@chromium.org, v8-flag...@chromium.org, v8-re...@googlegroups.com

Attention needed from Darius Mercadier and Nico Hartmann

Sam Parker-Haynes added 1 comment

Patchset-level comments

Darius Mercadier . resolved

pinpoint doesn't seem super happy about this CL, in particular on x64...

Sam Parker-Haynes

I haven't really looked a pinpoint before... is it just sync-fs for x64 that is the problem?

Darius Mercadier

Not just sync-fs:
navier-stokes -3.8%
sync-fs -3.1%
gaussian-blur -2.8%
js-tokens -2.2%
threejs -1.6%
mandreel -1.4%
espree-wtb -1.2%
If you have access to the pinpoint links, then you can select "base: ..." where it says "Select a reference column" at the top, the sort the "exp" column, and then all lines with a red down arrow are regressions, and lines with a green up arrow are improvements (and the other lines you can kinda ignore: their changes are not statistically significant).
Worth noting that I'm running pinpoint with `--turbo-instruction-scheduling`, which is disabled by default. If the point of this CL was to improve builtins (since --turbo-instruction-scheduling is enabled by default in mksnapshot), then the pinpoints I've ran are useless to show whether this CL is effective or not.

Sam Parker-Haynes

Okay, thanks. So, it's two up and two down on the mac and mostly down on x64.

I'm not bothered about builtins really, I have a series of downstream patches that give me ~2% geomean improvement on a bunch of wasm codes. I have those features hidden behind an experimental flag to avoid this kind of trouble. I'm going to assume / hope that it's the change to `PopBestCandidate` that's causing the problem so I'll try hiding that behind a new flag.

Related details

Attention is currently required from:

Darius Mercadier
Nico Hartmann

Submit Requirements:

Code-Owners
Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

unsatisfied_requirement

open

diffy

Sam Parker-Haynes (Gerrit)

unread,

Jun 2, 2026, 8:43:30 AM (8 days ago) Jun 2

to Darius Mercadier, chrom...@appspot.gserviceaccount.com, Nico Hartmann, v8-s...@luci-project-accounts.iam.gserviceaccount.com, dmercadi...@chromium.org, v8-flag...@chromium.org, v8-re...@googlegroups.com

Attention needed from Darius Mercadier and Nico Hartmann

Sam Parker-Haynes added 1 comment

Patchset-level comments

Darius Mercadier . resolved

pinpoint doesn't seem super happy about this CL, in particular on x64...

Sam Parker-Haynes

I haven't really looked a pinpoint before... is it just sync-fs for x64 that is the problem?

Darius Mercadier

Not just sync-fs:
navier-stokes -3.8%
sync-fs -3.1%
gaussian-blur -2.8%
js-tokens -2.2%
threejs -1.6%
mandreel -1.4%
espree-wtb -1.2%
If you have access to the pinpoint links, then you can select "base: ..." where it says "Select a reference column" at the top, the sort the "exp" column, and then all lines with a red down arrow are regressions, and lines with a green up arrow are improvements (and the other lines you can kinda ignore: their changes are not statistically significant).
Worth noting that I'm running pinpoint with `--turbo-instruction-scheduling`, which is disabled by default. If the point of this CL was to improve builtins (since --turbo-instruction-scheduling is enabled by default in mksnapshot), then the pinpoints I've ran are useless to show whether this CL is effective or not.

Sam Parker-Haynes

Okay, thanks. So, it's two up and two down on the mac and mostly down on x64.
I'm not bothered about builtins really, I have a series of downstream patches that give me ~2% geomean improvement on a bunch of wasm codes. I have those features hidden behind an experimental flag to avoid this kind of trouble. I'm going to assume / hope that it's the change to `PopBestCandidate` that's causing the problem so I'll try hiding that behind a new flag.

Sam Parker-Haynes

Would you mind kicking off the performance runs again please?

Related details

Attention is currently required from:

Darius Mercadier
Nico Hartmann

Submit Requirements:

Code-Owners
Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

unsatisfied_requirement

open

diffy

Darius Mercadier (Gerrit)

unread,

Jun 2, 2026, 8:46:12 AM (8 days ago) Jun 2

to Sam Parker-Haynes, chrom...@appspot.gserviceaccount.com, Nico Hartmann, v8-s...@luci-project-accounts.iam.gserviceaccount.com, dmercadi...@chromium.org, v8-flag...@chromium.org, v8-re...@googlegroups.com

Attention needed from Nico Hartmann and Sam Parker-Haynes

Darius Mercadier added 1 comment

Patchset-level comments

Darius Mercadier . resolved

pinpoint doesn't seem super happy about this CL, in particular on x64...

Sam Parker-Haynes

I haven't really looked a pinpoint before... is it just sync-fs for x64 that is the problem?

Darius Mercadier

Not just sync-fs:
navier-stokes -3.8%
sync-fs -3.1%
gaussian-blur -2.8%
js-tokens -2.2%
threejs -1.6%
mandreel -1.4%
espree-wtb -1.2%
If you have access to the pinpoint links, then you can select "base: ..." where it says "Select a reference column" at the top, the sort the "exp" column, and then all lines with a red down arrow are regressions, and lines with a green up arrow are improvements (and the other lines you can kinda ignore: their changes are not statistically significant).
Worth noting that I'm running pinpoint with `--turbo-instruction-scheduling`, which is disabled by default. If the point of this CL was to improve builtins (since --turbo-instruction-scheduling is enabled by default in mksnapshot), then the pinpoints I've ran are useless to show whether this CL is effective or not.

Sam Parker-Haynes

Okay, thanks. So, it's two up and two down on the mac and mostly down on x64.
I'm not bothered about builtins really, I have a series of downstream patches that give me ~2% geomean improvement on a bunch of wasm codes. I have those features hidden behind an experimental flag to avoid this kind of trouble. I'm going to assume / hope that it's the change to `PopBestCandidate` that's causing the problem so I'll try hiding that behind a new flag.

Sam Parker-Haynes

Would you mind kicking off the performance runs again please?

Darius Mercadier

Done (https://pinpoint-dot-chromeperf.appspot.com/job/10d53823490000 and https://pinpoint-dot-chromeperf.appspot.com/job/12473935490000; which should notify on this CL once they finish)

Related details

Attention is currently required from:

Nico Hartmann
Sam Parker-Haynes

Submit Requirements:

Code-Owners
Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

unsatisfied_requirement

open

diffy

chromeperf@appspot.gserviceaccount.com (Gerrit)

unread,

Jun 2, 2026, 9:54:21 AM (8 days ago) Jun 2

to Sam Parker-Haynes, Darius Mercadier, Nico Hartmann, v8-s...@luci-project-accounts.iam.gserviceaccount.com, dmercadi...@chromium.org, v8-flag...@chromium.org, v8-re...@googlegroups.com

Attention needed from Nico Hartmann and Sam Parker-Haynes

Message from chrom...@appspot.gserviceaccount.com

📍 Job linux-r350-perf/jetstream-main.crossbench complete.

See results at: https://pinpoint-dot-chromeperf.appspot.com/job/12473935490000

unsatisfied_requirement

open

diffy

chromeperf@appspot.gserviceaccount.com (Gerrit)

unread,

Jun 2, 2026, 9:57:42 AM (8 days ago) Jun 2

to Sam Parker-Haynes, Darius Mercadier, Nico Hartmann, v8-s...@luci-project-accounts.iam.gserviceaccount.com, dmercadi...@chromium.org, v8-flag...@chromium.org, v8-re...@googlegroups.com

Attention needed from Nico Hartmann and Sam Parker-Haynes

Message from chrom...@appspot.gserviceaccount.com

📍 Job mac-m4-mini-perf/jetstream-main.crossbench complete.

See results at: https://pinpoint-dot-chromeperf.appspot.com/job/10d53823490000

unsatisfied_requirement

open

diffy

Sam Parker-Haynes (Gerrit)

unread,

Jun 2, 2026, 11:38:22 AM (8 days ago) Jun 2

to Darius Mercadier, chrom...@appspot.gserviceaccount.com, Nico Hartmann, v8-s...@luci-project-accounts.iam.gserviceaccount.com, dmercadi...@chromium.org, v8-flag...@chromium.org, v8-re...@googlegroups.com

Attention needed from Darius Mercadier and Nico Hartmann

Sam Parker-Haynes added 1 comment

Patchset-level comments

Darius Mercadier . resolved

pinpoint doesn't seem super happy about this CL, in particular on x64...

Sam Parker-Haynes

I haven't really looked a pinpoint before... is it just sync-fs for x64 that is the problem?

Darius Mercadier

Not just sync-fs:
navier-stokes -3.8%
sync-fs -3.1%
gaussian-blur -2.8%
js-tokens -2.2%
threejs -1.6%
mandreel -1.4%
espree-wtb -1.2%
If you have access to the pinpoint links, then you can select "base: ..." where it says "Select a reference column" at the top, the sort the "exp" column, and then all lines with a red down arrow are regressions, and lines with a green up arrow are improvements (and the other lines you can kinda ignore: their changes are not statistically significant).
Worth noting that I'm running pinpoint with `--turbo-instruction-scheduling`, which is disabled by default. If the point of this CL was to improve builtins (since --turbo-instruction-scheduling is enabled by default in mksnapshot), then the pinpoints I've ran are useless to show whether this CL is effective or not.

Sam Parker-Haynes

Okay, thanks. So, it's two up and two down on the mac and mostly down on x64.
I'm not bothered about builtins really, I have a series of downstream patches that give me ~2% geomean improvement on a bunch of wasm codes. I have those features hidden behind an experimental flag to avoid this kind of trouble. I'm going to assume / hope that it's the change to `PopBestCandidate` that's causing the problem so I'll try hiding that behind a new flag.

Sam Parker-Haynes

Would you mind kicking off the performance runs again please?

Darius Mercadier

Done (https://pinpoint-dot-chromeperf.appspot.com/job/10d53823490000 and https://pinpoint-dot-chromeperf.appspot.com/job/12473935490000; which should notify on this CL once they finish)

Sam Parker-Haynes

And again please 😊

Related details

Attention is currently required from:

Darius Mercadier
Nico Hartmann

Submit Requirements:

Code-Owners
Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

unsatisfied_requirement

open

diffy

Darius Mercadier (Gerrit)

unread,

Jun 3, 2026, 1:50:47 AM (7 days ago) Jun 3

to Sam Parker-Haynes, chrom...@appspot.gserviceaccount.com, Nico Hartmann, v8-s...@luci-project-accounts.iam.gserviceaccount.com, dmercadi...@chromium.org, v8-flag...@chromium.org, v8-re...@googlegroups.com

Attention needed from Nico Hartmann and Sam Parker-Haynes

Darius Mercadier added 1 comment

Patchset-level comments

Darius Mercadier

done

Related details

Attention is currently required from:

Nico Hartmann
Sam Parker-Haynes

Submit Requirements:

Code-Owners
Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

unsatisfied_requirement

open

diffy

chromeperf@appspot.gserviceaccount.com (Gerrit)

unread,

Jun 3, 2026, 2:11:42 AM (7 days ago) Jun 3

to Sam Parker-Haynes, Darius Mercadier, Nico Hartmann, v8-s...@luci-project-accounts.iam.gserviceaccount.com, dmercadi...@chromium.org, v8-flag...@chromium.org, v8-re...@googlegroups.com

Attention needed from Nico Hartmann and Sam Parker-Haynes

Message from chrom...@appspot.gserviceaccount.com

😿 Job mac-m4-mini-perf/jetstream-main.crossbench failed.

See results at: https://pinpoint-dot-chromeperf.appspot.com/job/14a92dfd490000

unsatisfied_requirement

open

diffy

chromeperf@appspot.gserviceaccount.com (Gerrit)

unread,

Jun 3, 2026, 3:00:52 AM (7 days ago) Jun 3

to Sam Parker-Haynes, Darius Mercadier, Nico Hartmann, v8-s...@luci-project-accounts.iam.gserviceaccount.com, dmercadi...@chromium.org, v8-flag...@chromium.org, v8-re...@googlegroups.com

Attention needed from Nico Hartmann and Sam Parker-Haynes

Message from chrom...@appspot.gserviceaccount.com

📍 Job linux-r350-perf/jetstream-main.crossbench complete.

See results at: https://pinpoint-dot-chromeperf.appspot.com/job/135eb1fd490000

unsatisfied_requirement

open

diffy

Sam Parker-Haynes (Gerrit)

unread,

Jun 3, 2026, 4:14:07 AM (7 days ago) Jun 3

to Darius Mercadier, chrom...@appspot.gserviceaccount.com, Nico Hartmann, v8-s...@luci-project-accounts.iam.gserviceaccount.com, dmercadi...@chromium.org, v8-flag...@chromium.org, v8-re...@googlegroups.com

Attention needed from Darius Mercadier and Nico Hartmann

Sam Parker-Haynes added 1 comment

Patchset-level comments

Sam Parker-Haynes

So, it looks like the issues are resolved on x64, but any idea why the mac build failed?

Related details

Attention is currently required from:

Darius Mercadier
Nico Hartmann

Submit Requirements:

Code-Owners
Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

unsatisfied_requirement

open

diffy

Darius Mercadier (Gerrit)

unread,

Jun 3, 2026, 4:15:30 AM (7 days ago) Jun 3

to Sam Parker-Haynes, chrom...@appspot.gserviceaccount.com, Nico Hartmann, v8-s...@luci-project-accounts.iam.gserviceaccount.com, dmercadi...@chromium.org, v8-flag...@chromium.org, v8-re...@googlegroups.com

Attention needed from Nico Hartmann and Sam Parker-Haynes

Darius Mercadier added 1 comment

Patchset-level comments

Darius Mercadier

I restarted the mac pinpoint, maybe it was just a fluke.

Related details

Attention is currently required from:

Nico Hartmann
Sam Parker-Haynes

Submit Requirements:

Code-Owners
Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

unsatisfied_requirement

open

diffy

chromeperf@appspot.gserviceaccount.com (Gerrit)

unread,

Jun 3, 2026, 5:20:36 AM (7 days ago) Jun 3

to Sam Parker-Haynes, Darius Mercadier, Nico Hartmann, v8-s...@luci-project-accounts.iam.gserviceaccount.com, dmercadi...@chromium.org, v8-flag...@chromium.org, v8-re...@googlegroups.com

Attention needed from Nico Hartmann and Sam Parker-Haynes

Message from chrom...@appspot.gserviceaccount.com

📍 Job mac-m4-mini-perf/jetstream-main.crossbench complete.

See results at: https://pinpoint-dot-chromeperf.appspot.com/job/17b4358b490000

unsatisfied_requirement

open

diffy

Sam Parker-Haynes (Gerrit)

unread,

Jun 3, 2026, 5:26:00 AM (7 days ago) Jun 3

to Darius Mercadier, chrom...@appspot.gserviceaccount.com, Nico Hartmann, v8-s...@luci-project-accounts.iam.gserviceaccount.com, dmercadi...@chromium.org, v8-flag...@chromium.org, v8-re...@googlegroups.com

Attention needed from Darius Mercadier and Nico Hartmann

Sam Parker-Haynes added 1 comment

Patchset-level comments

Sam Parker-Haynes

Thanks. So are we good w.r.t to performance?

Related details

Attention is currently required from:

Darius Mercadier
Nico Hartmann

Submit Requirements:

Code-Owners
Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

unsatisfied_requirement

open

diffy

Darius Mercadier (Gerrit)

unread,

Jun 3, 2026, 5:27:31 AM (7 days ago) Jun 3

to Sam Parker-Haynes, chrom...@appspot.gserviceaccount.com, Nico Hartmann, v8-s...@luci-project-accounts.iam.gserviceaccount.com, dmercadi...@chromium.org, v8-flag...@chromium.org, v8-re...@googlegroups.com

Attention needed from Nico Hartmann and Sam Parker-Haynes

Darius Mercadier added 1 comment

Patchset-level comments

Darius Mercadier

Yep looks good thanks :)

File-level comment, Patchset 4 (Latest):

Related details

Attention is currently required from:

Nico Hartmann
Sam Parker-Haynes

Submit Requirements:

Code-Owners
Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

unsatisfied_requirement

open

diffy

Sam Parker-Haynes (Gerrit)

unread,

Jun 8, 2026, 9:07:51 AM (2 days ago) Jun 8

to Darius Mercadier, chrom...@appspot.gserviceaccount.com, Nico Hartmann, v8-s...@luci-project-accounts.iam.gserviceaccount.com, dmercadi...@chromium.org, v8-flag...@chromium.org, v8-re...@googlegroups.com

Attention needed from Nico Hartmann

Sam Parker-Haynes added 1 comment

Patchset-level comments

Sam Parker-Haynes . resolved

@nicoha...@chromium.org Could you PTAL?

File-level comment, Patchset 4 (Latest):

Related details

Attention is currently required from:

Nico Hartmann

Submit Requirements:

Code-Owners
Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

unsatisfied_requirement

open

diffy

Nico Hartmann (Gerrit)

unread,

Jun 9, 2026, 9:54:46 AM (19 hours ago) Jun 9

to Sam Parker-Haynes, Darius Mercadier, chrom...@appspot.gserviceaccount.com, v8-s...@luci-project-accounts.iam.gserviceaccount.com, dmercadi...@chromium.org, v8-flag...@chromium.org, v8-re...@googlegroups.com

Attention needed from Sam Parker-Haynes

Nico Hartmann voted and added 1 comment

Votes added by Nico Hartmann

Code-Review

+1

1 comment

Patchset-level comments

Nico Hartmann . resolved

LGTM

Related details

Attention is currently required from:

Sam Parker-Haynes

Submit Requirements:

Code-Owners
Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

open

diffy

Sam Parker-Haynes (Gerrit)

unread,

Jun 9, 2026, 11:17:36 AM (18 hours ago) Jun 9

to Nico Hartmann, Darius Mercadier, chrom...@appspot.gserviceaccount.com, v8-s...@luci-project-accounts.iam.gserviceaccount.com, dmercadi...@chromium.org, v8-flag...@chromium.org, v8-re...@googlegroups.com

Sam Parker-Haynes voted Commit-Queue+2

Commit-Queue

+2

Related details

Attention set is empty

Submit Requirements:

Code-Owners
Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

open

diffy

v8-scoped@luci-project-accounts.iam.gserviceaccount.com (Gerrit)

unread,

Jun 9, 2026, 12:36:22 PM (17 hours ago) Jun 9

to Sam Parker-Haynes, Nico Hartmann, Darius Mercadier, chrom...@appspot.gserviceaccount.com, dmercadi...@chromium.org, v8-flag...@chromium.org, v8-re...@googlegroups.com

v8-s...@luci-project-accounts.iam.gserviceaccount.com submitted the change

Change information

Commit message:

[compiler] Instruction scheduler tweaks

- Don't add function parameter nops to the graph, just schedule them.
- Introduce data_successors, and use them to compute total latencies.
- Introduce a tie-breaking heuristic to PopBestCandidate, controlled via
  the new flag: --experimental-turbo-instruction-scheduling.
- Introduce tracing.

Change-Id: I134baf8d16b788c3ddd3db7d10389384354552bc

Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/7894598

Reviewed-by: Nico Hartmann <nicoha...@chromium.org>

Commit-Queue: Sam Parker-Haynes <sam.p...@arm.com>

Cr-Commit-Position: refs/heads/main@{#107867}

Files:

M src/compiler/backend/instruction-scheduler.cc
M src/compiler/backend/instruction-scheduler.h
M src/flags/flag-definitions.h

Change size: M

Delta: 3 files changed, 140 insertions(+), 76 deletions(-)

Branch: refs/heads/main

Submit Requirements:

Code-Review: +1 by Nico Hartmann