[heap] Trivial stylistic refactorings around BasePage and friends [v8/v8 : main]
0 views
Skip to first unread message
Michael Lippautz (Gerrit)
9:52 AM (12 hours ago) 9:52 AM
to Dominik Inführ, Hannes Payer, mlippau...@chromium.org, v8-re...@googlegroups.com
Attention needed from Dominik Inführ
Michael Lippautz voted and added 1 comment![]( "Open in Gerrit")
Votes added by Michael Lippautz
| Auto-Submit | +1 |
| Commit-Queue | +1 |
1 comment
File src/heap/free-list.h
Line 314, Patchset 1 (Latest):
static constexpr size_t kMaxBlockSize = kRegularPageSize;Michael Lippautz . resolved
This is the only site that cannot be NormalPage::kPageSize due to recursive includese.
Related details
Attention is currently required from:
- Dominik Inführ
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Dominik Inführ (Gerrit)
11:05 AM (11 hours ago) 11:05 AM
to Michael Lippautz, V8 LUCI CQ, Hannes Payer, mlippau...@chromium.org, v8-re...@googlegroups.com
Attention needed from Michael Lippautz
Dominik Inführ voted and added 1 comment![]( "Open in Gerrit")
Votes added by Dominik Inführ
| Code-Review | +1 |
1 comment
Patchset-level comments
Related details
Attention is currently required from:
- Michael Lippautz
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Michael Lippautz (Gerrit)
2:26 PM (8 hours ago) 2:26 PM
to Dominik Inführ, V8 LUCI CQ, Hannes Payer, mlippau...@chromium.org, v8-re...@googlegroups.com
Michael Lippautz voted Commit-Queue+2![]( "Open in Gerrit")
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
V8 LUCI CQ (Gerrit)
2:28 PM (8 hours ago) 2:28 PM
to Michael Lippautz, Dominik Inführ, Hannes Payer, mlippau...@chromium.org, v8-re...@googlegroups.com
V8 LUCI CQ submitted the change![]( "Open in Gerrit")
Change information
Commit message:
[heap] Trivial stylistic refactorings around BasePage and friends
Bug: 474140208
Change-Id: I980ba5c2dd069ccd9d2aaa63f314d832ed729487
Reviewed-by: Dominik Inführ <dinf...@chromium.org>
Commit-Queue: Michael Lippautz <mlip...@chromium.org>
Auto-Submit: Michael Lippautz <mlip...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#104651}
Files:
- M src/heap/base-page-inl.h
- M src/heap/base-page.h
- M src/heap/code-range.cc
- M src/heap/free-list.h
- M src/heap/heap.cc
- M src/heap/memory-allocator.cc
- M src/heap/mutable-page-inl.h
- M src/heap/mutable-page.h
- M src/heap/normal-page-inl.h
- M src/heap/normal-page.h
- M src/heap/trusted-range.cc
- M test/unittests/heap/spaces-unittest.cc
Change size: M
Delta: 12 files changed, 40 insertions(+), 46 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Dominik Inführ
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages