[v8] Convert to UNSAFE_TODO [v8/v8 : main]

0 views
Skip to first unread message

Arthur Sonzogni (Gerrit)

unread,
Apr 3, 2026, 5:51:49 AM (3 days ago) Apr 3
to v8-re...@googlegroups.com, cbruni...@chromium.org, v8-m...@googlegroups.com

Arthur Sonzogni has uploaded the change for review

Commit message

[v8] Convert to UNSAFE_TODO

[v8] Convert to UNSAFE_TODO

We are migrating from coarse-grained file-level suppression (#pragma
allow_unsafe_buffers) to granular, expression-level markers
(UNSAFE_TODO()). The pragma disables safety checks for an entire file,
whereas UNSAFE_TODO() isolates specific potentially unsafe operations,
allowing the rest of the file to be enforced as safe.

Script: https://docs.google.com/document/d/1ORQGBNn2R-CEvNbDTjRd-GrOBOFlCxIHdcvSUA_EhR4/edit?usp=sharing
AX-Relnotes: N/A
Cleanup: This is an automated #cleanup.
Bug: 409340989


Version 14.8.178
Change-Id: I56f0ea2d673ce7b8c83e5f6fec1dc4e38a99ee3e
Cr-Commit-Position: refs/heads/14.8.178@{#1}
Cr-Branched-From: 141232520dc4910401240c531db3af36910a0fd1-refs/heads/main@{#106240}

Change diff

diff --git a/WATCHLISTS b/WATCHLISTS
index d21b129..db847a3 100644
--- a/WATCHLISTS
+++ b/WATCHLISTS
@@ -149,7 +149,7 @@
],
'merges': [
# Only enabled on branches created with tools/release/create_release.py
- # 'v8-m...@googlegroups.com',
+ 'v8-m...@googlegroups.com',
],
'wasm': [
'was...@google.com',
diff --git a/include/v8-version.h b/include/v8-version.h
index bfb015a..4a55fe6 100644
--- a/include/v8-version.h
+++ b/include/v8-version.h
@@ -10,11 +10,11 @@
// system so their names cannot be changed without changing the scripts.
#define V8_MAJOR_VERSION 14
#define V8_MINOR_VERSION 8
-#define V8_BUILD_NUMBER 0
+#define V8_BUILD_NUMBER 178
#define V8_PATCH_LEVEL 0

// Use 1 for candidates and 0 otherwise.
// (Boolean macro values are not supported by all preprocessors.)
-#define V8_IS_CANDIDATE_VERSION 1
+#define V8_IS_CANDIDATE_VERSION 0

#endif // V8_INCLUDE_VERSION_H_
diff --git a/src/base/numerics/basic_ops_impl.h b/src/base/numerics/basic_ops_impl.h
index 8df445c..6e994b3 100644
--- a/src/base/numerics/basic_ops_impl.h
+++ b/src/base/numerics/basic_ops_impl.h
@@ -5,10 +5,6 @@
// Slightly adapted for inclusion in V8.
// Copyright 2025 the V8 project authors. All rights reserved.

-#ifdef UNSAFE_BUFFERS_BUILD
-// TODO(crbug.com/390223051): Remove C-library calls to fix the errors.
-#pragma allow_unsafe_libc_calls
-#endif

#ifndef V8_BASE_NUMERICS_BASIC_OPS_IMPL_H_
#define V8_BASE_NUMERICS_BASIC_OPS_IMPL_H_

Change information

Files:
  • M WATCHLISTS
  • M include/v8-version.h
  • M src/base/numerics/basic_ops_impl.h
Change size: S
Delta: 3 files changed, 3 insertions(+), 7 deletions(-)
Open in Gerrit

Related details

Attention set is empty
Submit Requirements:
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: newchange
Gerrit-Project: v8/v8
Gerrit-Branch: main
Gerrit-Change-Id: I56f0ea2d673ce7b8c83e5f6fec1dc4e38a99ee3e
Gerrit-Change-Number: 7726225
Gerrit-PatchSet: 1
Gerrit-Owner: Arthur Sonzogni <arthurs...@chromium.org>
Gerrit-Reviewer: Arthur Sonzogni <arthurs...@chromium.org>
unsatisfied_requirement
open
diffy
Reply all
Reply to author
Forward
0 new messages