PPC: Implement addpcis [v8/v8 : main]

0 views
Skip to first unread message

rt-node-js-v8 (Gerrit)

unread,
Apr 2, 2026, 9:53:43 AM (4 days ago) Apr 2
to Milad Farazmand, dmercadi...@chromium.org, v8-re...@googlegroups.com
Attention needed from Milad Farazmand

Message from rt-node-js-v8

LGTM

Open in Gerrit

Related details

Attention is currently required from:
  • Milad Farazmand
Submit Requirements:
  • requirement satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: v8/v8
Gerrit-Branch: main
Gerrit-Change-Id: I7bdba69a1d6ea1b953134407af115d96aeafda1b
Gerrit-Change-Number: 7725801
Gerrit-PatchSet: 2
Gerrit-Owner: Milad Farazmand <mfar...@ibm.com>
Gerrit-CC: rt-node-js-v8 <rt-node-js...@ibm.com>
Gerrit-Attention: Milad Farazmand <mfar...@ibm.com>
Gerrit-Comment-Date: Thu, 02 Apr 2026 13:53:39 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
satisfied_requirement
unsatisfied_requirement
open
diffy

John (Gerrit)

unread,
Apr 2, 2026, 1:04:15 PM (4 days ago) Apr 2
to Milad Farazmand, V8 LUCI CQ, rt-node-js-v8, dmercadi...@chromium.org, v8-re...@googlegroups.com
Attention needed from Milad Farazmand

John voted Code-Review+1

Code-Review+1
Open in Gerrit

Related details

Attention is currently required from:
  • Milad Farazmand
Submit Requirements:
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: v8/v8
Gerrit-Branch: main
Gerrit-Change-Id: I7bdba69a1d6ea1b953134407af115d96aeafda1b
Gerrit-Change-Number: 7725801
Gerrit-PatchSet: 2
Gerrit-Owner: Milad Farazmand <mfar...@ibm.com>
Gerrit-Reviewer: John <jun...@ibm.com>
Gerrit-Reviewer: Milad Farazmand <mfar...@ibm.com>
Gerrit-CC: rt-node-js-v8 <rt-node-js...@ibm.com>
Gerrit-Attention: Milad Farazmand <mfar...@ibm.com>
Gerrit-Comment-Date: Thu, 02 Apr 2026 17:04:12 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

Milad Farazmand (Gerrit)

unread,
Apr 2, 2026, 2:24:59 PM (4 days ago) Apr 2
to John, V8 LUCI CQ, rt-node-js-v8, dmercadi...@chromium.org, v8-re...@googlegroups.com

Milad Farazmand voted Commit-Queue+2

Commit-Queue+2
Open in Gerrit

Related details

Attention set is empty
Submit Requirements:
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: v8/v8
Gerrit-Branch: main
Gerrit-Change-Id: I7bdba69a1d6ea1b953134407af115d96aeafda1b
Gerrit-Change-Number: 7725801
Gerrit-PatchSet: 2
Gerrit-Owner: Milad Farazmand <mfar...@ibm.com>
Gerrit-Reviewer: John <jun...@ibm.com>
Gerrit-Reviewer: Milad Farazmand <mfar...@ibm.com>
Gerrit-CC: rt-node-js-v8 <rt-node-js...@ibm.com>
Gerrit-Comment-Date: Thu, 02 Apr 2026 18:24:56 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

V8 LUCI CQ (Gerrit)

unread,
Apr 2, 2026, 2:26:33 PM (4 days ago) Apr 2
to Milad Farazmand, John, rt-node-js-v8, dmercadi...@chromium.org, v8-re...@googlegroups.com

V8 LUCI CQ submitted the change

Change information

Commit message:
PPC: Implement addpcis

... and use it under LoadPC. This approach no longer clobbers LR
therefore we don't need to save it and restore it later. Adding a nop
also makes LoadPC emit 2 instructions which aligns with the previous
approach.
Change-Id: I7bdba69a1d6ea1b953134407af115d96aeafda1b
Reviewed-by: John <jun...@ibm.com>
Commit-Queue: Milad Farazmand <mfar...@ibm.com>
Cr-Commit-Position: refs/heads/main@{#106256}
Files:
  • M src/codegen/ppc/assembler-ppc.cc
  • M src/codegen/ppc/assembler-ppc.h
  • M src/codegen/ppc/constants-ppc.h
  • M src/codegen/ppc/macro-assembler-ppc.cc
  • M src/compiler/backend/ppc/code-generator-ppc.cc
  • M src/diagnostics/ppc/disasm-ppc.cc
  • M src/execution/ppc/simulator-ppc.cc
Change size: M
Delta: 7 files changed, 52 insertions(+), 8 deletions(-)
Branch: refs/heads/main
Submit Requirements:
  • requirement satisfiedCode-Review: +1 by John
Open in Gerrit
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: merged
Gerrit-Project: v8/v8
Gerrit-Branch: main
Gerrit-Change-Id: I7bdba69a1d6ea1b953134407af115d96aeafda1b
Gerrit-Change-Number: 7725801
Gerrit-PatchSet: 3
Gerrit-Owner: Milad Farazmand <mfar...@ibm.com>
Gerrit-Reviewer: John <jun...@ibm.com>
Gerrit-Reviewer: Milad Farazmand <mfar...@ibm.com>
Gerrit-CC: rt-node-js-v8 <rt-node-js...@ibm.com>
open
diffy
satisfied_requirement
Reply all
Reply to author
Forward
0 new messages