PPC: Implement addpcis [v8/v8 : main]
0 views
Skip to first unread message
rt-node-js-v8 (Gerrit)
Apr 2, 2026, 9:53:43 AM (4 days ago) Apr 2
to Milad Farazmand, dmercadi...@chromium.org, v8-re...@googlegroups.com
Attention needed from Milad Farazmand
Message from rt-node-js-v8![]( "Open in Gerrit")
LGTM
Related details
Attention is currently required from:
- Milad Farazmand
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
John (Gerrit)
Apr 2, 2026, 1:04:15 PM (4 days ago) Apr 2
to Milad Farazmand, V8 LUCI CQ, rt-node-js-v8, dmercadi...@chromium.org, v8-re...@googlegroups.com
Attention needed from Milad Farazmand
John voted Code-Review+1![]( "Open in Gerrit")
| Code-Review | +1 |
Related details
Attention is currently required from:
- Milad Farazmand
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Milad Farazmand (Gerrit)
Apr 2, 2026, 2:24:59 PM (4 days ago) Apr 2
to John, V8 LUCI CQ, rt-node-js-v8, dmercadi...@chromium.org, v8-re...@googlegroups.com
Milad Farazmand voted Commit-Queue+2![]( "Open in Gerrit")
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
V8 LUCI CQ (Gerrit)
Apr 2, 2026, 2:26:33 PM (4 days ago) Apr 2
to Milad Farazmand, John, rt-node-js-v8, dmercadi...@chromium.org, v8-re...@googlegroups.com
V8 LUCI CQ submitted the change![]( "Open in Gerrit")
Change information
Commit message:
PPC: Implement addpcis
... and use it under LoadPC. This approach no longer clobbers LR
therefore we don't need to save it and restore it later. Adding a nop
also makes LoadPC emit 2 instructions which aligns with the previous
approach.
Change-Id: I7bdba69a1d6ea1b953134407af115d96aeafda1b
Reviewed-by: John <jun...@ibm.com>
Commit-Queue: Milad Farazmand <mfar...@ibm.com>
Cr-Commit-Position: refs/heads/main@{#106256}
Files:
- M src/codegen/ppc/assembler-ppc.cc
- M src/codegen/ppc/assembler-ppc.h
- M src/codegen/ppc/constants-ppc.h
- M src/codegen/ppc/macro-assembler-ppc.cc
- M src/compiler/backend/ppc/code-generator-ppc.cc
- M src/diagnostics/ppc/disasm-ppc.cc
- M src/execution/ppc/simulator-ppc.cc
Change size: M
Delta: 7 files changed, 52 insertions(+), 8 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by John
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages