[heap] Remove ExternalBackingStoreType::kArrayBuffer [v8/v8 : main]
0 views
Skip to first unread message
Dominik Inführ (Gerrit)
Nov 17, 2025, 6:40:28 AM (2 days ago) Nov 17
to Michael Lippautz, V8 LUCI CQ, Hannes Payer, mlippau...@chromium.org, v8-re...@googlegroups.com, victorgo...@chromium.org
Attention needed from Michael Lippautz
Dominik Inführ voted and added 1 comment![]( "Open in Gerrit")
Votes added by Dominik Inführ
| Commit-Queue | +1 |
1 comment
Patchset-level comments
Related details
Attention is currently required from:
- Michael Lippautz
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Michael Lippautz (Gerrit)
Nov 18, 2025, 7:16:15 AM (yesterday) Nov 18
to Dominik Inführ, V8 LUCI CQ, Hannes Payer, mlippau...@chromium.org, v8-re...@googlegroups.com, victorgo...@chromium.org
Attention needed from Dominik Inführ
Michael Lippautz voted Code-Review+1![]( "Open in Gerrit")
Attention is currently required from:
- Dominik Inführ
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Dominik Inführ (Gerrit)
Nov 18, 2025, 7:23:44 AM (yesterday) Nov 18
to Michael Lippautz, V8 LUCI CQ, Hannes Payer, mlippau...@chromium.org, v8-re...@googlegroups.com, victorgo...@chromium.org
Dominik Inführ voted and added 1 comment![]( "Open in Gerrit")
Votes added by Dominik Inführ
| Commit-Queue | +2 |
1 comment
Patchset-level comments
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
V8 LUCI CQ (Gerrit)
Nov 18, 2025, 8:09:49 AM (yesterday) Nov 18
to Dominik Inführ, Michael Lippautz, Hannes Payer, mlippau...@chromium.org, v8-re...@googlegroups.com, victorgo...@chromium.org
V8 LUCI CQ submitted the change![]( "Open in Gerrit")
Change information
Commit message:
[heap] Remove ExternalBackingStoreType::kArrayBuffer
This CL removes ExternalBackingStoreType::kArrayBuffer. We only
use the counter for array buffers in
NewSpace::ExternalBackingStoreOverallBytes(). This method is used by
Heap::AllocateExternalBackingStoreBytes().
We keep this working as-is by adding a new method
YoungAllocatedExternalBackingStoreBytes() for this instead. It
combines NewSpace::ExternalBackingStoreOverallBytes() and the
young array buffer size.
This CL does not address the bytes_ overflow issue in the linked
bug yet. This will be done in a follow-up CL.
Bug: 460166671
Change-Id: I30f4a2b0cebd8aed95c743dfa72d9611a8239b68
Commit-Queue: Dominik Inführ <dinf...@chromium.org>
Reviewed-by: Michael Lippautz <mlip...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#103787}
Files:
- M src/common/globals.h
- M src/heap/array-buffer-sweeper.cc
- M src/heap/array-buffer-sweeper.h
- M src/heap/heap.cc
- M src/heap/heap.h
- M src/heap/new-spaces.cc
- M src/heap/new-spaces.h
- M src/heap/paged-spaces.cc
- M src/heap/paged-spaces.h
- M test/cctest/BUILD.gn
- R test/cctest/heap/test-array-buffer-sweeper.cc
Change size: M
Delta: 11 files changed, 33 insertions(+), 69 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Michael Lippautz
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages