PPC/s390: [maglev] Handle equal inputs in Float64Max/Min [v8/v8 : main]
0 views
Skip to first unread message
Victor Gomes (Gerrit)
Feb 23, 2026, 11:03:12 AM (22 hours ago) Feb 23
to Milad Farazmand, John, dmercadi...@chromium.org, leszek...@chromium.org, v8-re...@googlegroups.com, verwaes...@chromium.org, victorgo...@chromium.org
Attention needed from John and Milad Farazmand
Victor Gomes voted and added 1 comment![]( "Open in Gerrit")
Votes added by Victor Gomes
| Code-Review | +1 |
1 comment
Patchset-level comments
Related details
Attention is currently required from:
- John
- Milad Farazmand
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
rt-node-js-v8 (Gerrit)
Feb 23, 2026, 11:03:45 AM (22 hours ago) Feb 23
to Milad Farazmand, Victor Gomes, John, dmercadi...@chromium.org, leszek...@chromium.org, v8-re...@googlegroups.com, verwaes...@chromium.org, victorgo...@chromium.org
Attention needed from John and Milad Farazmand
Message from rt-node-js-v8![]( "Open in Gerrit")
Port LGTM
Related details
Attention is currently required from:
- John
- Milad Farazmand
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Milad Farazmand (Gerrit)
Feb 23, 2026, 11:07:08 AM (22 hours ago) Feb 23
to rt-node-js-v8, Victor Gomes, John, dmercadi...@chromium.org, leszek...@chromium.org, v8-re...@googlegroups.com, verwaes...@chromium.org, victorgo...@chromium.org
Related details
Attention is currently required from:
- John
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Milad Farazmand (Gerrit)
Feb 23, 2026, 2:48:25 PM (18 hours ago) Feb 23
to V8 LUCI CQ, rt-node-js-v8, Victor Gomes, John, dmercadi...@chromium.org, leszek...@chromium.org, v8-re...@googlegroups.com, verwaes...@chromium.org, victorgo...@chromium.org
Attention needed from John
Milad Farazmand voted Commit-Queue+2![]( "Open in Gerrit")
| Commit-Queue | +2 |
Related details
Attention is currently required from:
- John
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
V8 LUCI CQ (Gerrit)
8:13 AM (1 hour ago) 8:13 AM
to Milad Farazmand, rt-node-js-v8, Victor Gomes, John, dmercadi...@chromium.org, leszek...@chromium.org, v8-re...@googlegroups.com, verwaes...@chromium.org, victorgo...@chromium.org
V8 LUCI CQ submitted the change with unreviewed changes![]( "Open in Gerrit")
Unreviewed changes
1 is the latest approved patch-set.
The change was submitted with unreviewed changes in the following files:
```
The name of the file: src/maglev/ppc/maglev-ir-ppc.cc
Insertions: 2, Deletions: 0.
@@ -823,6 +823,7 @@
DCHECK_EQ(ToDoubleRegister(result()), ToDoubleRegister(LeftInput()));
return;
}
+
DoubleRegister left = ToDoubleRegister(LeftInput());
DoubleRegister right = ToDoubleRegister(RightInput());
DoubleRegister out = ToDoubleRegister(result());
@@ -845,6 +846,7 @@
DCHECK_EQ(ToDoubleRegister(result()), ToDoubleRegister(LeftInput()));
return;
}
+
DoubleRegister left = ToDoubleRegister(LeftInput());
DoubleRegister right = ToDoubleRegister(RightInput());
DoubleRegister out = ToDoubleRegister(result());
```
```
The name of the file: src/maglev/s390/maglev-ir-s390.cc
Insertions: 2, Deletions: 0.
@@ -807,6 +807,7 @@
DCHECK_EQ(ToDoubleRegister(result()), ToDoubleRegister(LeftInput()));
return;
}
+
DoubleRegister left = ToDoubleRegister(LeftInput());
DoubleRegister right = ToDoubleRegister(RightInput());
DoubleRegister out = ToDoubleRegister(result());
@@ -829,6 +830,7 @@
DCHECK_EQ(ToDoubleRegister(result()), ToDoubleRegister(LeftInput()));
return;
}
+
DoubleRegister left = ToDoubleRegister(LeftInput());
DoubleRegister right = ToDoubleRegister(RightInput());
DoubleRegister out = ToDoubleRegister(result());
```
Change information
Commit message:
PPC/s390: [maglev] Handle equal inputs in Float64Max/Min
Port 020934e177a8ffae9c978bbbfe8690e2697360f2
Original Commit Message:
A DCHECK failure left != right in macro-assembler-arm.cc was triggered
because the compiler was emitting Float64Max (or Min) nodes where both
inputs were the same register.
While Maglev generally avoids emitting these nodes if the inputs are
known to be equal, this case can still occur after unwrapping conversion
nodes during the phi untagging phase.
R=victo...@chromium.org, jun...@ibm.com
BUG=
LOG=N
Change-Id: Ic4fa118831a916a5194bd5694fbf14a46ff58d62
Commit-Queue: Milad Farazmand <mfar...@ibm.com>
Reviewed-by: Victor Gomes <victo...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#105414}
Files:
- M src/maglev/ppc/maglev-ir-ppc.cc
- M src/maglev/s390/maglev-ir-s390.cc
Change size: S
Delta: 2 files changed, 40 insertions(+), 4 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Victor Gomes
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages