[gcmole] Ignore [[noreturn]] methods in callgraph [v8/v8 : main]
0 views
Skip to first unread message
Leszek Swirski (Gerrit)
11:05 AM (10 hours ago) 11:05 AM
to Maksim Ivanov, v8-re...@googlegroups.com
Attention needed from Maksim Ivanov
Leszek Swirski voted and added 1 comment![]( "Open in Gerrit")
Votes added by Leszek Swirski
| Auto-Submit | +1 |
| Commit-Queue | +1 |
1 comment
Patchset-level comments
Related details
Attention is currently required from:
- Maksim Ivanov
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Maksim Ivanov (Gerrit)
11:37 AM (10 hours ago) 11:37 AM
to Leszek Swirski, v8-s...@luci-project-accounts.iam.gserviceaccount.com, v8-re...@googlegroups.com
Attention needed from Leszek Swirski
Maksim Ivanov voted Code-Review+1![]( "Open in Gerrit")
Attention is currently required from:
- Leszek Swirski
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Maksim Ivanov (Gerrit)
11:39 AM (10 hours ago) 11:39 AM
to Leszek Swirski, v8-s...@luci-project-accounts.iam.gserviceaccount.com, v8-re...@googlegroups.com
Attention needed from Leszek Swirski
Maksim Ivanov added 1 comment![]( "Open in Gerrit")
Patchset-level comments
Maksim Ivanov . resolved
thanks for looking into this!
Related details
Attention is currently required from:
- Leszek Swirski
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Leszek Swirski (Gerrit)
11:40 AM (10 hours ago) 11:40 AM
to Maksim Ivanov, v8-s...@luci-project-accounts.iam.gserviceaccount.com, v8-re...@googlegroups.com
Leszek Swirski voted Commit-Queue+2![]( "Open in Gerrit")
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Leszek Swirski (Gerrit)
4:34 PM (5 hours ago) 4:34 PM
to Maksim Ivanov, v8-s...@luci-project-accounts.iam.gserviceaccount.com, v8-re...@googlegroups.com
Attention needed from Maksim Ivanov
Leszek Swirski voted and added 1 comment![]( "Open in Gerrit")
Votes added by Leszek Swirski
| Auto-Submit | +1 |
| Commit-Queue | +1 |
1 comment
Patchset-level comments
File-level comment, Patchset 4 (Latest):
Leszek Swirski . resolved
PTAL again, had to remove the test until gcmole rolls.
Related details
Attention is currently required from:
- Maksim Ivanov
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Maksim Ivanov (Gerrit)
6:09 PM (3 hours ago) 6:09 PM
to Leszek Swirski, v8-s...@luci-project-accounts.iam.gserviceaccount.com, v8-re...@googlegroups.com
Attention needed from Leszek Swirski
Maksim Ivanov voted![]( "Open in Gerrit")
Attention is currently required from:
- Leszek Swirski
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
v8-scoped@luci-project-accounts.iam.gserviceaccount.com (Gerrit)
6:11 PM (3 hours ago) 6:11 PM
to Leszek Swirski, Maksim Ivanov, v8-re...@googlegroups.com
v8-s...@luci-project-accounts.iam.gserviceaccount.com submitted the change![]( "Open in Gerrit")
Change information
Commit message:
[gcmole] Ignore [[noreturn]] methods in callgraph
Ignore functions marked with [[noreturn]] (or equivalent attributes) in the
GCMole Clang plugin. This prevents false positive GC-suspect propagation
through functions that never return, such as OOM crash handlers.
Bug: 42202654, 512734866
TAG=agy
CONV=a395481f-0408-4c4d-ae72-2e9d8e6f0eff
Change-Id: Idfbd9bfa5af7112e83a978f12d71ba804fe109e6
Auto-Submit: Leszek Swirski <les...@chromium.org>
Reviewed-by: Maksim Ivanov <em...@chromium.org>
Commit-Queue: Maksim Ivanov <em...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#107436}
Files:
- M tools/gcmole/gcmole.cc
Change size: XS
Delta: 1 file changed, 1 insertion(+), 0 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Maksim Ivanov
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages