[wasmfx] Better error message for unhandled suspension [v8/v8 : main]

0 views
Skip to first unread message

Thibaud Michaud (Gerrit)

unread,
9:43 AM (12 hours ago) 9:43 AM
to V8 LUCI CQ, Clemens Backes, v8-mip...@googlegroups.com, v8-ppc...@googlegroups.com, v8-re...@googlegroups.com, v8-risc...@chromium.org, was...@google.com
Attention needed from Clemens Backes

Thibaud Michaud added 1 comment

Patchset-level comments
File-level comment, Patchset 1 (Latest):
Thibaud Michaud . resolved

PTAL

Open in Gerrit

Related details

Attention is currently required from:
  • Clemens Backes
Submit Requirements:
  • requirement satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: v8/v8
Gerrit-Branch: main
Gerrit-Change-Id: I0a0ee353ee984a4fab205c0e7260e8a3b25a5435
Gerrit-Change-Number: 7452241
Gerrit-PatchSet: 1
Gerrit-Owner: Thibaud Michaud <thib...@chromium.org>
Gerrit-Reviewer: Clemens Backes <clem...@chromium.org>
Gerrit-Reviewer: Thibaud Michaud <thib...@chromium.org>
Gerrit-Attention: Clemens Backes <clem...@chromium.org>
Gerrit-Comment-Date: Mon, 12 Jan 2026 14:43:50 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
satisfied_requirement
unsatisfied_requirement
open
diffy

Clemens Backes (Gerrit)

unread,
9:47 AM (12 hours ago) 9:47 AM
to Thibaud Michaud, V8 LUCI CQ, v8-mip...@googlegroups.com, v8-ppc...@googlegroups.com, v8-re...@googlegroups.com, v8-risc...@chromium.org, was...@google.com
Attention needed from Thibaud Michaud

Clemens Backes voted Code-Review+1

Code-Review+1
Open in Gerrit

Related details

Attention is currently required from:
  • Thibaud Michaud
Submit Requirements:
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: v8/v8
Gerrit-Branch: main
Gerrit-Change-Id: I0a0ee353ee984a4fab205c0e7260e8a3b25a5435
Gerrit-Change-Number: 7452241
Gerrit-PatchSet: 1
Gerrit-Owner: Thibaud Michaud <thib...@chromium.org>
Gerrit-Reviewer: Clemens Backes <clem...@chromium.org>
Gerrit-Reviewer: Thibaud Michaud <thib...@chromium.org>
Gerrit-Attention: Thibaud Michaud <thib...@chromium.org>
Gerrit-Comment-Date: Mon, 12 Jan 2026 14:47:38 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

Thibaud Michaud (Gerrit)

unread,
9:51 AM (12 hours ago) 9:51 AM
to Clemens Backes, V8 LUCI CQ, v8-mip...@googlegroups.com, v8-ppc...@googlegroups.com, v8-re...@googlegroups.com, v8-risc...@chromium.org, was...@google.com

Thibaud Michaud voted Commit-Queue+2

Commit-Queue+2
Open in Gerrit

Related details

Attention set is empty
Submit Requirements:
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: v8/v8
Gerrit-Branch: main
Gerrit-Change-Id: I0a0ee353ee984a4fab205c0e7260e8a3b25a5435
Gerrit-Change-Number: 7452241
Gerrit-PatchSet: 1
Gerrit-Owner: Thibaud Michaud <thib...@chromium.org>
Gerrit-Reviewer: Clemens Backes <clem...@chromium.org>
Gerrit-Reviewer: Thibaud Michaud <thib...@chromium.org>
Gerrit-Comment-Date: Mon, 12 Jan 2026 14:51:44 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

V8 LUCI CQ (Gerrit)

unread,
9:53 AM (12 hours ago) 9:53 AM
to Thibaud Michaud, Clemens Backes, v8-mip...@googlegroups.com, v8-ppc...@googlegroups.com, v8-re...@googlegroups.com, v8-risc...@chromium.org, was...@google.com

V8 LUCI CQ submitted the change

Change information

Commit message:
[wasmfx] Better error message for unhandled suspension

An unhandled WasmFX suspension prints a JSPI error message at the
moment. Introduce a specific WasmFX error message.

R=clem...@chromium.org
Bug: 388533754
Change-Id: I0a0ee353ee984a4fab205c0e7260e8a3b25a5435
Commit-Queue: Thibaud Michaud <thib...@chromium.org>
Reviewed-by: Clemens Backes <clem...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#104641}
Files:
  • M src/builtins/arm/builtins-arm.cc
  • M src/builtins/arm64/builtins-arm64.cc
  • M src/builtins/ia32/builtins-ia32.cc
  • M src/builtins/loong64/builtins-loong64.cc
  • M src/builtins/ppc/builtins-ppc.cc
  • M src/builtins/riscv/builtins-riscv.cc
  • M src/builtins/s390/builtins-s390.cc
  • M src/builtins/x64/builtins-x64.cc
  • M src/common/message-template.h
  • M src/runtime/runtime-wasm.cc
  • M src/runtime/runtime.cc
  • M src/runtime/runtime.h
  • M src/wasm/turboshaft-graph-interface.cc
  • M src/wasm/wrappers-inl.h
  • M test/mjsunit/wasm/stack-switching.js
Change size: M
Delta: 15 files changed, 33 insertions(+), 21 deletions(-)
Branch: refs/heads/main
Submit Requirements:
  • requirement satisfiedCode-Review: +1 by Clemens Backes
Open in Gerrit
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: merged
Gerrit-Project: v8/v8
Gerrit-Branch: main
Gerrit-Change-Id: I0a0ee353ee984a4fab205c0e7260e8a3b25a5435
Gerrit-Change-Number: 7452241
Gerrit-PatchSet: 2
Gerrit-Owner: Thibaud Michaud <thib...@chromium.org>
Gerrit-Reviewer: Clemens Backes <clem...@chromium.org>
Gerrit-Reviewer: Thibaud Michaud <thib...@chromium.org>
open
diffy
satisfied_requirement
Reply all
Reply to author
Forward
0 new messages