[Wasm Interpreter] Adding Drumbrake support for multiple memories [v8/v8 : main]

0 views
Skip to first unread message

Emmanuel Romero Ruiz (Gerrit)

unread,
Dec 12, 2025, 7:17:25 PM (3 days ago) Dec 12
to Paolo Severini, Clemens Backes, Jakob Linke, V8 LUCI CQ, v8-re...@googlegroups.com, was...@google.com
Attention needed from Clemens Backes, Jakob Linke and Paolo Severini

New activity on the change

Open in Gerrit

Related details

Attention is currently required from:
  • Clemens Backes
  • Jakob Linke
  • Paolo Severini
Submit Requirements:
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: v8/v8
Gerrit-Branch: main
Gerrit-Change-Id: Ibd5fcaacafd89b3c9ac35646f05657879cfd6034
Gerrit-Change-Number: 7255400
Gerrit-PatchSet: 7
Gerrit-Owner: Emmanuel Romero Ruiz <emro...@microsoft.com>
Gerrit-Reviewer: Clemens Backes <clem...@chromium.org>
Gerrit-Reviewer: Emmanuel Romero Ruiz <emro...@microsoft.com>
Gerrit-Reviewer: Jakob Linke <jgr...@chromium.org>
Gerrit-Reviewer: Paolo Severini <paol...@microsoft.com>
Gerrit-Attention: Jakob Linke <jgr...@chromium.org>
Gerrit-Attention: Paolo Severini <paol...@microsoft.com>
Gerrit-Attention: Clemens Backes <clem...@chromium.org>
Gerrit-Comment-Date: Sat, 13 Dec 2025 00:17:23 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
unsatisfied_requirement
open
diffy

Clemens Backes (Gerrit)

unread,
Dec 15, 2025, 11:05:00 AM (19 hours ago) Dec 15
to Emmanuel Romero Ruiz, Paolo Severini, Jakob Linke, V8 LUCI CQ, v8-re...@googlegroups.com, was...@google.com
Attention needed from Emmanuel Romero Ruiz and Jakob Linke

Clemens Backes voted and added 1 comment

Votes added by Clemens Backes

Code-Review+1

1 comment

Patchset-level comments
File-level comment, Patchset 7 (Latest):
Clemens Backes . resolved

Nice, LGTM.
I skipped the whole src/wasm/interpreter directory.

Open in Gerrit

Related details

Attention is currently required from:
  • Emmanuel Romero Ruiz
  • Jakob Linke
Submit Requirements:
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: v8/v8
Gerrit-Branch: main
Gerrit-Change-Id: Ibd5fcaacafd89b3c9ac35646f05657879cfd6034
Gerrit-Change-Number: 7255400
Gerrit-PatchSet: 7
Gerrit-Owner: Emmanuel Romero Ruiz <emro...@microsoft.com>
Gerrit-Reviewer: Clemens Backes <clem...@chromium.org>
Gerrit-Reviewer: Emmanuel Romero Ruiz <emro...@microsoft.com>
Gerrit-Reviewer: Jakob Linke <jgr...@chromium.org>
Gerrit-Reviewer: Paolo Severini <paol...@microsoft.com>
Gerrit-Attention: Jakob Linke <jgr...@chromium.org>
Gerrit-Attention: Emmanuel Romero Ruiz <emro...@microsoft.com>
Gerrit-Comment-Date: Mon, 15 Dec 2025 16:04:54 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
unsatisfied_requirement
open
diffy

Clemens Backes (Gerrit)

unread,
Dec 15, 2025, 11:11:05 AM (19 hours ago) Dec 15
to Emmanuel Romero Ruiz, Paolo Severini, Jakob Linke, V8 LUCI CQ, v8-re...@googlegroups.com, was...@google.com
Attention needed from Emmanuel Romero Ruiz and Jakob Linke

Clemens Backes added 1 comment

Commit Message
Line 33, Patchset 7 (Latest):Testing: All existing WASM tests pass. Multi-memory specific tests can
Clemens Backes . unresolved

nit: "Wasm", please.

Open in Gerrit

Related details

Attention is currently required from:
  • Emmanuel Romero Ruiz
  • Jakob Linke
Submit Requirements:
    • requirement is not satisfiedCode-Owners
    • requirement is not satisfiedCode-Review
    • requirement is not satisfiedNo-Unresolved-Comments
    • requirement is not satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: v8/v8
    Gerrit-Branch: main
    Gerrit-Change-Id: Ibd5fcaacafd89b3c9ac35646f05657879cfd6034
    Gerrit-Change-Number: 7255400
    Gerrit-PatchSet: 7
    Gerrit-Owner: Emmanuel Romero Ruiz <emro...@microsoft.com>
    Gerrit-Reviewer: Clemens Backes <clem...@chromium.org>
    Gerrit-Reviewer: Emmanuel Romero Ruiz <emro...@microsoft.com>
    Gerrit-Reviewer: Jakob Linke <jgr...@chromium.org>
    Gerrit-Reviewer: Paolo Severini <paol...@microsoft.com>
    Gerrit-Attention: Jakob Linke <jgr...@chromium.org>
    Gerrit-Attention: Emmanuel Romero Ruiz <emro...@microsoft.com>
    Gerrit-Comment-Date: Mon, 15 Dec 2025 16:11:00 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: No
    unsatisfied_requirement
    open
    diffy

    Emmanuel Romero Ruiz (Gerrit)

    unread,
    Dec 15, 2025, 11:12:48 AM (19 hours ago) Dec 15
    to Clemens Backes, Paolo Severini, Jakob Linke, V8 LUCI CQ, v8-re...@googlegroups.com, was...@google.com
    Attention needed from Jakob Linke

    Emmanuel Romero Ruiz added 1 comment

    Commit Message
    Line 33, Patchset 7:Testing: All existing WASM tests pass. Multi-memory specific tests can
    Clemens Backes . resolved

    nit: "Wasm", please.

    Emmanuel Romero Ruiz

    Done

    Open in Gerrit

    Related details

    Attention is currently required from:
    • Jakob Linke
    Submit Requirements:
      • requirement is not satisfiedCode-Owners
      • requirement is not satisfiedCode-Review
      • requirement is not satisfiedReview-Enforcement
      Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
      Gerrit-MessageType: comment
      Gerrit-Project: v8/v8
      Gerrit-Branch: main
      Gerrit-Change-Id: Ibd5fcaacafd89b3c9ac35646f05657879cfd6034
      Gerrit-Change-Number: 7255400
      Gerrit-PatchSet: 8
      Gerrit-Owner: Emmanuel Romero Ruiz <emro...@microsoft.com>
      Gerrit-Reviewer: Clemens Backes <clem...@chromium.org>
      Gerrit-Reviewer: Emmanuel Romero Ruiz <emro...@microsoft.com>
      Gerrit-Reviewer: Jakob Linke <jgr...@chromium.org>
      Gerrit-Reviewer: Paolo Severini <paol...@microsoft.com>
      Gerrit-Attention: Jakob Linke <jgr...@chromium.org>
      Gerrit-Comment-Date: Mon, 15 Dec 2025 16:12:44 +0000
      Gerrit-HasComments: Yes
      Gerrit-Has-Labels: No
      Comment-In-Reply-To: Clemens Backes <clem...@chromium.org>
      unsatisfied_requirement
      open
      diffy

      Jakob Linke (Gerrit)

      unread,
      5:18 AM (1 hour ago) 5:18 AM
      to Emmanuel Romero Ruiz, Clemens Backes, Paolo Severini, V8 LUCI CQ, v8-re...@googlegroups.com, was...@google.com
      Attention needed from Emmanuel Romero Ruiz

      Jakob Linke added 1 comment

      Patchset-level comments
      File-level comment, Patchset 8 (Latest):
      Jakob Linke . resolved

      I don't think you need my review for this CL; feel free to add me back otherwise.

      Open in Gerrit

      Related details

      Attention is currently required from:
      • Emmanuel Romero Ruiz
      Submit Requirements:
      • requirement is not satisfiedCode-Owners
      • requirement is not satisfiedCode-Review
      • requirement is not satisfiedReview-Enforcement
      Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
      Gerrit-MessageType: comment
      Gerrit-Project: v8/v8
      Gerrit-Branch: main
      Gerrit-Change-Id: Ibd5fcaacafd89b3c9ac35646f05657879cfd6034
      Gerrit-Change-Number: 7255400
      Gerrit-PatchSet: 8
      Gerrit-Owner: Emmanuel Romero Ruiz <emro...@microsoft.com>
      Gerrit-Reviewer: Clemens Backes <clem...@chromium.org>
      Gerrit-Reviewer: Emmanuel Romero Ruiz <emro...@microsoft.com>
      Gerrit-Reviewer: Paolo Severini <paol...@microsoft.com>
      Gerrit-Attention: Emmanuel Romero Ruiz <emro...@microsoft.com>
      Gerrit-Comment-Date: Tue, 16 Dec 2025 10:18:48 +0000
      Gerrit-HasComments: Yes
      Gerrit-Has-Labels: No
      unsatisfied_requirement
      open
      diffy
      Reply all
      Reply to author
      Forward
      0 new messages