Add core skills registry for v8 [v8/v8 : main]
Ashwin Verleker (Gerrit)
Ashwin Verleker voted Auto-Submit+1![]( "Open in Gerrit")
| Auto-Submit | +1 |
Related details
- Camillo Bruni
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Camillo Bruni (Gerrit)
Camillo Bruni added 2 comments![]( "Open in Gerrit")
'agents_internal_revision': '11c700b10e171091b4f0f3cf3bf95f13dee85c93',side quest: should we setup an autoroller instead? or is it too early for that?
{nit: It's a bit unclear what this file does or who uses it when seen in isolation.
side comments:
- Q1: Is this format defined somewhere?
- Q2: json is probably not the righ format since we can't add comments (have you considerd hjson or csv with comments)
- Q3: Could we use tags on the skills instead?
Related details
- Ashwin Verleker
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Ashwin Verleker (Gerrit)
Ashwin Verleker voted and added 2 comments![]( "Open in Gerrit")
Votes added by Ashwin Verleker
| Auto-Submit | +1 |
2 comments
'agents_internal_revision': '11c700b10e171091b4f0f3cf3bf95f13dee85c93',side quest: should we setup an autoroller instead? or is it too early for that?
Autoroller set up is in progress 😊. This is to allow the latest updates to come in while that gets done
nit: It's a bit unclear what this file does or who uses it when seen in isolation.
side comments:
- Q1: Is this format defined somewhere?
- Q2: json is probably not the righ format since we can't add comments (have you considerd hjson or csv with comments)
- Q3: Could we use tags on the skills instead?
This file lists the core skills that should be enabled for all users running the current agentic tooling.
Q1: go/jetski-agent-discovery#format
Q2: Unfortunately we do not define this 😞
Q3: It picks up skills from the local checkout, so the version is what you currently have in the repo that you are running in.
Related details
- Camillo Bruni
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Ashwin Verleker (Gerrit)
Ashwin Verleker voted Auto-Submit+1![]( "Open in Gerrit")
- Camillo Bruni
- Leszek Swirski
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Leszek Swirski (Gerrit)
Leszek Swirski added 1 comment![]( "Open in Gerrit")
- Ashwin Verleker
- Camillo Bruni
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Leszek Swirski (Gerrit)
Leszek Swirski added 1 comment![]( "Open in Gerrit")
I might be missing something here, aren't things in `.agents` already auto picked up by jetski? And this is in `agents` not `.agents` so it doesn't help with auto pickup.
Camillo Bruni (Gerrit)
Camillo Bruni added 1 comment![]( "Open in Gerrit")
Ashwin Verlekernit: It's a bit unclear what this file does or who uses it when seen in isolation.
side comments:
- Q1: Is this format defined somewhere?
- Q2: json is probably not the righ format since we can't add comments (have you considerd hjson or csv with comments)
- Q3: Could we use tags on the skills instead?
This file lists the core skills that should be enabled for all users running the current agentic tooling.
Q1: go/jetski-agent-discovery#format
Q2: Unfortunately we do not define this 😞
Q3: It picks up skills from the local checkout, so the version is what you currently have in the repo that you are running in.
Q1: but it's a file that is copied or linked? I don't see core_skills.json as somtehing that is picked up automatically?
Related details
- Ashwin Verleker
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Ashwin Verleker (Gerrit)
Ashwin Verleker added 2 comments![]( "Open in Gerrit")
I might be missing something here, aren't things in `.agents` already auto picked up by jetski? And this is in `agents` not `.agents` so it doesn't help with auto pickup.
Steps are in go/v8-ai-onboarding
Once you run the setup script, it configures `.agents/skills.json` to point to this file. That way when you add a new skill in `agents` and want to enable it by default, you simply add it to this file and all users get it without requiring the setup script to be run again or copying into `.agents`
Ashwin Verlekernit: It's a bit unclear what this file does or who uses it when seen in isolation.
side comments:
- Q1: Is this format defined somewhere?
- Q2: json is probably not the righ format since we can't add comments (have you considerd hjson or csv with comments)
- Q3: Could we use tags on the skills instead?
Camillo BruniThis file lists the core skills that should be enabled for all users running the current agentic tooling.
Q1: go/jetski-agent-discovery#format
Q2: Unfortunately we do not define this 😞
Q3: It picks up skills from the local checkout, so the version is what you currently have in the repo that you are running in.
Q1: but it's a file that is copied or linked? I don't see core_skills.json as somtehing that is picked up automatically?
It is picked up automatically after the setup script is run once (we configure the workspace skills json i.e //.agents/skills.json to point to this file).
Related details
- Camillo Bruni
- Leszek Swirski
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Camillo Bruni (Gerrit)
Camillo Bruni added 1 comment![]( "Open in Gerrit")
Ashwin Verlekernit: It's a bit unclear what this file does or who uses it when seen in isolation.
side comments:
- Q1: Is this format defined somewhere?
- Q2: json is probably not the righ format since we can't add comments (have you considerd hjson or csv with comments)
- Q3: Could we use tags on the skills instead?
Camillo BruniThis file lists the core skills that should be enabled for all users running the current agentic tooling.
Q1: go/jetski-agent-discovery#format
Q2: Unfortunately we do not define this 😞
Q3: It picks up skills from the local checkout, so the version is what you currently have in the repo that you are running in.
Ashwin VerlekerQ1: but it's a file that is copied or linked? I don't see core_skills.json as somtehing that is picked up automatically?
It is picked up automatically after the setup script is run once (we configure the workspace skills json i.e //.agents/skills.json to point to this file).
I'm still confused where this is added.
Currently we symlink each skill separately in the V8 repo [1] which is rather easy to discover and maintain locally.
I presume this would be added in `.ageents/skills/core/skills.json` and enable a group of skills?
If so, wouldn't it be more maintainable to just symblink each skill mentioned in core_skills.json separately (e.g. I don't immeditaely see the benefit of enable a group of skills this way)?
e.g. `.agents/skills/history_arg => agents/internal/skills/history-rag` and so on?
Related details
- Ashwin Verleker
- Leszek Swirski
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |