[maglev] Untag more phis based on input static types [v8/v8 : main]
0 views
Skip to first unread message
Darius Mercadier (Gerrit)
Dec 17, 2025, 8:23:06 AM12/17/25
to Leszek Swirski, V8 LUCI CQ, leszek...@chromium.org, v8-re...@googlegroups.com, verwaes...@chromium.org, victorgo...@chromium.org
Attention needed from Leszek Swirski
Darius Mercadier added 1 comment![]( "Open in Gerrit")
Patchset-level comments
File-level comment, Patchset 2 (Latest):
Darius Mercadier . resolved
Now we're changing behavior and allowing more inputs to be untagged :)
PTAL!
Related details
Attention is currently required from:
- Leszek Swirski
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
chromeperf@appspot.gserviceaccount.com (Gerrit)
Dec 17, 2025, 9:39:28 AM12/17/25
to Darius Mercadier, Leszek Swirski, V8 LUCI CQ, leszek...@chromium.org, v8-re...@googlegroups.com, verwaes...@chromium.org, victorgo...@chromium.org
Attention needed from Darius Mercadier and Leszek Swirski
Message from chrom...@appspot.gserviceaccount.com![]( "Open in Gerrit")
📍 Job mac-m1_mini_2020-perf/jetstream-main.crossbench complete.
See results at: https://pinpoint-dot-chromeperf.appspot.com/job/163b40bcb10000
Related details
Attention is currently required from:
- Darius Mercadier
- Leszek Swirski
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
chromeperf@appspot.gserviceaccount.com (Gerrit)
Dec 17, 2025, 9:44:15 AM12/17/25
to Darius Mercadier, Leszek Swirski, V8 LUCI CQ, leszek...@chromium.org, v8-re...@googlegroups.com, verwaes...@chromium.org, victorgo...@chromium.org
Attention needed from Darius Mercadier and Leszek Swirski
Message from chrom...@appspot.gserviceaccount.com![]( "Open in Gerrit")
📍 Job mac-m1_mini_2020-perf/jetstream-main.crossbench complete.
See results at: https://pinpoint-dot-chromeperf.appspot.com/job/15446db8b10000
Related details
Attention is currently required from:
- Darius Mercadier
- Leszek Swirski
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Darius Mercadier (Gerrit)
Dec 17, 2025, 9:44:41 AM12/17/25
to chrom...@appspot.gserviceaccount.com, Leszek Swirski, V8 LUCI CQ, leszek...@chromium.org, v8-re...@googlegroups.com, verwaes...@chromium.org, victorgo...@chromium.org
Attention needed from Leszek Swirski
Darius Mercadier added 1 comment![]( "Open in Gerrit")
Patchset-level comments
Darius Mercadier . resolved
Grr, this regresses crypto. My guess is that it's because we now bailout from untagging when there is a LoadTaggedField(Smi) input which flows into a phi that has the uses_requires_31_bits flag.
I'm not even sure why we need this machinery tbh.. I'll investigate more and I'll let you know once this can be reviewed.
Related details
Attention is currently required from:
- Leszek Swirski
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Darius Mercadier (Gerrit)
10:43 AM (11 hours ago) 10:43 AM
to chrom...@appspot.gserviceaccount.com, Leszek Swirski, V8 LUCI CQ, leszek...@chromium.org, v8-re...@googlegroups.com, verwaes...@chromium.org, victorgo...@chromium.org
Darius Mercadier abandoned this change![]( "Open in Gerrit")
Related details
Attention set is empty
Submit Requirements:
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages