[turbolev] Introduce max_turbolev_inlined_bytecode_size_cumulative [v8/v8 : main]
0 views
Skip to first unread message
Jakob Linke (Gerrit)
Sep 4, 2025, 6:20:54 AM (3 days ago) Sep 4
to Darius Mercadier, V8 LUCI CQ, leszek...@chromium.org, v8-flag...@chromium.org, v8-re...@googlegroups.com, verwaes...@chromium.org, victorgo...@chromium.org
Attention needed from Darius Mercadier
New activity on the change![]( "Open in Gerrit")
Related details
Attention is currently required from:
- Darius Mercadier
Submit Requirements:
Code-Owners
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Darius Mercadier (Gerrit)
Sep 4, 2025, 6:25:27 AM (3 days ago) Sep 4
to Jakob Linke, V8 LUCI CQ, leszek...@chromium.org, v8-flag...@chromium.org, v8-re...@googlegroups.com, verwaes...@chromium.org, victorgo...@chromium.org
Attention needed from Jakob Linke
Darius Mercadier voted Code-Review+1![]( "Open in Gerrit")
Attention is currently required from:
- Jakob Linke
Submit Requirements:
Code-Owners
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Jakob Linke (Gerrit)
Sep 4, 2025, 6:28:56 AM (3 days ago) Sep 4
to Darius Mercadier, V8 LUCI CQ, leszek...@chromium.org, v8-flag...@chromium.org, v8-re...@googlegroups.com, verwaes...@chromium.org, victorgo...@chromium.org
Jakob Linke voted Commit-Queue+2![]( "Open in Gerrit")
Submit Requirements:
Code-Owners
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
V8 LUCI CQ (Gerrit)
Sep 4, 2025, 6:45:16 AM (3 days ago) Sep 4
to Jakob Linke, Darius Mercadier, leszek...@chromium.org, v8-flag...@chromium.org, v8-re...@googlegroups.com, verwaes...@chromium.org, victorgo...@chromium.org
V8 LUCI CQ submitted the change![]( "Open in Gerrit")
Change information
Commit message:
[turbolev] Introduce max_turbolev_inlined_bytecode_size_cumulative
.. since Turbolev inlining behavior differs from Turbofan and a
common budget (currently) doesn't make sense.
Notably, Turbolev does loop peeling before inlining whereas Turbofan
inlines first. This means that whenever peeling occurs, calls inside
the loop body are duplicated by TL, and we need a higher budget than TF
to reach similar behavior.
This CL doubles the TF budget for Turbolev.
Change-Id: I967d084ac33abbda8ee1bf4b85209b28bd4db5ea
Reviewed-by: Darius Mercadier <dmerc...@chromium.org>
Commit-Queue: Jakob Linke <jgr...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#102239}
Files:
- M src/flags/flag-definitions.h
- M src/maglev/maglev-graph-builder.h
- M src/maglev/maglev-inlining.cc
Change size: S
Delta: 3 files changed, 8 insertions(+), 2 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Darius Mercadier
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
chromeperf@appspot.gserviceaccount.com (Gerrit)
Sep 4, 2025, 8:43:14 AM (3 days ago) Sep 4
to V8 LUCI CQ, Jakob Linke, Darius Mercadier, leszek...@chromium.org, v8-flag...@chromium.org, v8-re...@googlegroups.com, verwaes...@chromium.org, victorgo...@chromium.org
Message from chrom...@appspot.gserviceaccount.com![]( "Open in Gerrit")
📍 Job mac-m3-pro-perf/jetstream2 complete.
See results at: https://pinpoint-dot-chromeperf.appspot.com/job/10f87e64510000
Related details
Attention set is empty
Submit Requirements:
Code-Owners
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages