[test] Use non-persistent shell with the Android test runner [v8/v8 : main]
0 views
Skip to first unread message
Michael Achenbach (Gerrit)
Feb 3, 2026, 9:37:31 AM (19 hours ago) Feb 3
to Manos Koukoutos, Clemens Backes, v8-re...@googlegroups.com
Attention needed from Clemens Backes and Manos Koukoutos
Michael Achenbach added 1 comment![]( "Open in Gerrit")
Patchset-level comments
Related details
Attention is currently required from:
- Clemens Backes
- Manos Koukoutos
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Clemens Backes (Gerrit)
Feb 3, 2026, 9:41:18 AM (19 hours ago) Feb 3
to Michael Achenbach, Manos Koukoutos, v8-re...@googlegroups.com
Attention needed from Manos Koukoutos and Michael Achenbach
Clemens Backes voted Code-Review+1![]( "Open in Gerrit")
Attention is currently required from:
- Manos Koukoutos
- Michael Achenbach
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Michael Achenbach (Gerrit)
Feb 3, 2026, 9:41:53 AM (19 hours ago) Feb 3
to Clemens Backes, Manos Koukoutos, v8-re...@googlegroups.com
Attention needed from Manos Koukoutos
Michael Achenbach voted Commit-Queue+2![]( "Open in Gerrit")
| Commit-Queue | +2 |
Related details
Attention is currently required from:
- Manos Koukoutos
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Clemens Backes (Gerrit)
Feb 3, 2026, 9:42:08 AM (19 hours ago) Feb 3
to Michael Achenbach, V8 LUCI CQ, Manos Koukoutos, v8-re...@googlegroups.com
Attention needed from Manos Koukoutos
Clemens Backes voted and added 1 comment![]( "Open in Gerrit")
Votes added by Clemens Backes
| Code-Review | +1 |
1 comment
Patchset-level comments
File-level comment, Patchset 3:
Clemens Backes . resolved
Looks like a persistent shell would save some test execution time, but if it makes tests fail, then this is the right first fix. But we should try to figure out why it makes tests fail ("ADB shell crashed"?).
Related details
Attention is currently required from:
- Manos Koukoutos
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Michael Achenbach (Gerrit)
Feb 3, 2026, 9:42:19 AM (19 hours ago) Feb 3
to V8 LUCI CQ, Clemens Backes, Manos Koukoutos, v8-re...@googlegroups.com
Attention needed from Manos Koukoutos
Michael Achenbach added 1 comment![]( "Open in Gerrit")
Patchset-level comments
File-level comment, Patchset 4 (Latest):
Michael Achenbach . resolved
If the android bot blocks this for some random test-failure, reason, I'll remove it again from the description.
Related details
Attention is currently required from:
- Manos Koukoutos
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Michael Achenbach (Gerrit)
Feb 3, 2026, 9:57:36 AM (18 hours ago) Feb 3
to V8 LUCI CQ, Clemens Backes, Manos Koukoutos, v8-re...@googlegroups.com
Attention needed from Manos Koukoutos
Michael Achenbach voted Commit-Queue+2![]( "Open in Gerrit")
| Commit-Queue | +2 |
Related details
Attention is currently required from:
- Manos Koukoutos
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Michael Achenbach (Gerrit)
Feb 3, 2026, 10:01:04 AM (18 hours ago) Feb 3
to V8 LUCI CQ, Clemens Backes, Manos Koukoutos, v8-re...@googlegroups.com
Attention needed from Manos Koukoutos
Michael Achenbach added 1 comment![]( "Open in Gerrit")
Patchset-level comments
Michael Achenbach . resolved
If the android bot blocks this for some random test-failure, reason, I'll remove it again from the description.
Michael Achenbach
I'll leave this as follow up on the bug. I probably don't have the bandwidth for a deeper investigation. Seems to be sensitive to some device types. I.e. doesn't fail on our internal perf devices, which use the same code.
Related details
Attention is currently required from:
- Manos Koukoutos
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
V8 LUCI CQ (Gerrit)
Feb 3, 2026, 10:22:45 AM (18 hours ago) Feb 3
to Michael Achenbach, Clemens Backes, Manos Koukoutos, v8-re...@googlegroups.com
V8 LUCI CQ submitted the change![]( "Open in Gerrit")
Unreviewed changes
3 is the latest approved patch-set.
No files were changed between the latest approved patch-set and the submitted one.
Change information
Commit message:
[test] Use non-persistent shell with the Android test runner
The testing is broken since this argument flipped to True by default.
Bug: 481280180
Change-Id: Ic3b0b1f7a13a3ad403cb2c1e23ecda04feaa042d
Cq-Include-Trybots: luci.v8.try:v8_android_arm64_p7_rel
Reviewed-by: Clemens Backes <clem...@chromium.org>
Commit-Queue: Michael Achenbach <mache...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#105065}
Files:
- M tools/testrunner/local/android.py
Change size: XS
Delta: 1 file changed, 2 insertions(+), 1 deletion(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Clemens Backes
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages