Mark MemCopyAndSwitchEndianness src input as `const` [v8/v8 : main]

0 views
Skip to first unread message

Milad Farazmand (Gerrit)

unread,
Feb 23, 2026, 4:25:42 PM (17 hours ago) Feb 23
to Clemens Backes, V8 LUCI CQ, v8-re...@googlegroups.com
Attention needed from Clemens Backes

Milad Farazmand added 1 comment

Patchset-level comments
File-level comment, Patchset 2 (Latest):
Milad Farazmand . resolved

PTAL.

Open in Gerrit

Related details

Attention is currently required from:
  • Clemens Backes
Submit Requirements:
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: v8/v8
Gerrit-Branch: main
Gerrit-Change-Id: I0c0f065b822e0f95ffd06207d280fc8b7bab4403
Gerrit-Change-Number: 7601332
Gerrit-PatchSet: 2
Gerrit-Owner: Milad Farazmand <mfar...@ibm.com>
Gerrit-Reviewer: Clemens Backes <clem...@chromium.org>
Gerrit-Reviewer: Milad Farazmand <mfar...@ibm.com>
Gerrit-Attention: Clemens Backes <clem...@chromium.org>
Gerrit-Comment-Date: Mon, 23 Feb 2026 21:25:39 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
unsatisfied_requirement
open
diffy

Clemens Backes (Gerrit)

unread,
4:37 AM (4 hours ago) 4:37 AM
to Milad Farazmand, V8 LUCI CQ, v8-re...@googlegroups.com
Attention needed from Milad Farazmand

Clemens Backes voted Code-Review+1

Code-Review+1
Open in Gerrit

Related details

Attention is currently required from:
  • Milad Farazmand
Submit Requirements:
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: v8/v8
Gerrit-Branch: main
Gerrit-Change-Id: I0c0f065b822e0f95ffd06207d280fc8b7bab4403
Gerrit-Change-Number: 7601332
Gerrit-PatchSet: 2
Gerrit-Owner: Milad Farazmand <mfar...@ibm.com>
Gerrit-Reviewer: Clemens Backes <clem...@chromium.org>
Gerrit-Reviewer: Milad Farazmand <mfar...@ibm.com>
Gerrit-Attention: Milad Farazmand <mfar...@ibm.com>
Gerrit-Comment-Date: Tue, 24 Feb 2026 09:37:00 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

Milad Farazmand (Gerrit)

unread,
7:36 AM (1 hour ago) 7:36 AM
to Clemens Backes, V8 LUCI CQ, v8-re...@googlegroups.com

Milad Farazmand voted Commit-Queue+2

Commit-Queue+2
Open in Gerrit

Related details

Attention set is empty
Submit Requirements:
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: v8/v8
Gerrit-Branch: main
Gerrit-Change-Id: I0c0f065b822e0f95ffd06207d280fc8b7bab4403
Gerrit-Change-Number: 7601332
Gerrit-PatchSet: 2
Gerrit-Owner: Milad Farazmand <mfar...@ibm.com>
Gerrit-Reviewer: Clemens Backes <clem...@chromium.org>
Gerrit-Reviewer: Milad Farazmand <mfar...@ibm.com>
Gerrit-Comment-Date: Tue, 24 Feb 2026 12:36:07 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

V8 LUCI CQ (Gerrit)

unread,
8:09 AM (1 hour ago) 8:09 AM
to Milad Farazmand, Clemens Backes, v8-re...@googlegroups.com

V8 LUCI CQ submitted the change

Change information

Commit message:
Mark MemCopyAndSwitchEndianness src input as `const`

Needed after this CL: http://crrev.com/c/7600437
Currently getting the following error:
```
candidate function not viable: no known conversion from 'const unsigned char *' to 'void *'
```
Change-Id: I0c0f065b822e0f95ffd06207d280fc8b7bab4403
Reviewed-by: Clemens Backes <clem...@chromium.org>
Commit-Queue: Milad Farazmand <mfar...@ibm.com>
Cr-Commit-Position: refs/heads/main@{#105413}
Files:
  • M src/base/memcopy.h
  • M src/utils/memcopy.h
Change size: S
Delta: 2 files changed, 13 insertions(+), 13 deletions(-)
Branch: refs/heads/main
Submit Requirements:
  • requirement satisfiedCode-Review: +1 by Clemens Backes
Open in Gerrit
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: merged
Gerrit-Project: v8/v8
Gerrit-Branch: main
Gerrit-Change-Id: I0c0f065b822e0f95ffd06207d280fc8b7bab4403
Gerrit-Change-Number: 7601332
Gerrit-PatchSet: 3
Gerrit-Owner: Milad Farazmand <mfar...@ibm.com>
Gerrit-Reviewer: Clemens Backes <clem...@chromium.org>
Gerrit-Reviewer: Milad Farazmand <mfar...@ibm.com>
open
diffy
satisfied_requirement
Reply all
Reply to author
Forward
0 new messages