[torque] Minimize generated output after latest tq2tsa additions [v8/v8 : main]

0 views
Skip to first unread message

Nico Hartmann (Gerrit)

unread,
5:31 AM (6 hours ago) 5:31 AM
to Darius Mercadier, V8 LUCI CQ, v8-re...@googlegroups.com, victorgo...@chromium.org
Attention needed from Darius Mercadier

Nico Hartmann added 1 comment

Patchset-level comments
File-level comment, Patchset 2 (Latest):
Nico Hartmann . resolved

PTAL, thanks

Open in Gerrit

Related details

Attention is currently required from:
  • Darius Mercadier
Submit Requirements:
  • requirement satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: v8/v8
Gerrit-Branch: main
Gerrit-Change-Id: I5abfcb7f09ec9e53f81b7c880e45db2774730e5a
Gerrit-Change-Number: 7462503
Gerrit-PatchSet: 2
Gerrit-Owner: Nico Hartmann <nicoha...@chromium.org>
Gerrit-Reviewer: Darius Mercadier <dmerc...@chromium.org>
Gerrit-Reviewer: Nico Hartmann <nicoha...@chromium.org>
Gerrit-Attention: Darius Mercadier <dmerc...@chromium.org>
Gerrit-Comment-Date: Tue, 13 Jan 2026 10:31:22 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
satisfied_requirement
unsatisfied_requirement
open
diffy

Darius Mercadier (Gerrit)

unread,
5:35 AM (6 hours ago) 5:35 AM
to Nico Hartmann, V8 LUCI CQ, v8-re...@googlegroups.com, victorgo...@chromium.org
Attention needed from Nico Hartmann

Darius Mercadier voted and added 1 comment

Votes added by Darius Mercadier

Code-Review+1

1 comment

Patchset-level comments
Darius Mercadier . resolved

lgtm

Open in Gerrit

Related details

Attention is currently required from:
  • Nico Hartmann
Submit Requirements:
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: v8/v8
Gerrit-Branch: main
Gerrit-Change-Id: I5abfcb7f09ec9e53f81b7c880e45db2774730e5a
Gerrit-Change-Number: 7462503
Gerrit-PatchSet: 2
Gerrit-Owner: Nico Hartmann <nicoha...@chromium.org>
Gerrit-Reviewer: Darius Mercadier <dmerc...@chromium.org>
Gerrit-Reviewer: Nico Hartmann <nicoha...@chromium.org>
Gerrit-Attention: Nico Hartmann <nicoha...@chromium.org>
Gerrit-Comment-Date: Tue, 13 Jan 2026 10:35:12 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

Nico Hartmann (Gerrit)

unread,
5:35 AM (6 hours ago) 5:35 AM
to Darius Mercadier, V8 LUCI CQ, v8-re...@googlegroups.com, victorgo...@chromium.org

Nico Hartmann voted Commit-Queue+2

Commit-Queue+2
Open in Gerrit

Related details

Attention set is empty
Submit Requirements:
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: v8/v8
Gerrit-Branch: main
Gerrit-Change-Id: I5abfcb7f09ec9e53f81b7c880e45db2774730e5a
Gerrit-Change-Number: 7462503
Gerrit-PatchSet: 2
Gerrit-Owner: Nico Hartmann <nicoha...@chromium.org>
Gerrit-Reviewer: Darius Mercadier <dmerc...@chromium.org>
Gerrit-Reviewer: Nico Hartmann <nicoha...@chromium.org>
Gerrit-Comment-Date: Tue, 13 Jan 2026 10:35:48 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

V8 LUCI CQ (Gerrit)

unread,
6:08 AM (5 hours ago) 6:08 AM
to Nico Hartmann, Darius Mercadier, v8-re...@googlegroups.com, victorgo...@chromium.org

V8 LUCI CQ submitted the change

Change information

Commit message:
[torque] Minimize generated output after latest tq2tsa additions
Bug: 348031042
Change-Id: I5abfcb7f09ec9e53f81b7c880e45db2774730e5a
Commit-Queue: Nico Hartmann <nicoha...@chromium.org>
Reviewed-by: Darius Mercadier <dmerc...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#104663}
Files:
  • M BUILD.bazel
  • M BUILD.gn
  • M src/builtins/builtins-string.tq
  • D src/torque/ast-desugaring.cc
  • D src/torque/ast-desugaring.h
  • M src/torque/ast.h
  • M src/torque/class-debug-reader-generator.cc
  • M src/torque/declaration-visitor.cc
  • M src/torque/global-context.h
  • M src/torque/implementation-visitor.cc
  • M src/torque/torque-compiler.cc
  • M src/torque/torque-compiler.h
  • M src/torque/torque-parser.cc
  • M src/torque/torque.cc
  • M src/torque/tsa-generator.cc
Change size: L
Delta: 15 files changed, 96 insertions(+), 161 deletions(-)
Branch: refs/heads/main
Submit Requirements:
  • requirement satisfiedCode-Review: +1 by Darius Mercadier
Open in Gerrit
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: merged
Gerrit-Project: v8/v8
Gerrit-Branch: main
Gerrit-Change-Id: I5abfcb7f09ec9e53f81b7c880e45db2774730e5a
Gerrit-Change-Number: 7462503
Gerrit-PatchSet: 3
Gerrit-Owner: Nico Hartmann <nicoha...@chromium.org>
Gerrit-Reviewer: Darius Mercadier <dmerc...@chromium.org>
Gerrit-Reviewer: Nico Hartmann <nicoha...@chromium.org>
open
diffy
satisfied_requirement
Reply all
Reply to author
Forward
0 new messages