[api] Fix v8::FunctionTemplate::HasInstance(..) for detached global [v8/v8 : main]

0 views
Skip to first unread message

Igor Sheludko (Gerrit)

unread,
Mar 10, 2026, 8:58:07 AMMar 10
to Patrick Thier, V8 LUCI CQ, v8-re...@googlegroups.com
Attention needed from Patrick Thier

Igor Sheludko voted and added 1 comment

Votes added by Igor Sheludko

Auto-Submit+1
Commit-Queue+1

1 comment

Patchset-level comments
File-level comment, Patchset 4 (Latest):
Igor Sheludko . resolved

PTAL again

Open in Gerrit

Related details

Attention is currently required from:
  • Patrick Thier
Submit Requirements:
  • requirement satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: v8/v8
Gerrit-Branch: main
Gerrit-Change-Id: Ia9c2fa8cf49e0f75cc4b62eefde6dc17ed234b76
Gerrit-Change-Number: 7651814
Gerrit-PatchSet: 4
Gerrit-Owner: Igor Sheludko <ish...@chromium.org>
Gerrit-Reviewer: Igor Sheludko <ish...@chromium.org>
Gerrit-Reviewer: Patrick Thier <pth...@chromium.org>
Gerrit-Attention: Patrick Thier <pth...@chromium.org>
Gerrit-Comment-Date: Tue, 10 Mar 2026 12:58:02 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

Patrick Thier (Gerrit)

unread,
Mar 10, 2026, 10:18:24 AMMar 10
to Igor Sheludko, V8 LUCI CQ, v8-re...@googlegroups.com
Attention needed from Igor Sheludko

Patrick Thier voted

Code-Review+1
Commit-Queue+2
Open in Gerrit

Related details

Attention is currently required from:
  • Igor Sheludko
Submit Requirements:
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: v8/v8
Gerrit-Branch: main
Gerrit-Change-Id: Ia9c2fa8cf49e0f75cc4b62eefde6dc17ed234b76
Gerrit-Change-Number: 7651814
Gerrit-PatchSet: 4
Gerrit-Owner: Igor Sheludko <ish...@chromium.org>
Gerrit-Reviewer: Igor Sheludko <ish...@chromium.org>
Gerrit-Reviewer: Patrick Thier <pth...@chromium.org>
Gerrit-Attention: Igor Sheludko <ish...@chromium.org>
Gerrit-Comment-Date: Tue, 10 Mar 2026 14:18:20 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

V8 LUCI CQ (Gerrit)

unread,
Mar 10, 2026, 10:20:14 AMMar 10
to Igor Sheludko, Patrick Thier, v8-re...@googlegroups.com

V8 LUCI CQ submitted the change

Change information

Commit message:
[api] Fix v8::FunctionTemplate::HasInstance(..) for detached global

Drive-by: fix JSGlobalProxy::IsDetached() to work correctly for
remote global proxies (checking existence of creation context is not
correct here since remote objects do not have one).
Fixed: 488790226
Change-Id: Ia9c2fa8cf49e0f75cc4b62eefde6dc17ed234b76
Auto-Submit: Igor Sheludko <ish...@chromium.org>
Reviewed-by: Patrick Thier <pth...@chromium.org>
Commit-Queue: Patrick Thier <pth...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#105707}
Files:
  • M src/api/api.cc
  • M src/objects/js-objects-inl.h
  • M src/objects/js-objects.cc
  • M src/objects/js-objects.h
Change size: S
Delta: 4 files changed, 16 insertions(+), 10 deletions(-)
Branch: refs/heads/main
Submit Requirements:
  • requirement satisfiedCode-Review: +1 by Patrick Thier
Open in Gerrit
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: merged
Gerrit-Project: v8/v8
Gerrit-Branch: main
Gerrit-Change-Id: Ia9c2fa8cf49e0f75cc4b62eefde6dc17ed234b76
Gerrit-Change-Number: 7651814
Gerrit-PatchSet: 5
Gerrit-Owner: Igor Sheludko <ish...@chromium.org>
Gerrit-Reviewer: Igor Sheludko <ish...@chromium.org>
Gerrit-Reviewer: Patrick Thier <pth...@chromium.org>
open
diffy
satisfied_requirement
Reply all
Reply to author
Forward
0 new messages