[system-analyzer] Virtualize script panel rendering [v8/v8 : main]
0 views
Skip to first unread message
Leszek Swirski (Gerrit)
9:28 AM (14 hours ago) 9:28 AM
to Patrick Thier, Camillo Bruni, V8 LUCI CQ, v8-re...@googlegroups.com
Attention needed from Patrick Thier
Leszek Swirski added 1 comment![]( "Open in Gerrit")
Patchset-level comments
File-level comment, Patchset 1:
Leszek Swirski . resolved
Patrick, I have some high-quality slop for you to review
Related details
Attention is currently required from:
- Patrick Thier
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Patrick Thier (Gerrit)
9:50 AM (14 hours ago) 9:50 AM
to Leszek Swirski, Camillo Bruni, V8 LUCI CQ, v8-re...@googlegroups.com
Attention needed from Leszek Swirski
Patrick Thier voted and added 1 comment![]( "Open in Gerrit")
Votes added by Patrick Thier
| Code-Review | +1 |
1 comment
Patchset-level comments
File-level comment, Patchset 2 (Latest):
Patrick Thier . resolved
LGTM (which now stands for "Looks Great To Machines"). Yes, Gemini thought this is funny.
Related details
Attention is currently required from:
- Leszek Swirski
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Leszek Swirski (Gerrit)
9:50 AM (14 hours ago) 9:50 AM
to Patrick Thier, Camillo Bruni, V8 LUCI CQ, v8-re...@googlegroups.com
Leszek Swirski voted Commit-Queue+2![]( "Open in Gerrit")
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Leszek Swirski (Gerrit)
9:51 AM (14 hours ago) 9:51 AM
to Patrick Thier, Camillo Bruni, V8 LUCI CQ, v8-re...@googlegroups.com
Leszek Swirski added 1 comment![]( "Open in Gerrit")
Patchset-level comments
Patrick Thier . resolved
LGTM (which now stands for "Looks Great To Machines"). Yes, Gemini thought this is funny.
Leszek Swirski
I also thought it was funny.
Related details
Attention set is empty
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
V8 LUCI CQ (Gerrit)
10:01 AM (14 hours ago) 10:01 AM
to Leszek Swirski, Patrick Thier, Camillo Bruni, v8-re...@googlegroups.com
V8 LUCI CQ submitted the change![]( "Open in Gerrit")
Change information
Commit message:
[system-analyzer] Virtualize script panel rendering
Implement virtualized rendering in the script panel to improve
performance with large source files. This includes layout calculations
based on font metrics, scroll-based re-rendering, and updating the line
builder to support rendering specific script fragments. Lines are
manually wrapped, and these wrapped chunks are also tracked as pseudo
lines in the virtualization.
Change-Id: I788845b8411e29e0646d2d24692fb4feaa834f04
Commit-Queue: Leszek Swirski <les...@chromium.org>
Reviewed-by: Patrick Thier <pth...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#104603}
Files:
- M tools/system-analyzer/view/script-panel-template.html
- M tools/system-analyzer/view/script-panel.mjs
Change size: L
Delta: 2 files changed, 483 insertions(+), 94 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Patrick Thier
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages