[compiler][arm64] Optimize ExtractLane 0 [v8/v8 : main]

0 views
Skip to first unread message

Nico Hartmann (Gerrit)

unread,
Feb 3, 2026, 8:23:04 AM (20 hours ago) Feb 3
to Sam Parker-Haynes, V8 LUCI CQ, dmercadi...@chromium.org, v8-re...@googlegroups.com
Attention needed from Sam Parker-Haynes

Nico Hartmann voted and added 1 comment

Votes added by Nico Hartmann

Code-Review+1

1 comment

Patchset-level comments
File-level comment, Patchset 1 (Latest):
Nico Hartmann . resolved

LGTM

Open in Gerrit

Related details

Attention is currently required from:
  • Sam Parker-Haynes
Submit Requirements:
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: v8/v8
Gerrit-Branch: main
Gerrit-Change-Id: I0a14d388ab18958cfad8ec0af6fdd19b095c0d13
Gerrit-Change-Number: 7535210
Gerrit-PatchSet: 1
Gerrit-Owner: Sam Parker-Haynes <sam.p...@arm.com>
Gerrit-Reviewer: Nico Hartmann <nicoha...@chromium.org>
Gerrit-Reviewer: Sam Parker-Haynes <sam.p...@arm.com>
Gerrit-Attention: Sam Parker-Haynes <sam.p...@arm.com>
Gerrit-Comment-Date: Tue, 03 Feb 2026 13:23:00 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

Sam Parker-Haynes (Gerrit)

unread,
Feb 3, 2026, 8:25:02 AM (20 hours ago) Feb 3
to Nico Hartmann, V8 LUCI CQ, dmercadi...@chromium.org, v8-re...@googlegroups.com

Sam Parker-Haynes voted Commit-Queue+2

Commit-Queue+2
Open in Gerrit

Related details

Attention set is empty
Submit Requirements:
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: v8/v8
Gerrit-Branch: main
Gerrit-Change-Id: I0a14d388ab18958cfad8ec0af6fdd19b095c0d13
Gerrit-Change-Number: 7535210
Gerrit-PatchSet: 1
Gerrit-Owner: Sam Parker-Haynes <sam.p...@arm.com>
Gerrit-Reviewer: Nico Hartmann <nicoha...@chromium.org>
Gerrit-Reviewer: Sam Parker-Haynes <sam.p...@arm.com>
Gerrit-Comment-Date: Tue, 03 Feb 2026 13:24:57 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

V8 LUCI CQ (Gerrit)

unread,
Feb 3, 2026, 8:57:34 AM (19 hours ago) Feb 3
to Sam Parker-Haynes, Nico Hartmann, dmercadi...@chromium.org, v8-re...@googlegroups.com

V8 LUCI CQ submitted the change

Change information

Commit message:
[compiler][arm64] Optimize ExtractLane 0

The scalar S and D registers alias their SIMD counterparts, so we
don't need to perform the extract.
Change-Id: I0a14d388ab18958cfad8ec0af6fdd19b095c0d13
Commit-Queue: Sam Parker-Haynes <sam.p...@arm.com>
Reviewed-by: Nico Hartmann <nicoha...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#105059}
Files:
  • M src/compiler/backend/arm64/instruction-selector-arm64.cc
  • M test/unittests/compiler/arm64/turboshaft-instruction-selector-arm64-unittest.cc
  • M test/unittests/compiler/backend/turboshaft-instruction-selector-unittest.h
Change size: M
Delta: 3 files changed, 56 insertions(+), 2 deletions(-)
Branch: refs/heads/main
Submit Requirements:
  • requirement satisfiedCode-Review: +1 by Nico Hartmann
Open in Gerrit
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: merged
Gerrit-Project: v8/v8
Gerrit-Branch: main
Gerrit-Change-Id: I0a14d388ab18958cfad8ec0af6fdd19b095c0d13
Gerrit-Change-Number: 7535210
Gerrit-PatchSet: 2
Gerrit-Owner: Sam Parker-Haynes <sam.p...@arm.com>
Gerrit-Reviewer: Nico Hartmann <nicoha...@chromium.org>
Gerrit-Reviewer: Sam Parker-Haynes <sam.p...@arm.com>
open
diffy
satisfied_requirement
Reply all
Reply to author
Forward
0 new messages