[heap] Remove memory_reducer_respects_frozen_state [v8/v8 : main]

3 views
Skip to first unread message

Etienne Pierre-Doray (Gerrit)

unread,
Dec 9, 2025, 9:21:50 AM12/9/25
to Thiabaud Engelbrecht, V8 LUCI CQ, Hannes Payer, mlippau...@chromium.org, v8-flag...@chromium.org, v8-re...@googlegroups.com
Attention needed from Thiabaud Engelbrecht

New activity on the change

Open in Gerrit

Related details

Attention is currently required from:
  • Thiabaud Engelbrecht
Submit Requirements:
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: v8/v8
Gerrit-Branch: main
Gerrit-Change-Id: I242ffcf0440b3c14bc95ce96b3c6a53a3d3449d3
Gerrit-Change-Number: 7224919
Gerrit-PatchSet: 4
Gerrit-Owner: Etienne Pierre-Doray <etie...@chromium.org>
Gerrit-Reviewer: Etienne Pierre-Doray <etie...@chromium.org>
Gerrit-Reviewer: Thiabaud Engelbrecht <thia...@google.com>
Gerrit-CC: Hannes Payer <hpa...@chromium.org>
Gerrit-Attention: Thiabaud Engelbrecht <thia...@google.com>
Gerrit-Comment-Date: Tue, 09 Dec 2025 14:21:46 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
unsatisfied_requirement
open
diffy

Thiabaud Engelbrecht (Gerrit)

unread,
Dec 9, 2025, 1:32:31 PM12/9/25
to Etienne Pierre-Doray, V8 LUCI CQ, Hannes Payer, mlippau...@chromium.org, v8-flag...@chromium.org, v8-re...@googlegroups.com
Attention needed from Etienne Pierre-Doray

Thiabaud Engelbrecht added 1 comment

Patchset-level comments
File-level comment, Patchset 4 (Latest):
Thiabaud Engelbrecht . resolved

Let's land https://chromium-review.googlesource.com/c/chromium/src/+/7242985 first, which removes the callsite in Chrome. Then we can just delete the API entirely.

Open in Gerrit

Related details

Attention is currently required from:
  • Etienne Pierre-Doray
Submit Requirements:
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: v8/v8
Gerrit-Branch: main
Gerrit-Change-Id: I242ffcf0440b3c14bc95ce96b3c6a53a3d3449d3
Gerrit-Change-Number: 7224919
Gerrit-PatchSet: 4
Gerrit-Owner: Etienne Pierre-Doray <etie...@chromium.org>
Gerrit-Reviewer: Etienne Pierre-Doray <etie...@chromium.org>
Gerrit-Reviewer: Thiabaud Engelbrecht <thia...@google.com>
Gerrit-CC: Hannes Payer <hpa...@chromium.org>
Gerrit-Attention: Etienne Pierre-Doray <etie...@chromium.org>
Gerrit-Comment-Date: Tue, 09 Dec 2025 18:32:23 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
unsatisfied_requirement
open
diffy

Etienne Pierre-Doray (Gerrit)

unread,
Dec 19, 2025, 2:31:34 PM12/19/25
to Michael Lippautz, Thiabaud Engelbrecht, V8 LUCI CQ, Hannes Payer, mlippau...@chromium.org, v8-flag...@chromium.org, v8-re...@googlegroups.com
Attention needed from Michael Lippautz and Thiabaud Engelbrecht

Etienne Pierre-Doray added 2 comments

Patchset-level comments
Thiabaud Engelbrecht . resolved

Let's land https://chromium-review.googlesource.com/c/chromium/src/+/7242985 first, which removes the callsite in Chrome. Then we can just delete the API entirely.

Etienne Pierre-Doray

https://chromium-review.googlesource.com/c/chromium/src/+/7242985 landing
But I'll remove the API in a follow-up (possibly going through deprecation process)

Etienne Pierre-Doray . resolved

PTAL

Open in Gerrit

Related details

Attention is currently required from:
  • Michael Lippautz
  • Thiabaud Engelbrecht
Submit Requirements:
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: v8/v8
Gerrit-Branch: main
Gerrit-Change-Id: I242ffcf0440b3c14bc95ce96b3c6a53a3d3449d3
Gerrit-Change-Number: 7224919
Gerrit-PatchSet: 4
Gerrit-Owner: Etienne Pierre-Doray <etie...@chromium.org>
Gerrit-Reviewer: Etienne Pierre-Doray <etie...@chromium.org>
Gerrit-Reviewer: Michael Lippautz <mlip...@chromium.org>
Gerrit-Reviewer: Thiabaud Engelbrecht <thia...@google.com>
Gerrit-CC: Hannes Payer <hpa...@chromium.org>
Gerrit-Attention: Thiabaud Engelbrecht <thia...@google.com>
Gerrit-Attention: Michael Lippautz <mlip...@chromium.org>
Gerrit-Comment-Date: Fri, 19 Dec 2025 19:31:31 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Thiabaud Engelbrecht <thia...@google.com>
unsatisfied_requirement
open
diffy

Michael Lippautz (Gerrit)

unread,
Jan 7, 2026, 5:52:54 AMJan 7
to Etienne Pierre-Doray, Thiabaud Engelbrecht, V8 LUCI CQ, Hannes Payer, mlippau...@chromium.org, v8-flag...@chromium.org, v8-re...@googlegroups.com
Attention needed from Etienne Pierre-Doray and Thiabaud Engelbrecht

Michael Lippautz voted Code-Review+1

Code-Review+1
Open in Gerrit

Related details

Attention is currently required from:
  • Etienne Pierre-Doray
  • Thiabaud Engelbrecht
Submit Requirements:
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: v8/v8
Gerrit-Branch: main
Gerrit-Change-Id: I242ffcf0440b3c14bc95ce96b3c6a53a3d3449d3
Gerrit-Change-Number: 7224919
Gerrit-PatchSet: 4
Gerrit-Owner: Etienne Pierre-Doray <etie...@chromium.org>
Gerrit-Reviewer: Etienne Pierre-Doray <etie...@chromium.org>
Gerrit-Reviewer: Michael Lippautz <mlip...@chromium.org>
Gerrit-Reviewer: Thiabaud Engelbrecht <thia...@google.com>
Gerrit-CC: Hannes Payer <hpa...@chromium.org>
Gerrit-Attention: Thiabaud Engelbrecht <thia...@google.com>
Gerrit-Attention: Etienne Pierre-Doray <etie...@chromium.org>
Gerrit-Comment-Date: Wed, 07 Jan 2026 10:52:49 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

Etienne Pierre-Doray (Gerrit)

unread,
Jan 7, 2026, 7:06:37 AMJan 7
to Michael Lippautz, Thiabaud Engelbrecht, V8 LUCI CQ, Hannes Payer, mlippau...@chromium.org, v8-flag...@chromium.org, v8-re...@googlegroups.com
Attention needed from Thiabaud Engelbrecht

Etienne Pierre-Doray voted Commit-Queue+2

Commit-Queue+2
Open in Gerrit

Related details

Attention is currently required from:
  • Thiabaud Engelbrecht
Submit Requirements:
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: v8/v8
Gerrit-Branch: main
Gerrit-Change-Id: I242ffcf0440b3c14bc95ce96b3c6a53a3d3449d3
Gerrit-Change-Number: 7224919
Gerrit-PatchSet: 4
Gerrit-Owner: Etienne Pierre-Doray <etie...@chromium.org>
Gerrit-Reviewer: Etienne Pierre-Doray <etie...@chromium.org>
Gerrit-Reviewer: Michael Lippautz <mlip...@chromium.org>
Gerrit-Reviewer: Thiabaud Engelbrecht <thia...@google.com>
Gerrit-CC: Hannes Payer <hpa...@chromium.org>
Gerrit-Attention: Thiabaud Engelbrecht <thia...@google.com>
Gerrit-Comment-Date: Wed, 07 Jan 2026 12:06:34 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

V8 LUCI CQ (Gerrit)

unread,
Jan 7, 2026, 7:53:21 AMJan 7
to Etienne Pierre-Doray, Michael Lippautz, Thiabaud Engelbrecht, Hannes Payer, mlippau...@chromium.org, v8-flag...@chromium.org, v8-re...@googlegroups.com

V8 LUCI CQ submitted the change

Change information

Commit message:
[heap] Remove memory_reducer_respects_frozen_state

The feature did not ship and not plan to experiment.
Bug: 379663698
Change-Id: I242ffcf0440b3c14bc95ce96b3c6a53a3d3449d3
Reviewed-by: Michael Lippautz <mlip...@chromium.org>
Commit-Queue: Etienne Pierre-Doray <etie...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#104515}
Files:
  • M src/execution/isolate.h
  • M src/flags/flag-definitions.h
  • M src/heap/memory-reducer.cc
  • M src/heap/memory-reducer.h
  • M test/unittests/heap/memory-reducer-unittest.cc
Change size: M
Delta: 5 files changed, 4 insertions(+), 55 deletions(-)
Branch: refs/heads/main
Submit Requirements:
  • requirement satisfiedCode-Review: +1 by Michael Lippautz
Open in Gerrit
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: merged
Gerrit-Project: v8/v8
Gerrit-Branch: main
Gerrit-Change-Id: I242ffcf0440b3c14bc95ce96b3c6a53a3d3449d3
Gerrit-Change-Number: 7224919
Gerrit-PatchSet: 5
Gerrit-Owner: Etienne Pierre-Doray <etie...@chromium.org>
Gerrit-Reviewer: Etienne Pierre-Doray <etie...@chromium.org>
Gerrit-Reviewer: Michael Lippautz <mlip...@chromium.org>
Gerrit-Reviewer: Thiabaud Engelbrecht <thia...@google.com>
Gerrit-CC: Hannes Payer <hpa...@chromium.org>
open
diffy
satisfied_requirement
Reply all
Reply to author
Forward
0 new messages