[heap] Remove memory_reducer_respects_frozen_state [v8/v8 : main]
3 views
Skip to first unread message
Etienne Pierre-Doray (Gerrit)
Dec 9, 2025, 9:21:50 AM12/9/25
to Thiabaud Engelbrecht, V8 LUCI CQ, Hannes Payer, mlippau...@chromium.org, v8-flag...@chromium.org, v8-re...@googlegroups.com
Attention needed from Thiabaud Engelbrecht
New activity on the change![]( "Open in Gerrit")
Related details
Attention is currently required from:
- Thiabaud Engelbrecht
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Thiabaud Engelbrecht (Gerrit)
Dec 9, 2025, 1:32:31 PM12/9/25
to Etienne Pierre-Doray, V8 LUCI CQ, Hannes Payer, mlippau...@chromium.org, v8-flag...@chromium.org, v8-re...@googlegroups.com
Attention needed from Etienne Pierre-Doray
Thiabaud Engelbrecht added 1 comment![]( "Open in Gerrit")
Patchset-level comments
File-level comment, Patchset 4 (Latest):
Thiabaud Engelbrecht . resolved
Let's land https://chromium-review.googlesource.com/c/chromium/src/+/7242985 first, which removes the callsite in Chrome. Then we can just delete the API entirely.
Related details
Attention is currently required from:
- Etienne Pierre-Doray
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Etienne Pierre-Doray (Gerrit)
Dec 19, 2025, 2:31:34 PM12/19/25
to Michael Lippautz, Thiabaud Engelbrecht, V8 LUCI CQ, Hannes Payer, mlippau...@chromium.org, v8-flag...@chromium.org, v8-re...@googlegroups.com
Attention needed from Michael Lippautz and Thiabaud Engelbrecht
Etienne Pierre-Doray added 2 comments![]( "Open in Gerrit")
Patchset-level comments
Thiabaud Engelbrecht . resolved
Let's land https://chromium-review.googlesource.com/c/chromium/src/+/7242985 first, which removes the callsite in Chrome. Then we can just delete the API entirely.
Etienne Pierre-Doray
https://chromium-review.googlesource.com/c/chromium/src/+/7242985 landing
But I'll remove the API in a follow-up (possibly going through deprecation process)
Attention is currently required from:
- Michael Lippautz
- Thiabaud Engelbrecht
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Michael Lippautz (Gerrit)
Jan 7, 2026, 5:52:54 AMJan 7
to Etienne Pierre-Doray, Thiabaud Engelbrecht, V8 LUCI CQ, Hannes Payer, mlippau...@chromium.org, v8-flag...@chromium.org, v8-re...@googlegroups.com
Attention needed from Etienne Pierre-Doray and Thiabaud Engelbrecht
Michael Lippautz voted Code-Review+1![]( "Open in Gerrit")
Attention is currently required from:
- Etienne Pierre-Doray
- Thiabaud Engelbrecht
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Etienne Pierre-Doray (Gerrit)
Jan 7, 2026, 7:06:37 AMJan 7
to Michael Lippautz, Thiabaud Engelbrecht, V8 LUCI CQ, Hannes Payer, mlippau...@chromium.org, v8-flag...@chromium.org, v8-re...@googlegroups.com
Attention needed from Thiabaud Engelbrecht
Etienne Pierre-Doray voted Commit-Queue+2![]( "Open in Gerrit")
Attention is currently required from:
- Thiabaud Engelbrecht
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
V8 LUCI CQ (Gerrit)
Jan 7, 2026, 7:53:21 AMJan 7
to Etienne Pierre-Doray, Michael Lippautz, Thiabaud Engelbrecht, Hannes Payer, mlippau...@chromium.org, v8-flag...@chromium.org, v8-re...@googlegroups.com
V8 LUCI CQ submitted the change![]( "Open in Gerrit")
Change information
Commit message:
[heap] Remove memory_reducer_respects_frozen_state
The feature did not ship and not plan to experiment.
Bug: 379663698
Change-Id: I242ffcf0440b3c14bc95ce96b3c6a53a3d3449d3
Reviewed-by: Michael Lippautz <mlip...@chromium.org>
Commit-Queue: Etienne Pierre-Doray <etie...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#104515}
Files:
- M src/execution/isolate.h
- M src/flags/flag-definitions.h
- M src/heap/memory-reducer.cc
- M src/heap/memory-reducer.h
- M test/unittests/heap/memory-reducer-unittest.cc
Change size: M
Delta: 5 files changed, 4 insertions(+), 55 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Michael Lippautz
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages