[profiler] Add CpuProfileSource to distinguish concurrent profile streams [v8/v8 : main]

[Issack John (Gerrit)]

Attention needed from Issack John, Michael Lippautz and Yang Guo

Message from Issack John

Set Ready For Review

Open in Gerrit

Related details

Attention is currently required from:

• Issack John
• Michael Lippautz
• Yang Guo

Submit Requirements:

• Code-Owners
• Code-Review
• Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: comment

Gerrit-Project: v8/v8

Gerrit-Branch: main

Gerrit-Change-Id: I8fda56acedaaeadbbe4f911b27d36658d8248393

Gerrit-Change-Number: 7004962

Gerrit-PatchSet: 2

Gerrit-Owner: Issack John <issac...@microsoft.com>

Gerrit-Reviewer: Issack John <issac...@microsoft.com>

Gerrit-Reviewer: Michael Lippautz <mlip...@chromium.org>

Gerrit-Reviewer: Yang Guo <yan...@chromium.org>

Gerrit-CC: V8 LUCI CQ <v8-s...@luci-project-accounts.iam.gserviceaccount.com>

Gerrit-Attention: Yang Guo <yan...@chromium.org>

Gerrit-Attention: Michael Lippautz <mlip...@chromium.org>

Gerrit-Attention: Issack John <issac...@microsoft.com>

Gerrit-Comment-Date: Thu, 09 Oct 2025 17:22:52 +0000

Gerrit-HasComments: No

Gerrit-Has-Labels: No

[Yang Guo (Gerrit)]

Attention needed from Issack John and Michael Lippautz

Yang Guo added 2 comments

Patchset-level comments

File-level comment, Patchset 2 (Latest):

Yang Guo . resolved

Please file

File include/v8-profiler.h

Line 54, Patchset 2 (Latest): kSelfProfiling = 2,

Yang Guo . unresolved

This is not used anywhere. I assume that this will be used from Blink? I further assume that there will be a change in DevTools frontend to make use of this information?

Can you file a crbug so that we can track the rationale of this change and the associated CLs?

Open in Gerrit

Related details

Attention is currently required from:

• Issack John
• Michael Lippautz

Submit Requirements:

• Code-Owners
• Code-Review

• No-Unresolved-Comments

• Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: comment

Gerrit-Project: v8/v8

Gerrit-Branch: main

Gerrit-Change-Id: I8fda56acedaaeadbbe4f911b27d36658d8248393

Gerrit-Change-Number: 7004962

Gerrit-PatchSet: 2

Gerrit-Owner: Issack John <issac...@microsoft.com>

Gerrit-Reviewer: Issack John <issac...@microsoft.com>

Gerrit-Reviewer: Michael Lippautz <mlip...@chromium.org>

Gerrit-Reviewer: Yang Guo <yan...@chromium.org>

Gerrit-CC: V8 LUCI CQ <v8-s...@luci-project-accounts.iam.gserviceaccount.com>

Gerrit-Attention: Michael Lippautz <mlip...@chromium.org>

Gerrit-Attention: Issack John <issac...@microsoft.com>

Gerrit-Comment-Date: Fri, 10 Oct 2025 09:56:41 +0000

Gerrit-HasComments: Yes

Gerrit-Has-Labels: No

[Yang Guo (Gerrit)]

Attention needed from Issack John, Jack Franklin and Michael Lippautz

Yang Guo added 1 comment

Patchset-level comments

File-level comment, Patchset 2 (Latest):

Yang Guo . resolved

Jack, could you take a cursory look at this? Also, I anticipate a frontend change based on this.

Open in Gerrit

Related details

Attention is currently required from:

• Issack John
• Jack Franklin
• Michael Lippautz

Submit Requirements:

• Code-Owners
• Code-Review
• No-Unresolved-Comments
• Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: comment

Gerrit-Project: v8/v8

Gerrit-Branch: main

Gerrit-Change-Id: I8fda56acedaaeadbbe4f911b27d36658d8248393

Gerrit-Change-Number: 7004962

Gerrit-PatchSet: 2

Gerrit-Owner: Issack John <issac...@microsoft.com>

Gerrit-Reviewer: Issack John <issac...@microsoft.com>

Gerrit-Reviewer: Jack Franklin <jacktf...@chromium.org>

Gerrit-Reviewer: Michael Lippautz <mlip...@chromium.org>

Gerrit-Reviewer: Yang Guo <yan...@chromium.org>

Gerrit-CC: V8 LUCI CQ <v8-s...@luci-project-accounts.iam.gserviceaccount.com>

Gerrit-Attention: Michael Lippautz <mlip...@chromium.org>

Gerrit-Attention: Issack John <issac...@microsoft.com>

Gerrit-Attention: Jack Franklin <jacktf...@chromium.org>

Gerrit-Comment-Date: Fri, 10 Oct 2025 09:57:11 +0000

Gerrit-HasComments: Yes

Gerrit-Has-Labels: No

[Issack John (Gerrit)]

Attention needed from Jack Franklin, Michael Lippautz and Yang Guo

Issack John added 1 comment

File include/v8-profiler.h

Line 54, Patchset 2 (Latest): kSelfProfiling = 2,

Yang Guo . unresolved

This is not used anywhere. I assume that this will be used from Blink? I further assume that there will be a change in DevTools frontend to make use of this information?

Can you file a crbug so that we can track the rationale of this change and the associated CLs?

Issack John

Yes, it will be used from blink. The CL description is long, so it got cut off but the associated CLs are at the bottom along with the crbug.

Related CLs:
DevTools CL: https://crrev.com/c/6877206
Chromium CL: https://crrev.com/c/6874588

Bug: 375614293

Open in Gerrit

Related details

Attention is currently required from:

• Jack Franklin
• Michael Lippautz
• Yang Guo

Submit Requirements:

• Code-Owners
• Code-Review
• No-Unresolved-Comments
• Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: comment

Gerrit-Project: v8/v8

Gerrit-Branch: main

Gerrit-Change-Id: I8fda56acedaaeadbbe4f911b27d36658d8248393

Gerrit-Change-Number: 7004962

Gerrit-PatchSet: 2

Gerrit-Owner: Issack John <issac...@microsoft.com>

Gerrit-Reviewer: Issack John <issac...@microsoft.com>

Gerrit-Reviewer: Jack Franklin <jacktf...@chromium.org>

Gerrit-Reviewer: Michael Lippautz <mlip...@chromium.org>

Gerrit-Reviewer: Yang Guo <yan...@chromium.org>

Gerrit-CC: V8 LUCI CQ <v8-s...@luci-project-accounts.iam.gserviceaccount.com>

Gerrit-Attention: Yang Guo <yan...@chromium.org>

Gerrit-Attention: Michael Lippautz <mlip...@chromium.org>

Gerrit-Attention: Jack Franklin <jacktf...@chromium.org>

Gerrit-Comment-Date: Fri, 10 Oct 2025 16:09:33 +0000

Gerrit-HasComments: Yes

Gerrit-Has-Labels: No

Comment-In-Reply-To: Yang Guo <yan...@chromium.org>

[Yang Guo (Gerrit)]

Attention needed from Issack John, Jack Franklin and Michael Lippautz

Yang Guo added 1 comment

File include/v8-profiler.h

Line 54, Patchset 2 (Latest): kSelfProfiling = 2,

Yang Guo . unresolved

This is not used anywhere. I assume that this will be used from Blink? I further assume that there will be a change in DevTools frontend to make use of this information?

Can you file a crbug so that we can track the rationale of this change and the associated CLs?

Issack John

Yes, it will be used from blink. The CL description is long, so it got cut off but the associated CLs are at the bottom along with the crbug.

Related CLs:
DevTools CL: https://crrev.com/c/6877206
Chromium CL: https://crrev.com/c/6874588

Bug: 375614293

Yang Guo

Indeed I overlooked the content below the fold. Thanks!

I'd still like Jack to take a look, especially in combination with the DevTools CL.

Open in Gerrit

Related details

Attention is currently required from:

• Issack John
• Jack Franklin
• Michael Lippautz

Submit Requirements:

• Code-Owners
• Code-Review
• No-Unresolved-Comments
• Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: comment

Gerrit-Project: v8/v8

Gerrit-Branch: main

Gerrit-Change-Id: I8fda56acedaaeadbbe4f911b27d36658d8248393

Gerrit-Change-Number: 7004962

Gerrit-PatchSet: 2

Gerrit-Owner: Issack John <issac...@microsoft.com>

Gerrit-Reviewer: Issack John <issac...@microsoft.com>

Gerrit-Reviewer: Jack Franklin <jacktf...@chromium.org>

Gerrit-Reviewer: Michael Lippautz <mlip...@chromium.org>

Gerrit-Reviewer: Yang Guo <yan...@chromium.org>

Gerrit-CC: V8 LUCI CQ <v8-s...@luci-project-accounts.iam.gserviceaccount.com>

Gerrit-Attention: Michael Lippautz <mlip...@chromium.org>

Gerrit-Attention: Issack John <issac...@microsoft.com>

Gerrit-Attention: Jack Franklin <jacktf...@chromium.org>

Gerrit-Comment-Date: Mon, 13 Oct 2025 06:56:42 +0000

Gerrit-HasComments: Yes

Gerrit-Has-Labels: No

Comment-In-Reply-To: Yang Guo <yan...@chromium.org>

Comment-In-Reply-To: Issack John <issac...@microsoft.com>

[Issack John (Gerrit)]

Attention needed from Jack Franklin and Michael Lippautz

Issack John added 1 comment

File include/v8-profiler.h

Line 54, Patchset 2 (Latest): kSelfProfiling = 2,

Yang Guo . unresolved

This is not used anywhere. I assume that this will be used from Blink? I further assume that there will be a change in DevTools frontend to make use of this information?

Can you file a crbug so that we can track the rationale of this change and the associated CLs?

Issack John

Yes, it will be used from blink. The CL description is long, so it got cut off but the associated CLs are at the bottom along with the crbug.

Related CLs:
DevTools CL: https://crrev.com/c/6877206
Chromium CL: https://crrev.com/c/6874588

Bug: 375614293

Yang Guo

Indeed I overlooked the content below the fold. Thanks!

I'd still like Jack to take a look, especially in combination with the DevTools CL.

Issack John

SGTM

Open in Gerrit

Related details

Attention is currently required from:

• Jack Franklin
• Michael Lippautz

Submit Requirements:

• Code-Owners
• Code-Review
• No-Unresolved-Comments
• Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: comment

Gerrit-Project: v8/v8

Gerrit-Branch: main

Gerrit-Change-Id: I8fda56acedaaeadbbe4f911b27d36658d8248393

Gerrit-Change-Number: 7004962

Gerrit-PatchSet: 2

Gerrit-Owner: Issack John <issac...@microsoft.com>

Gerrit-Reviewer: Issack John <issac...@microsoft.com>

Gerrit-Reviewer: Jack Franklin <jacktf...@chromium.org>

Gerrit-Reviewer: Michael Lippautz <mlip...@chromium.org>

Gerrit-Reviewer: Yang Guo <yan...@chromium.org>

Gerrit-CC: V8 LUCI CQ <v8-s...@luci-project-accounts.iam.gserviceaccount.com>

Gerrit-Attention: Michael Lippautz <mlip...@chromium.org>

Gerrit-Attention: Jack Franklin <jacktf...@chromium.org>

Gerrit-Comment-Date: Tue, 14 Oct 2025 18:17:01 +0000

[Issack John (Gerrit)]

Attention needed from Jack Franklin and Michael Lippautz

Issack John added 1 comment

Patchset-level comments

File-level comment, Patchset 2 (Latest):

Yang Guo . resolved

Jack, could you take a cursory look at this? Also, I anticipate a frontend change based on this.

Issack John

Gentle ping. jacktfranklin@ 😊

Gerrit-Comment-Date: Fri, 24 Oct 2025 16:03:16 +0000