[maglev, non-eager inlining] Only change the CheckType of CheckMaps if the new type is better [v8/v8 : main]
0 views
Skip to first unread message
Marja Hölttä (Gerrit)
Jan 7, 2026, 1:41:34 PM (4 days ago) Jan 7
to Victor Gomes, chrom...@appspot.gserviceaccount.com, V8 LUCI CQ, leszek...@chromium.org, v8-re...@googlegroups.com, verwaes...@chromium.org, victorgo...@chromium.org
Attention needed from Victor Gomes
Marja Hölttä added 1 comment![]( "Open in Gerrit")
Patchset-level comments
Related details
Attention is currently required from:
- Victor Gomes
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Victor Gomes (Gerrit)
Jan 8, 2026, 3:41:02 AM (3 days ago) Jan 8
to Marja Hölttä, chrom...@appspot.gserviceaccount.com, V8 LUCI CQ, leszek...@chromium.org, v8-re...@googlegroups.com, verwaes...@chromium.org, victorgo...@chromium.org
Attention needed from Marja Hölttä
Victor Gomes added 1 comment![]( "Open in Gerrit")
File src/maglev/maglev-graph-optimizer.cc
Line 582, Patchset 1 (Latest):
if (node->check_type() == CheckType::kCheckHeapObject &&
reducer_.GetCheckType(known_info->type()) ==
CheckType::kOmitHeapObjectCheck) {
node->set_check_type(CheckType::kOmitHeapObjectCheck);
}
}Victor Gomes . unresolved
Interesting, I think this should always be better. If you have a counterexample, then the problem must be somewhere else I think. We probably not replicating/propagating something from the graph builder.
Related details
Attention is currently required from:
- Marja Hölttä
Submit Requirements:
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Marja Hölttä (Gerrit)
Jan 9, 2026, 6:04:08 AM (2 days ago) Jan 9
to Victor Gomes, chrom...@appspot.gserviceaccount.com, V8 LUCI CQ, leszek...@chromium.org, v8-re...@googlegroups.com, verwaes...@chromium.org, victorgo...@chromium.org
Attention needed from Victor Gomes
Marja Hölttä added 1 comment![]( "Open in Gerrit")
File src/maglev/maglev-graph-optimizer.cc
Line 582, Patchset 1 (Latest):
if (node->check_type() == CheckType::kCheckHeapObject &&
reducer_.GetCheckType(known_info->type()) ==
CheckType::kOmitHeapObjectCheck) {
node->set_check_type(CheckType::kOmitHeapObjectCheck);
}
}Victor Gomes . unresolved
Interesting, I think this should always be better. If you have a counterexample, then the problem must be somewhere else I think. We probably not replicating/propagating something from the graph builder.
Marja Hölttä
That was my intuition too, that's why the first version was like that. But this case indeed does occur. I'll investigate this further.
Related details
Attention is currently required from:
- Victor Gomes
Submit Requirements:
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages