Fix build with clang on big endian [v8/v8 : main]
0 views
Skip to first unread message
Milad Farazmand (Gerrit)
Oct 23, 2025, 3:50:15 PM (2 days ago) Oct 23
to Jakob Linke, Junliang Yan, jgrube...@chromium.org, pthier...@chromium.org, v8-re...@googlegroups.com
Attention needed from Jakob Linke
Milad Farazmand added 1 comment![]( "Open in Gerrit")
Patchset-level comments
Related details
Attention is currently required from:
- Jakob Linke
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Jakob Linke (Gerrit)
Oct 24, 2025, 12:53:53 AM (2 days ago) Oct 24
to Milad Farazmand, Junliang Yan, jgrube...@chromium.org, pthier...@chromium.org, v8-re...@googlegroups.com
Attention needed from Milad Farazmand
Jakob Linke voted Code-Review+1![]( "Open in Gerrit")
Attention is currently required from:
- Milad Farazmand
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Milad Farazmand (Gerrit)
Oct 24, 2025, 7:36:15 AM (2 days ago) Oct 24
to Jakob Linke, Junliang Yan, jgrube...@chromium.org, pthier...@chromium.org, v8-re...@googlegroups.com
Milad Farazmand voted Commit-Queue+2![]( "Open in Gerrit")
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
V8 LUCI CQ (Gerrit)
Oct 24, 2025, 8:19:02 AM (2 days ago) Oct 24
to Milad Farazmand, Jakob Linke, Junliang Yan, jgrube...@chromium.org, pthier...@chromium.org, v8-re...@googlegroups.com
V8 LUCI CQ submitted the change![]( "Open in Gerrit")
Change information
Commit message:
Fix build with clang on big endian
Clang currently generates the following warning/error due to
`UNIMPLEMENTED();` being used above them:
```
error: code will never be executed
```
Change-Id: I1cd8400ec1af66cfc15a089a50548275b3d0365b
Reviewed-by: Jakob Linke <jgr...@chromium.org>
Commit-Queue: Milad Farazmand <mfar...@ibm.com>
Cr-Commit-Position: refs/heads/main@{#103341}
Files:
- M src/regexp/regexp-bytecode-peephole.cc
- M src/runtime/runtime-wasm.cc
Change size: S
Delta: 2 files changed, 3 insertions(+), 9 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Jakob Linke
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages