Fix build with clang on big endian [v8/v8 : main]

0 views
Skip to first unread message

Milad Farazmand (Gerrit)

unread,
Oct 23, 2025, 3:50:15 PM (2 days ago) Oct 23
to Jakob Linke, Junliang Yan, jgrube...@chromium.org, pthier...@chromium.org, v8-re...@googlegroups.com
Attention needed from Jakob Linke

Milad Farazmand added 1 comment

Patchset-level comments
File-level comment, Patchset 2 (Latest):
Milad Farazmand . resolved

PTAL.

Open in Gerrit

Related details

Attention is currently required from:
  • Jakob Linke
Submit Requirements:
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: v8/v8
Gerrit-Branch: main
Gerrit-Change-Id: I1cd8400ec1af66cfc15a089a50548275b3d0365b
Gerrit-Change-Number: 7080049
Gerrit-PatchSet: 2
Gerrit-Owner: Milad Farazmand <mfar...@ibm.com>
Gerrit-Reviewer: Jakob Linke <jgr...@chromium.org>
Gerrit-CC: Junliang Yan <jun...@ibm.com>
Gerrit-Attention: Jakob Linke <jgr...@chromium.org>
Gerrit-Comment-Date: Thu, 23 Oct 2025 19:50:12 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
unsatisfied_requirement
open
diffy

Jakob Linke (Gerrit)

unread,
Oct 24, 2025, 12:53:53 AM (2 days ago) Oct 24
to Milad Farazmand, Junliang Yan, jgrube...@chromium.org, pthier...@chromium.org, v8-re...@googlegroups.com
Attention needed from Milad Farazmand

Jakob Linke voted Code-Review+1

Code-Review+1
Open in Gerrit

Related details

Attention is currently required from:
  • Milad Farazmand
Submit Requirements:
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: v8/v8
Gerrit-Branch: main
Gerrit-Change-Id: I1cd8400ec1af66cfc15a089a50548275b3d0365b
Gerrit-Change-Number: 7080049
Gerrit-PatchSet: 2
Gerrit-Owner: Milad Farazmand <mfar...@ibm.com>
Gerrit-Reviewer: Jakob Linke <jgr...@chromium.org>
Gerrit-CC: Junliang Yan <jun...@ibm.com>
Gerrit-Attention: Milad Farazmand <mfar...@ibm.com>
Gerrit-Comment-Date: Fri, 24 Oct 2025 04:53:46 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

Milad Farazmand (Gerrit)

unread,
Oct 24, 2025, 7:36:15 AM (2 days ago) Oct 24
to Jakob Linke, Junliang Yan, jgrube...@chromium.org, pthier...@chromium.org, v8-re...@googlegroups.com

Milad Farazmand voted Commit-Queue+2

Commit-Queue+2
Open in Gerrit

Related details

Attention set is empty
Submit Requirements:
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: v8/v8
Gerrit-Branch: main
Gerrit-Change-Id: I1cd8400ec1af66cfc15a089a50548275b3d0365b
Gerrit-Change-Number: 7080049
Gerrit-PatchSet: 2
Gerrit-Owner: Milad Farazmand <mfar...@ibm.com>
Gerrit-Reviewer: Jakob Linke <jgr...@chromium.org>
Gerrit-Reviewer: Milad Farazmand <mfar...@ibm.com>
Gerrit-CC: Junliang Yan <jun...@ibm.com>
Gerrit-Comment-Date: Fri, 24 Oct 2025 11:36:11 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

V8 LUCI CQ (Gerrit)

unread,
Oct 24, 2025, 8:19:02 AM (2 days ago) Oct 24
to Milad Farazmand, Jakob Linke, Junliang Yan, jgrube...@chromium.org, pthier...@chromium.org, v8-re...@googlegroups.com

V8 LUCI CQ submitted the change

Change information

Commit message:
Fix build with clang on big endian

Clang currently generates the following warning/error due to
`UNIMPLEMENTED();` being used above them:
```
error: code will never be executed
```
Change-Id: I1cd8400ec1af66cfc15a089a50548275b3d0365b
Reviewed-by: Jakob Linke <jgr...@chromium.org>
Commit-Queue: Milad Farazmand <mfar...@ibm.com>
Cr-Commit-Position: refs/heads/main@{#103341}
Files:
  • M src/regexp/regexp-bytecode-peephole.cc
  • M src/runtime/runtime-wasm.cc
Change size: S
Delta: 2 files changed, 3 insertions(+), 9 deletions(-)
Branch: refs/heads/main
Submit Requirements:
  • requirement satisfiedCode-Review: +1 by Jakob Linke
Open in Gerrit
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: merged
Gerrit-Project: v8/v8
Gerrit-Branch: main
Gerrit-Change-Id: I1cd8400ec1af66cfc15a089a50548275b3d0365b
Gerrit-Change-Number: 7080049
Gerrit-PatchSet: 3
Gerrit-Owner: Milad Farazmand <mfar...@ibm.com>
Gerrit-Reviewer: Jakob Linke <jgr...@chromium.org>
Gerrit-Reviewer: Milad Farazmand <mfar...@ibm.com>
Gerrit-CC: Junliang Yan <jun...@ibm.com>
open
diffy
satisfied_requirement
Reply all
Reply to author
Forward
0 new messages