[api] Avoid species lookup in v8::Promise::{Then,Catch} [v8/v8 : main]
0 views
Skip to first unread message
Leszek Swirski (Gerrit)
Oct 23, 2025, 8:34:05 AM (3 days ago) Oct 23
to Olivier Flückiger, Andreas Haas, V8 LUCI CQ, cbruni...@chromium.org, v8-re...@googlegroups.com
Attention needed from Andreas Haas and Olivier Flückiger
Leszek Swirski added 1 comment![]( "Open in Gerrit")
Patchset-level comments
File-level comment, Patchset 1 (Latest):
Leszek Swirski . resolved
Oli, PTAL overall
Andreas, PTAL wasm tests
Related details
Attention is currently required from:
- Andreas Haas
- Olivier Flückiger
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Andreas Haas (Gerrit)
Oct 23, 2025, 8:46:36 AM (3 days ago) Oct 23
to Leszek Swirski, Olivier Flückiger, V8 LUCI CQ, cbruni...@chromium.org, v8-re...@googlegroups.com
Attention needed from Leszek Swirski and Olivier Flückiger
Andreas Haas voted and added 1 comment![]( "Open in Gerrit")
Votes added by Andreas Haas
| Code-Review | +1 |
1 comment
Patchset-level comments
Andreas Haas . resolved
I would say you can delete one of the tests, and only keep the one with compileStreaming. Both functions share the implementation at the moment anyways, and even if they didn't, I don't think this corner case would be worth spending twice the CPU cycles.
Related details
Attention is currently required from:
- Leszek Swirski
- Olivier Flückiger
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Leszek Swirski (Gerrit)
Oct 23, 2025, 8:51:49 AM (3 days ago) Oct 23
to Andreas Haas, Olivier Flückiger, V8 LUCI CQ, cbruni...@chromium.org, v8-re...@googlegroups.com
Attention needed from Andreas Haas and Olivier Flückiger
Leszek Swirski voted and added 1 comment![]( "Open in Gerrit")
Votes added by Leszek Swirski
| Commit-Queue | +1 |
Andreas Haas . resolved
I would say you can delete one of the tests, and only keep the one with compileStreaming. Both functions share the implementation at the moment anyways, and even if they didn't, I don't think this corner case would be worth spending twice the CPU cycles.
Attention is currently required from:
- Andreas Haas
- Olivier Flückiger
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Andreas Haas (Gerrit)
Oct 23, 2025, 9:01:18 AM (3 days ago) Oct 23
to Leszek Swirski, Olivier Flückiger, V8 LUCI CQ, cbruni...@chromium.org, v8-re...@googlegroups.com
Attention needed from Leszek Swirski and Olivier Flückiger
Andreas Haas voted Code-Review+1![]( "Open in Gerrit")
Attention is currently required from:
- Leszek Swirski
- Olivier Flückiger
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Olivier Flückiger (Gerrit)
Oct 23, 2025, 10:00:36 AM (3 days ago) Oct 23
to Leszek Swirski, Andreas Haas, V8 LUCI CQ, cbruni...@chromium.org, v8-re...@googlegroups.com
Attention needed from Leszek Swirski
Olivier Flückiger added 2 comments![]( "Open in Gerrit")
Patchset-level comments
File include/v8-promise.h
Line 73, Patchset 2 (Latest):
* This performs the PerformPromiseThen abstract operation, rather than theOlivier Flückiger . unresolved
... performs the PerformPromiseThen abstract operation with a fresh native promise as result, ...
Related details
Attention is currently required from:
- Leszek Swirski
Submit Requirements:
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Olivier Flückiger (Gerrit)
Oct 23, 2025, 10:00:41 AM (3 days ago) Oct 23
to Leszek Swirski, Andreas Haas, V8 LUCI CQ, cbruni...@chromium.org, v8-re...@googlegroups.com
Attention needed from Leszek Swirski
Olivier Flückiger voted Code-Review+1![]( "Open in Gerrit")
| Code-Review | +1 |
Related details
Attention is currently required from:
- Leszek Swirski
Submit Requirements:
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Leszek Swirski (Gerrit)
Oct 23, 2025, 10:26:11 AM (3 days ago) Oct 23
to Olivier Flückiger, Andreas Haas, V8 LUCI CQ, cbruni...@chromium.org, v8-re...@googlegroups.com
Leszek Swirski voted and added 2 comments![]( "Open in Gerrit")
Votes added by Leszek Swirski
| Commit-Queue | +2 |
2 comments
Patchset-level comments
File include/v8-promise.h
Line 73, Patchset 2:
* This performs the PerformPromiseThen abstract operation, rather than theOlivier Flückiger . resolved
... performs the PerformPromiseThen abstract operation with a fresh native promise as result, ...
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Leszek Swirski (Gerrit)
Oct 24, 2025, 6:48:40 AM (2 days ago) Oct 24
to Olivier Flückiger, Andreas Haas, V8 LUCI CQ, cbruni...@chromium.org, v8-re...@googlegroups.com
Leszek Swirski voted Commit-Queue+2![]( "Open in Gerrit")
| Commit-Queue | +2 |
Related details
Attention set is empty
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Leszek Swirski (Gerrit)
Oct 24, 2025, 9:34:52 AM (2 days ago) Oct 24
to Olivier Flückiger, Andreas Haas, V8 LUCI CQ, cbruni...@chromium.org, v8-re...@googlegroups.com
Leszek Swirski voted Commit-Queue+2![]( "Open in Gerrit")
| Commit-Queue | +2 |
Related details
Attention set is empty
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages