[test] Variable module hole check [v8/v8 : main]

0 views
Skip to first unread message

Victor Gomes (Gerrit)

unread,
Feb 2, 2026, 4:18:24 AM (2 days ago) Feb 2
to Leszek Swirski, v8-re...@googlegroups.com
Attention needed from Leszek Swirski

Victor Gomes added 1 comment

Patchset-level comments
File-level comment, Patchset 1 (Latest):
Victor Gomes . resolved

PTAL! I forgot to add the test.

Open in Gerrit

Related details

Attention is currently required from:
  • Leszek Swirski
Submit Requirements:
  • requirement satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: v8/v8
Gerrit-Branch: main
Gerrit-Change-Id: I2a98eece35dc2efb174301208df63662de20427a
Gerrit-Change-Number: 7535117
Gerrit-PatchSet: 1
Gerrit-Owner: Victor Gomes <victo...@chromium.org>
Gerrit-Reviewer: Leszek Swirski <les...@chromium.org>
Gerrit-Attention: Leszek Swirski <les...@chromium.org>
Gerrit-Comment-Date: Mon, 02 Feb 2026 09:18:19 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
satisfied_requirement
unsatisfied_requirement
open
diffy

Victor Gomes (Gerrit)

unread,
Feb 2, 2026, 5:01:51 AM (2 days ago) Feb 2
to Leszek Swirski, v8-re...@googlegroups.com
Attention needed from Leszek Swirski

Victor Gomes voted and added 1 comment

Votes added by Victor Gomes

Auto-Submit+1
Commit-Queue+1

1 comment

Patchset-level comments
Victor Gomes . resolved

PTAL!

Related details

Attention is currently required from:
  • Leszek Swirski
Submit Requirements:
  • requirement satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: v8/v8
Gerrit-Branch: main
Gerrit-Change-Id: I2a98eece35dc2efb174301208df63662de20427a
Gerrit-Change-Number: 7535117
Gerrit-PatchSet: 3
Gerrit-Owner: Victor Gomes <victo...@chromium.org>
Gerrit-Reviewer: Leszek Swirski <les...@chromium.org>
Gerrit-Reviewer: Victor Gomes <victo...@chromium.org>
Gerrit-Attention: Leszek Swirski <les...@chromium.org>
Gerrit-Comment-Date: Mon, 02 Feb 2026 10:01:47 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

Leszek Swirski (Gerrit)

unread,
Feb 3, 2026, 5:47:15 AM (23 hours ago) Feb 3
to Victor Gomes, V8 LUCI CQ, v8-re...@googlegroups.com
Attention needed from Victor Gomes

Leszek Swirski voted

Code-Review+1
Commit-Queue+2
Open in Gerrit

Related details

Attention is currently required from:
  • Victor Gomes
Submit Requirements:
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: v8/v8
Gerrit-Branch: main
Gerrit-Change-Id: I2a98eece35dc2efb174301208df63662de20427a
Gerrit-Change-Number: 7535117
Gerrit-PatchSet: 3
Gerrit-Owner: Victor Gomes <victo...@chromium.org>
Gerrit-Reviewer: Leszek Swirski <les...@chromium.org>
Gerrit-Reviewer: Victor Gomes <victo...@chromium.org>
Gerrit-Attention: Victor Gomes <victo...@chromium.org>
Gerrit-Comment-Date: Tue, 03 Feb 2026 10:47:10 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

V8 LUCI CQ (Gerrit)

unread,
Feb 3, 2026, 9:00:53 AM (19 hours ago) Feb 3
to Victor Gomes, Leszek Swirski, v8-re...@googlegroups.com

V8 LUCI CQ submitted the change

Change information

Commit message:
[test] Variable module hole check
Bug: 479726070
Change-Id: I2a98eece35dc2efb174301208df63662de20427a
Reviewed-by: Leszek Swirski <les...@chromium.org>
Commit-Queue: Leszek Swirski <les...@chromium.org>
Auto-Submit: Victor Gomes <victo...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#105062}
Files:
  • A test/mjsunit/maglev/regress-480100972.mjs
Change size: S
Delta: 1 file changed, 19 insertions(+), 0 deletions(-)
Branch: refs/heads/main
Submit Requirements:
  • requirement satisfiedCode-Review: +1 by Leszek Swirski
Open in Gerrit
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: merged
Gerrit-Project: v8/v8
Gerrit-Branch: main
Gerrit-Change-Id: I2a98eece35dc2efb174301208df63662de20427a
Gerrit-Change-Number: 7535117
Gerrit-PatchSet: 4
Gerrit-Owner: Victor Gomes <victo...@chromium.org>
Gerrit-Reviewer: Leszek Swirski <les...@chromium.org>
Gerrit-Reviewer: Victor Gomes <victo...@chromium.org>
open
diffy
satisfied_requirement
Reply all
Reply to author
Forward
0 new messages