cppgc: Mitigate Oilpan VA exhaustions [v8/v8 : main]
0 views
Skip to first unread message
Michael Lippautz (Gerrit)
Sep 23, 2025, 11:54:35 AM (3 days ago) Sep 23
to Anton Bikineev, AyeAye, V8 LUCI CQ, Hannes Payer, mlippau...@chromium.org, oilpan-r...@chromium.org, v8-re...@googlegroups.com
Attention needed from Anton Bikineev
Michael Lippautz voted and added 1 comment![]( "Open in Gerrit")
Votes added by Michael Lippautz
| Code-Review | +1 |
1 comment
File src/heap/cppgc/caged-heap.cc
Line 68, Patchset 3 (Latest):
// SystemPageSize, which may fail on system with .Michael Lippautz . unresolved
There's some text missing :)
Related details
Attention is currently required from:
- Anton Bikineev
Submit Requirements:
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Anton Bikineev (Gerrit)
Sep 24, 2025, 11:51:01 AM (2 days ago) Sep 24
to Michael Lippautz, AyeAye, V8 LUCI CQ, Hannes Payer, mlippau...@chromium.org, oilpan-r...@chromium.org, v8-re...@googlegroups.com
Attention needed from Michael Lippautz
Anton Bikineev added 1 comment![]( "Open in Gerrit")
File src/heap/cppgc/caged-heap.cc
There's some text missing :)
Attention is currently required from:
- Michael Lippautz
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Anton Bikineev (Gerrit)
Sep 24, 2025, 11:51:30 AM (2 days ago) Sep 24
to Michael Lippautz, AyeAye, V8 LUCI CQ, Hannes Payer, mlippau...@chromium.org, oilpan-r...@chromium.org, v8-re...@googlegroups.com
Attention needed from Michael Lippautz
Anton Bikineev added 1 comment![]( "Open in Gerrit")
Patchset-level comments
Related details
Attention is currently required from:
- Michael Lippautz
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Anton Bikineev (Gerrit)
Sep 24, 2025, 11:51:55 AM (2 days ago) Sep 24
to Michael Lippautz, AyeAye, V8 LUCI CQ, Hannes Payer, mlippau...@chromium.org, oilpan-r...@chromium.org, v8-re...@googlegroups.com
Attention needed from Michael Lippautz
Anton Bikineev added 1 comment![]( "Open in Gerrit")
Patchset-level comments
Anton Bikineev . resolved
ptal, some stuff was updated
Anton Bikineev
To make it work for LSAN and Windows
Related details
Attention is currently required from:
- Michael Lippautz
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Michael Lippautz (Gerrit)
Sep 24, 2025, 12:06:58 PM (2 days ago) Sep 24
to Anton Bikineev, AyeAye, V8 LUCI CQ, Hannes Payer, mlippau...@chromium.org, oilpan-r...@chromium.org, v8-re...@googlegroups.com
Attention needed from Anton Bikineev
Michael Lippautz voted Code-Review+1![]( "Open in Gerrit")
Attention is currently required from:
- Anton Bikineev
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Anton Bikineev (Gerrit)
Sep 25, 2025, 4:03:18 AM (yesterday) Sep 25
to Michael Lippautz, AyeAye, V8 LUCI CQ, Hannes Payer, mlippau...@chromium.org, oilpan-r...@chromium.org, v8-re...@googlegroups.com
Anton Bikineev voted Commit-Queue+2![]( "Open in Gerrit")
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
V8 LUCI CQ (Gerrit)
Sep 25, 2025, 4:04:45 AM (yesterday) Sep 25
to Anton Bikineev, Michael Lippautz, AyeAye, Hannes Payer, mlippau...@chromium.org, oilpan-r...@chromium.org, v8-re...@googlegroups.com
V8 LUCI CQ submitted the change![]( "Open in Gerrit")
Change information
Commit message:
cppgc: Mitigate Oilpan VA exhaustions
Currently, Oilpan tries to overreserve the cage to make sure that the
LSB of the masked out pointer part is 1. It does it by allocating twice
the actual useful reservation size and twice the needed alignment
(16GB). This causes the platform allocator to mmap 64GB - kPageSize,
which may often fail on systems with low reservation limits
(VA_BITS==39), especially with the presence of the V8 Sandbox and
the out-of-line PA metadata.
The CL aims to mitigate it by using the opportunistic strategy:
1) first, relax the requirement of the alignment to be twice the needed
alignment. Instead, just pick the needed half. This will try to
mmap 48GB - kPageSize.
2) if this fails, try to allocate the actual useful reservation size
(16GB) for a few tries until the LSB of the masked out part is 1.
Bug: 444613347
Change-Id: Idea29fd019d75e9904648bcdcdde8754b3475ac1
Commit-Queue: Anton Bikineev <biki...@chromium.org>
Reviewed-by: Michael Lippautz <mlip...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#102748}
Files:
- M src/heap/cppgc/caged-heap.cc
- M src/heap/cppgc/caged-heap.h
- M src/heap/cppgc/virtual-memory.cc
- M src/heap/cppgc/virtual-memory.h
Change size: M
Delta: 4 files changed, 121 insertions(+), 50 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Michael Lippautz
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Rezvan Mahdavi Hezaveh (Gerrit)
Sep 25, 2025, 5:57:51 PM (18 hours ago) Sep 25
to V8 LUCI CQ, Anton Bikineev, Michael Lippautz, AyeAye, Hannes Payer, mlippau...@chromium.org, oilpan-r...@chromium.org, v8-re...@googlegroups.com
Rezvan Mahdavi Hezaveh has created a revert of this change![]( "Open in Gerrit")
Related details
Attention set is empty
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages