[base] Use absl::int128 in DiyFp and FixedDtoa [v8/v8 : main]
0 views
Skip to first unread message
Leszek Swirski (Gerrit)
Jan 8, 2026, 11:33:41 AM (2 days ago) Jan 8
to Patrick Thier, V8 LUCI CQ, v8-re...@googlegroups.com
Attention needed from Patrick Thier
Leszek Swirski voted and added 1 comment![]( "Open in Gerrit")
Votes added by Leszek Swirski
| Auto-Submit | +1 |
1 comment
Patchset-level comments
Related details
Attention is currently required from:
- Patrick Thier
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Patrick Thier (Gerrit)
Jan 8, 2026, 11:42:36 AM (2 days ago) Jan 8
to Leszek Swirski, V8 LUCI CQ, v8-re...@googlegroups.com
Attention needed from Leszek Swirski
Patrick Thier voted and added 2 comments![]( "Open in Gerrit")
Votes added by Patrick Thier
| Code-Review | +1 |
2 comments
Patchset-level comments
Patrick Thier . resolved
LGTM
Commit Message
Line 9, Patchset 1 (Latest):
Since we have absl now, we can use it for int128 stuff on plaforms thatPatrick Thier . unresolved
Please fix this WARNING reported by Spellchecker: "plaforms" is a possible misspelling of "platforms".
To bypass Spellchecker, ad...
"plaforms" is a possible misspelling of "platforms".
To bypass Spellchecker, add a footer with DISABLE_SPELLCHECKER
Related details
Attention is currently required from:
- Leszek Swirski
Submit Requirements:
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Leszek Swirski (Gerrit)
Jan 9, 2026, 4:15:00 AM (yesterday) Jan 9
to Patrick Thier, V8 LUCI CQ, v8-re...@googlegroups.com
Leszek Swirski voted and added 1 comment![]( "Open in Gerrit")
Votes added by Leszek Swirski
| Auto-Submit | +1 |
1 comment
Commit Message
Line 9, Patchset 1:
Since we have absl now, we can use it for int128 stuff on plaforms thatPatrick Thier . resolved
Please fix this WARNING reported by Spellchecker: "plaforms" is a possible misspelling of "platforms".
To bypass Spellchecker, ad...
"plaforms" is a possible misspelling of "platforms".
To bypass Spellchecker, add a footer with DISABLE_SPELLCHECKER
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Leszek Swirski (Gerrit)
Jan 9, 2026, 4:48:44 AM (yesterday) Jan 9
to Patrick Thier, V8 LUCI CQ, v8-re...@googlegroups.com
Leszek Swirski voted Commit-Queue+2![]( "Open in Gerrit")
| Commit-Queue | +2 |
Related details
Attention set is empty
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
V8 LUCI CQ (Gerrit)
Jan 9, 2026, 4:50:23 AM (yesterday) Jan 9
to Leszek Swirski, Patrick Thier, v8-re...@googlegroups.com
V8 LUCI CQ submitted the change with unreviewed changes![]( "Open in Gerrit")
Unreviewed changes
1 is the latest approved patch-set.
The change was submitted with unreviewed changes in the following files:
```
The name of the file: src/base/numbers/diy-fp.h
Insertions: 1, Deletions: 1.
@@ -51,7 +51,7 @@
// returns a * b;
static DiyFp Times(const DiyFp& a, const DiyFp& b) {
- absl::int128 mul = a.f_ * absl::int128(b.f_);
+ absl::uint128 mul = a.f_ * absl::uint128(b.f_);
uint64_t hi = absl::Uint128High64(mul);
uint64_t lo = absl::Uint128Low64(mul);
return {hi + (lo >> 63), a.e_ + b.e_ + 64};
```
Change information
Commit message:
[base] Use absl::int128 in DiyFp and FixedDtoa
Since we have absl now, we can use it for int128 stuff on platforms that
don't support __int128, rather than our own manual int64-pair impls.
Change-Id: Ib1616791dd9960ea134ea4b38f37c65bd80b78b9
Auto-Submit: Leszek Swirski <les...@chromium.org>
Reviewed-by: Patrick Thier <pth...@chromium.org>
Commit-Queue: Leszek Swirski <les...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#104586}
Files:
- M DEPS
- M src/base/numbers/diy-fp.cc
- M src/base/numbers/diy-fp.h
- M src/base/numbers/fixed-dtoa.cc
Change size: M
Delta: 4 files changed, 21 insertions(+), 99 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Patrick Thier
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages