[api] Add and use v8::HeapProfiler::ContextNameResolver interface [v8/v8 : main]

[Igor Sheludko (Gerrit)]

Attention needed from Michael Lippautz

Igor Sheludko voted and added 1 comment

Votes added by Igor Sheludko

Auto-Submit

+1

1 comment

File test/cctest/test-heap-profiler.cc

Line 2298, Patchset 4 (Latest):TEST(ContextNameSimple) {

Igor Sheludko . unresolved

These are the copies of the GlobalObjectName* tests above but for the new interface.

Open in Gerrit

Related details

Attention is currently required from:

• Michael Lippautz

Submit Requirements:

• Code-Owners
• Code-Review
• No-Unresolved-Comments

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: comment

Gerrit-Project: v8/v8

Gerrit-Branch: main

Gerrit-Change-Id: Ifc64076cdccb86b4d58faaa80f700ea555a016a4

Gerrit-Change-Number: 6909448

Gerrit-PatchSet: 4

Gerrit-Owner: Igor Sheludko <ish...@chromium.org>

Gerrit-Reviewer: Igor Sheludko <ish...@chromium.org>

Gerrit-Reviewer: Michael Lippautz <mlip...@chromium.org>

Gerrit-CC: AyeAye <android-bu...@system.gserviceaccount.com>

Gerrit-CC: V8 LUCI CQ <v8-s...@luci-project-accounts.iam.gserviceaccount.com>

Gerrit-Attention: Michael Lippautz <mlip...@chromium.org>

Gerrit-Comment-Date: Wed, 03 Sep 2025 10:38:35 +0000

Gerrit-HasComments: Yes

Gerrit-Has-Labels: Yes

[Igor Sheludko (Gerrit)]

Attention needed from Michael Lippautz

Igor Sheludko added 1 comment

Patchset-level comments

File-level comment, Patchset 4 (Latest):

Igor Sheludko . resolved

Simon, FYI

Open in Gerrit

Related details

Attention is currently required from:

• Michael Lippautz

Submit Requirements:

• Code-Owners
• Code-Review
• No-Unresolved-Comments

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: comment

Gerrit-Project: v8/v8

Gerrit-Branch: main

Gerrit-Change-Id: Ifc64076cdccb86b4d58faaa80f700ea555a016a4

Gerrit-Change-Number: 6909448

Gerrit-PatchSet: 4

Gerrit-Owner: Igor Sheludko <ish...@chromium.org>

Gerrit-Reviewer: Igor Sheludko <ish...@chromium.org>

Gerrit-Reviewer: Michael Lippautz <mlip...@chromium.org>

Gerrit-CC: AyeAye <android-bu...@system.gserviceaccount.com>

Gerrit-CC: Simon Zünd <szu...@chromium.org>

Gerrit-CC: V8 LUCI CQ <v8-s...@luci-project-accounts.iam.gserviceaccount.com>

Gerrit-Attention: Michael Lippautz <mlip...@chromium.org>

Gerrit-Comment-Date: Wed, 03 Sep 2025 10:39:31 +0000

Gerrit-HasComments: Yes

Gerrit-Has-Labels: No

[Michael Lippautz (Gerrit)]

Attention needed from Igor Sheludko

Michael Lippautz added 1 comment

File include/v8-profiler.h

Line 1054, Patchset 4 (Latest):

Michael Lippautz . unresolved

How about adding the proper `GetName()` overload to the `ObjectNameResolver`?

Would that simplify the deprecation?

Open in Gerrit

Related details

Attention is currently required from:

• Igor Sheludko

Submit Requirements:

• Code-Owners
• Code-Review
• No-Unresolved-Comments

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: comment

Gerrit-Project: v8/v8

Gerrit-Branch: main

Gerrit-Change-Id: Ifc64076cdccb86b4d58faaa80f700ea555a016a4

Gerrit-Change-Number: 6909448

Gerrit-PatchSet: 4

Gerrit-Owner: Igor Sheludko <ish...@chromium.org>

Gerrit-Reviewer: Igor Sheludko <ish...@chromium.org>

Gerrit-Reviewer: Michael Lippautz <mlip...@chromium.org>

Gerrit-CC: AyeAye <android-bu...@system.gserviceaccount.com>

Gerrit-CC: Simon Zünd <szu...@chromium.org>

Gerrit-CC: V8 LUCI CQ <v8-s...@luci-project-accounts.iam.gserviceaccount.com>

Gerrit-Attention: Igor Sheludko <ish...@chromium.org>

Gerrit-Comment-Date: Wed, 03 Sep 2025 13:52:37 +0000

Gerrit-HasComments: Yes

Gerrit-Has-Labels: No

[Igor Sheludko (Gerrit)]

Attention needed from Michael Lippautz

Igor Sheludko added 1 comment

File include/v8-profiler.h

Line 1054, Patchset 4 (Latest):

Michael Lippautz . resolved

How about adding the proper `GetName()` overload to the `ObjectNameResolver`?

Would that simplify the deprecation?

Igor Sheludko

I think this way it'd be cleaner unless we have plans to give other objects friendly names.
Plus, I think we'd like to rename the `HeapSnapshotOptions::global_object_name_resolver` field to keep things clean.
This Api is mostly used inside V8, so I think the deprecation is going to be smooth.

Open in Gerrit

Related details

Attention is currently required from:

• Michael Lippautz

Submit Requirements:

• Code-Owners
• Code-Review
• No-Unresolved-Comments

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: comment

Gerrit-Project: v8/v8

Gerrit-Branch: main

Gerrit-Change-Id: Ifc64076cdccb86b4d58faaa80f700ea555a016a4

Gerrit-Change-Number: 6909448

Gerrit-PatchSet: 4

Gerrit-Owner: Igor Sheludko <ish...@chromium.org>

Gerrit-Reviewer: Igor Sheludko <ish...@chromium.org>

Gerrit-Reviewer: Michael Lippautz <mlip...@chromium.org>

Gerrit-CC: AyeAye <android-bu...@system.gserviceaccount.com>

Gerrit-CC: Simon Zünd <szu...@chromium.org>

Gerrit-CC: V8 LUCI CQ <v8-s...@luci-project-accounts.iam.gserviceaccount.com>

Gerrit-Attention: Michael Lippautz <mlip...@chromium.org>

Gerrit-Comment-Date: Wed, 03 Sep 2025 16:13:40 +0000

Gerrit-HasComments: Yes

Gerrit-Has-Labels: No

Comment-In-Reply-To: Michael Lippautz <mlip...@chromium.org>

[Michael Lippautz (Gerrit)]

Attention needed from Igor Sheludko

Michael Lippautz voted and added 1 comment

Votes added by Michael Lippautz

Code-Review

+1

1 comment

File include/v8-profiler.h

Line 1054, Patchset 4 (Latest):

Michael Lippautz . resolved

How about adding the proper `GetName()` overload to the `ObjectNameResolver`?

Would that simplify the deprecation?

Igor Sheludko

I think this way it'd be cleaner unless we have plans to give other objects friendly names.
Plus, I think we'd like to rename the `HeapSnapshotOptions::global_object_name_resolver` field to keep things clean.
This Api is mostly used inside V8, so I think the deprecation is going to be smooth.

Michael Lippautz

Ack

Open in Gerrit

Related details

Attention is currently required from:

• Igor Sheludko

Submit Requirements:

• Code-Owners
• Code-Review

• No-Unresolved-Comments

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: comment

Gerrit-Project: v8/v8

Gerrit-Branch: main

Gerrit-Change-Id: Ifc64076cdccb86b4d58faaa80f700ea555a016a4

Gerrit-Change-Number: 6909448

Gerrit-PatchSet: 4

Gerrit-Owner: Igor Sheludko <ish...@chromium.org>

Gerrit-Reviewer: Igor Sheludko <ish...@chromium.org>

Gerrit-Reviewer: Michael Lippautz <mlip...@chromium.org>

Gerrit-CC: AyeAye <android-bu...@system.gserviceaccount.com>

Gerrit-CC: Simon Zünd <szu...@chromium.org>

Gerrit-CC: V8 LUCI CQ <v8-s...@luci-project-accounts.iam.gserviceaccount.com>

Gerrit-Attention: Igor Sheludko <ish...@chromium.org>

Gerrit-Comment-Date: Thu, 04 Sep 2025 14:25:39 +0000

Gerrit-HasComments: Yes

Gerrit-Has-Labels: Yes

Comment-In-Reply-To: Michael Lippautz <mlip...@chromium.org>

Comment-In-Reply-To: Igor Sheludko <ish...@chromium.org>