[riscv] Refactor the DEBUG_RISCV to support dumping log to a file. [v8/v8 : main]

0 views
Skip to first unread message

Ji Qiu (Gerrit)

unread,
Sep 25, 2025, 3:24:03 AM (3 days ago) Sep 25
to Yahan Lu (LuYahan), V8 LUCI CQ, Kasper Lund, Toon Verwaest, v8-flag...@chromium.org, v8-re...@googlegroups.com
Attention needed from Kasper Lund, Toon Verwaest and Yahan Lu (LuYahan)

Ji Qiu voted Code-Review+1

Code-Review+1
Open in Gerrit

Related details

Attention is currently required from:
  • Kasper Lund
  • Toon Verwaest
  • Yahan Lu (LuYahan)
Submit Requirements:
  • requirement is not satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: v8/v8
Gerrit-Branch: main
Gerrit-Change-Id: I30275eb1c7f3b7f70ae981122e2c73980805dc9d
Gerrit-Change-Number: 6979424
Gerrit-PatchSet: 5
Gerrit-Owner: Yahan Lu (LuYahan) <ya...@iscas.ac.cn>
Gerrit-Reviewer: Ji Qiu <qi...@iscas.ac.cn>
Gerrit-Reviewer: Kasper Lund <kas...@rivosinc.com>
Gerrit-Reviewer: Toon Verwaest <verw...@chromium.org>
Gerrit-Reviewer: Yahan Lu (LuYahan) <ya...@iscas.ac.cn>
Gerrit-Attention: Toon Verwaest <verw...@chromium.org>
Gerrit-Attention: Yahan Lu (LuYahan) <ya...@iscas.ac.cn>
Gerrit-Attention: Kasper Lund <kas...@rivosinc.com>
Gerrit-Comment-Date: Thu, 25 Sep 2025 07:23:59 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
unsatisfied_requirement
satisfied_requirement
open
diffy

Kasper Lund (Gerrit)

unread,
Sep 25, 2025, 8:29:18 AM (3 days ago) Sep 25
to Yahan Lu (LuYahan), Ji Qiu, V8 LUCI CQ, Toon Verwaest, v8-flag...@chromium.org, v8-re...@googlegroups.com
Attention needed from Toon Verwaest and Yahan Lu (LuYahan)

Kasper Lund voted and added 2 comments

Votes added by Kasper Lund

Code-Review+1

2 comments

File src/codegen/riscv/assembler-riscv.h
Line 71, Patchset 5 (Latest):class SafepointTableBuilder;
Kasper Lund . resolved

Maybe drop this forward declaration too? It is also in base-assembler-riscv.h.

File src/codegen/riscv/base-assembler-riscv.h
Line 75, Patchset 5 (Latest): if ((v8_flags.riscv_debug)) [[unlikely]] { \
Kasper Lund . resolved
```suggestion
  if (v8_flags.riscv_debug) [[unlikely]] {                                     \
```
Open in Gerrit

Related details

Attention is currently required from:
  • Toon Verwaest
  • Yahan Lu (LuYahan)
Submit Requirements:
  • requirement is not satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: v8/v8
Gerrit-Branch: main
Gerrit-Change-Id: I30275eb1c7f3b7f70ae981122e2c73980805dc9d
Gerrit-Change-Number: 6979424
Gerrit-PatchSet: 5
Gerrit-Owner: Yahan Lu (LuYahan) <ya...@iscas.ac.cn>
Gerrit-Reviewer: Ji Qiu <qi...@iscas.ac.cn>
Gerrit-Reviewer: Kasper Lund <kas...@rivosinc.com>
Gerrit-Reviewer: Toon Verwaest <verw...@chromium.org>
Gerrit-Reviewer: Yahan Lu (LuYahan) <ya...@iscas.ac.cn>
Gerrit-Attention: Toon Verwaest <verw...@chromium.org>
Gerrit-Attention: Yahan Lu (LuYahan) <ya...@iscas.ac.cn>
Gerrit-Comment-Date: Thu, 25 Sep 2025 12:29:13 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
unsatisfied_requirement
satisfied_requirement
open
diffy

Jakob Kummerow (Gerrit)

unread,
Sep 25, 2025, 2:28:41 PM (2 days ago) Sep 25
to Yahan Lu (LuYahan), Jakob Kummerow, Kasper Lund, Ji Qiu, V8 LUCI CQ, Toon Verwaest, v8-flag...@chromium.org, v8-re...@googlegroups.com
Attention needed from Toon Verwaest and Yahan Lu (LuYahan)

Jakob Kummerow voted and added 1 comment

Votes added by Jakob Kummerow

Code-Review+1

1 comment

Patchset-level comments
File-level comment, Patchset 7 (Latest):
Jakob Kummerow . resolved

`flag-definitions.h` LGTM; didn't look at the riscv changes.

Open in Gerrit

Related details

Attention is currently required from:
  • Toon Verwaest
  • Yahan Lu (LuYahan)
Submit Requirements:
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: v8/v8
Gerrit-Branch: main
Gerrit-Change-Id: I30275eb1c7f3b7f70ae981122e2c73980805dc9d
Gerrit-Change-Number: 6979424
Gerrit-PatchSet: 7
Gerrit-Owner: Yahan Lu (LuYahan) <ya...@iscas.ac.cn>
Gerrit-Reviewer: Jakob Kummerow <jkum...@chromium.org>
Gerrit-Reviewer: Ji Qiu <qi...@iscas.ac.cn>
Gerrit-Reviewer: Kasper Lund <kas...@rivosinc.com>
Gerrit-Reviewer: Toon Verwaest <verw...@chromium.org>
Gerrit-Reviewer: Yahan Lu (LuYahan) <ya...@iscas.ac.cn>
Gerrit-Attention: Toon Verwaest <verw...@chromium.org>
Gerrit-Attention: Yahan Lu (LuYahan) <ya...@iscas.ac.cn>
Gerrit-Comment-Date: Thu, 25 Sep 2025 18:28:35 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

Yahan Lu (LuYahan) (Gerrit)

unread,
Sep 25, 2025, 10:08:01 PM (2 days ago) Sep 25
to Jakob Kummerow, Kasper Lund, Ji Qiu, V8 LUCI CQ, Toon Verwaest, v8-flag...@chromium.org, v8-re...@googlegroups.com
Attention needed from Toon Verwaest

Yahan Lu (LuYahan) voted

Code-Review+1
Commit-Queue+2
Open in Gerrit

Related details

Attention is currently required from:
  • Toon Verwaest
Submit Requirements:
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: v8/v8
Gerrit-Branch: main
Gerrit-Change-Id: I30275eb1c7f3b7f70ae981122e2c73980805dc9d
Gerrit-Change-Number: 6979424
Gerrit-PatchSet: 7
Gerrit-Owner: Yahan Lu (LuYahan) <ya...@iscas.ac.cn>
Gerrit-Reviewer: Jakob Kummerow <jkum...@chromium.org>
Gerrit-Reviewer: Ji Qiu <qi...@iscas.ac.cn>
Gerrit-Reviewer: Kasper Lund <kas...@rivosinc.com>
Gerrit-Reviewer: Toon Verwaest <verw...@chromium.org>
Gerrit-Reviewer: Yahan Lu (LuYahan) <ya...@iscas.ac.cn>
Gerrit-Attention: Toon Verwaest <verw...@chromium.org>
Gerrit-Comment-Date: Fri, 26 Sep 2025 02:07:57 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

Yahan Lu (LuYahan) (Gerrit)

unread,
Sep 25, 2025, 10:08:10 PM (2 days ago) Sep 25
to Jakob Kummerow, Kasper Lund, Ji Qiu, V8 LUCI CQ, Toon Verwaest, v8-flag...@chromium.org, v8-re...@googlegroups.com
Attention needed from Toon Verwaest

Yahan Lu (LuYahan) voted Code-Review+0

Code-Review+0
Open in Gerrit

Related details

Attention is currently required from:
  • Toon Verwaest
Submit Requirements:
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: v8/v8
Gerrit-Branch: main
Gerrit-Change-Id: I30275eb1c7f3b7f70ae981122e2c73980805dc9d
Gerrit-Change-Number: 6979424
Gerrit-PatchSet: 7
Gerrit-Owner: Yahan Lu (LuYahan) <ya...@iscas.ac.cn>
Gerrit-Reviewer: Jakob Kummerow <jkum...@chromium.org>
Gerrit-Reviewer: Ji Qiu <qi...@iscas.ac.cn>
Gerrit-Reviewer: Kasper Lund <kas...@rivosinc.com>
Gerrit-Reviewer: Toon Verwaest <verw...@chromium.org>
Gerrit-Reviewer: Yahan Lu (LuYahan) <ya...@iscas.ac.cn>
Gerrit-Attention: Toon Verwaest <verw...@chromium.org>
Gerrit-Comment-Date: Fri, 26 Sep 2025 02:08:05 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

V8 LUCI CQ (Gerrit)

unread,
Sep 25, 2025, 10:46:48 PM (2 days ago) Sep 25
to Yahan Lu (LuYahan), Jakob Kummerow, Kasper Lund, Ji Qiu, Toon Verwaest, v8-flag...@chromium.org, v8-re...@googlegroups.com

V8 LUCI CQ submitted the change

Change information

Commit message:
[riscv] Refactor the DEBUG_RISCV to support dumping log to a file.
Change-Id: I30275eb1c7f3b7f70ae981122e2c73980805dc9d
Commit-Queue: Yahan Lu (LuYahan) <ya...@iscas.ac.cn>
Reviewed-by: Ji Qiu <qi...@iscas.ac.cn>
Reviewed-by: Kasper Lund <kas...@rivosinc.com>
Reviewed-by: Jakob Kummerow <jkum...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#102775}
Files:
  • M src/codegen/riscv/assembler-riscv.h
  • M src/codegen/riscv/base-assembler-riscv.h
  • M src/flags/flag-definitions.h
Change size: S
Delta: 3 files changed, 28 insertions(+), 10 deletions(-)
Branch: refs/heads/main
Submit Requirements:
  • requirement satisfiedCode-Review: +1 by Ji Qiu, +0 by Yahan Lu (LuYahan), +1 by Kasper Lund, +1 by Jakob Kummerow
Open in Gerrit
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: merged
Gerrit-Project: v8/v8
Gerrit-Branch: main
Gerrit-Change-Id: I30275eb1c7f3b7f70ae981122e2c73980805dc9d
Gerrit-Change-Number: 6979424
Gerrit-PatchSet: 8
Gerrit-Owner: Yahan Lu (LuYahan) <ya...@iscas.ac.cn>
Gerrit-Reviewer: Jakob Kummerow <jkum...@chromium.org>
Gerrit-Reviewer: Ji Qiu <qi...@iscas.ac.cn>
Gerrit-Reviewer: Kasper Lund <kas...@rivosinc.com>
Gerrit-Reviewer: Toon Verwaest <verw...@chromium.org>
open
diffy
satisfied_requirement
Reply all
Reply to author
Forward
0 new messages