[Wasm interpreter] Improve handling of const values [v8/v8 : main]
0 views
Skip to first unread message
Emmanuel Romero Ruiz (Gerrit)
Feb 2, 2026, 6:19:28 PM (2 days ago) Feb 2
to Paolo Severini, V8 LUCI CQ, Daniel Lehmann, v8-re...@googlegroups.com, was...@google.com
Attention needed from Daniel Lehmann and Paolo Severini
Emmanuel Romero Ruiz added 1 comment![]( "Open in Gerrit")
Patchset-level comments
Related details
Attention is currently required from:
- Daniel Lehmann
- Paolo Severini
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Daniel Lehmann (Gerrit)
Feb 2, 2026, 6:37:23 PM (2 days ago) Feb 2
to Paolo Severini, V8 LUCI CQ, Emmanuel Romero Ruiz, v8-re...@googlegroups.com, was...@google.com
Attention needed from Paolo Severini
Daniel Lehmann voted and added 1 comment![]( "Open in Gerrit")
Votes added by Daniel Lehmann
| Code-Review | +1 |
1 comment
Patchset-level comments
Daniel Lehmann . resolved
Rubber stamp as usual for interpreter-only changes. (I would assume the infra failures are unrelated?)
Related details
Attention is currently required from:
- Paolo Severini
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Paolo Severini (Gerrit)
Feb 3, 2026, 10:29:57 AM (18 hours ago) Feb 3
to Daniel Lehmann, V8 LUCI CQ, Emmanuel Romero Ruiz, v8-re...@googlegroups.com, was...@google.com
Paolo Severini added 1 comment![]( "Open in Gerrit")
Patchset-level comments
Daniel Lehmann . resolved
Rubber stamp as usual for interpreter-only changes. (I would assume the infra failures are unrelated?)
Paolo Severini
Thank you. Yes, the infra failures are certainly unrelated.
Related details
Attention set is empty
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Paolo Severini (Gerrit)
Feb 3, 2026, 10:31:41 AM (18 hours ago) Feb 3
to Daniel Lehmann, V8 LUCI CQ, Emmanuel Romero Ruiz, v8-re...@googlegroups.com, was...@google.com
Paolo Severini voted Commit-Queue+2![]( "Open in Gerrit")
| Commit-Queue | +2 |
Related details
Attention set is empty
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
V8 LUCI CQ (Gerrit)
Feb 3, 2026, 11:45:38 AM (17 hours ago) Feb 3
to Paolo Severini, Daniel Lehmann, Emmanuel Romero Ruiz, v8-re...@googlegroups.com, was...@google.com
V8 LUCI CQ submitted the change![]( "Open in Gerrit")
Unreviewed changes
1 is the latest approved patch-set.
No files were changed between the latest approved patch-set and the submitted one.
Change information
Commit message:
[Wasm interpreter] Improve handling of const values
Reduce the size of stack frames in the Wasm interpreter by
deduplicating const slots.
Bug: 338326645
Change-Id: I58b18b4d9776f09ff3ef4f8269e50c59c106a0bc
Commit-Queue: Paolo Severini <paol...@microsoft.com>
Reviewed-by: Daniel Lehmann <dleh...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#105067}
Files:
- M src/wasm/interpreter/wasm-interpreter.cc
- M src/wasm/interpreter/wasm-interpreter.h
Change size: M
Delta: 2 files changed, 136 insertions(+), 58 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Daniel Lehmann
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages