[heap] Add GC callback flags to CollectAllAvailableGarbage [v8/v8 : main]
0 views
Skip to first unread message
Dominik Inführ (Gerrit)
Sep 26, 2025, 5:01:21 AM (yesterday) Sep 26
to Michael Lippautz, V8 LUCI CQ, Hannes Payer, cbruni...@chromium.org, mlippau...@chromium.org, v8-re...@googlegroups.com
Attention needed from Michael Lippautz
Dominik Inführ voted and added 1 comment![]( "Open in Gerrit")
Votes added by Dominik Inführ
| Commit-Queue | +1 |
1 comment
Patchset-level comments
Related details
Attention is currently required from:
- Michael Lippautz
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Michael Lippautz (Gerrit)
Sep 26, 2025, 5:44:56 AM (yesterday) Sep 26
to Dominik Inführ, V8 LUCI CQ, Hannes Payer, cbruni...@chromium.org, mlippau...@chromium.org, v8-re...@googlegroups.com
Attention needed from Dominik Inführ
Michael Lippautz voted and added 1 comment![]( "Open in Gerrit")
Votes added by Michael Lippautz
| Code-Review | +1 |
1 comment
Patchset-level comments
Related details
Attention is currently required from:
- Dominik Inführ
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Dominik Inführ (Gerrit)
Sep 26, 2025, 5:47:27 AM (yesterday) Sep 26
to Michael Lippautz, V8 LUCI CQ, Hannes Payer, cbruni...@chromium.org, mlippau...@chromium.org, v8-re...@googlegroups.com
Attention needed from Dominik Inführ
Dominik Inführ voted and added 1 comment![]( "Open in Gerrit")
Votes added by Dominik Inführ
| Commit-Queue | +2 |
1 comment
Patchset-level comments
Dominik Inführ . resolved
Thanks for the review!
Related details
Attention is currently required from:
- Dominik Inführ
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
V8 LUCI CQ (Gerrit)
Sep 26, 2025, 6:17:26 AM (yesterday) Sep 26
to Dominik Inführ, Michael Lippautz, Hannes Payer, cbruni...@chromium.org, mlippau...@chromium.org, v8-re...@googlegroups.com
V8 LUCI CQ submitted the change![]( "Open in Gerrit")
Change information
Commit message:
[heap] Add GC callback flags to CollectAllAvailableGarbage
Set kGCCallbackFlagCollectAllAvailableGarbage on GC callbacks
in CollectAllAvailableGarbage. In addition also set the new
flag kGCCallbackFlagLastResort when that GC is a last resort GC.
Bug: 447352454
Change-Id: Ic0611cb33d2becff59847421856a3be9f6d31db4
Commit-Queue: Dominik Inführ <dinf...@chromium.org>
Reviewed-by: Michael Lippautz <mlip...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#102785}
Files:
- M include/v8-callbacks.h
- M src/heap/heap.cc
- M test/unittests/api/gc-callbacks-unittest.cc
Change size: M
Delta: 3 files changed, 87 insertions(+), 1 deletion(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Michael Lippautz
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Manos Koukoutos (Gerrit)
Sep 26, 2025, 7:24:04 AM (yesterday) Sep 26
to V8 LUCI CQ, Dominik Inführ, Michael Lippautz, Hannes Payer, cbruni...@chromium.org, mlippau...@chromium.org, v8-re...@googlegroups.com
Manos Koukoutos has created a revert of this change![]( "Open in Gerrit")
Related details
Attention set is empty
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages