[heap] Pass WriteBarrierMode in RemoveUnregisterToken [v8/v8 : main]
0 views
Skip to first unread message
Omer Katz (Gerrit)
4:54 AM (6 hours ago) 4:54 AM
to Dominik Inführ, V8 LUCI CQ, v8-re...@googlegroups.com
Attention needed from Dominik Inführ
Omer Katz voted and added 1 comment![]( "Open in Gerrit")
Votes added by Omer Katz
| Code-Review | +1 |
Related details
Attention is currently required from:
- Dominik Inführ
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Dominik Inführ (Gerrit)
4:54 AM (6 hours ago) 4:54 AM
to Omer Katz, V8 LUCI CQ, v8-re...@googlegroups.com
Attention needed from Dominik Inführ
Dominik Inführ voted and added 1 comment![]( "Open in Gerrit")
Votes added by Dominik Inführ
| Commit-Queue | +2 |
1 comment
Patchset-level comments
Dominik Inführ . resolved
Thanks for the review!
Related details
Attention is currently required from:
- Dominik Inführ
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
V8 LUCI CQ (Gerrit)
5:10 AM (6 hours ago) 5:10 AM
to Dominik Inführ, Omer Katz, v8-re...@googlegroups.com
V8 LUCI CQ submitted the change![]( "Open in Gerrit")
Change information
Commit message:
[heap] Pass WriteBarrierMode in RemoveUnregisterToken
We were already passing along that write barrier mode in most stores
of that method but we apparently missed one case.
Bug: 463528049
Change-Id: I271df88bb826c192eb6dd74ae104e58382fbf166
Reviewed-by: Omer Katz <omer...@chromium.org>
Commit-Queue: Dominik Inführ <dinf...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#104659}
Files:
- M src/objects/dictionary-inl.h
- M src/objects/dictionary.h
- M src/objects/js-weak-refs-inl.h
Change size: S
Delta: 3 files changed, 8 insertions(+), 5 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Omer Katz
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages