[wasm-custom-desc] Fix configureAll fast path [v8/v8 : main]
0 views
Skip to first unread message
Jakob Kummerow (Gerrit)
Mar 9, 2026, 5:11:09 PMMar 9
to Jakob Kummerow, Clemens Backes, v8-re...@googlegroups.com, was...@google.com
Attention needed from Clemens Backes
Jakob Kummerow voted and added 2 comments![]( "Open in Gerrit")
Votes added by Jakob Kummerow
| Commit-Queue | +1 |
2 comments
Patchset-level comments
File src/wasm/baseline/liftoff-assembler.cc
Line 185, Patchset 1 (Latest):
DCHECK_LE(target_height, cache_state_.stack_height());Jakob Kummerow . resolved
Hoping that this might catch future occurrences of the same confusion.
Related details
Attention is currently required from:
- Clemens Backes
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Clemens Backes (Gerrit)
Mar 10, 2026, 8:31:31 AMMar 10
to Jakob Kummerow, V8 LUCI CQ, v8-re...@googlegroups.com, was...@google.com
Attention needed from Jakob Kummerow
Clemens Backes voted Code-Review+1![]( "Open in Gerrit")
Attention is currently required from:
- Jakob Kummerow
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Jakob Kummerow (Gerrit)
Mar 10, 2026, 8:31:42 AMMar 10
to Jakob Kummerow, Clemens Backes, V8 LUCI CQ, v8-re...@googlegroups.com, was...@google.com
Jakob Kummerow voted Commit-Queue+2![]( "Open in Gerrit")
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
V8 LUCI CQ (Gerrit)
Mar 10, 2026, 8:35:21 AMMar 10
to Jakob Kummerow, Clemens Backes, v8-re...@googlegroups.com, was...@google.com
V8 LUCI CQ submitted the change![]( "Open in Gerrit")
Change information
Commit message:
[wasm-custom-desc] Fix configureAll fast path
For incorrect signatures of the imported function, Liftoff could
get confused about its stack state.
Fixed: 489109716
Change-Id: I1909b158dc5a693f0a06065aeca5fe0f0fbd6de3
Reviewed-by: Clemens Backes <clem...@chromium.org>
Commit-Queue: Jakob Kummerow <jkum...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#105700}
Files:
- M src/wasm/baseline/liftoff-assembler.cc
- M src/wasm/baseline/liftoff-compiler.cc
- A test/mjsunit/regress/wasm/regress-489109716.js
Change size: M
Delta: 3 files changed, 87 insertions(+), 6 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Clemens Backes
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages