[heap] Fix wrong page-related casts [v8/v8 : main]
0 views
Skip to first unread message
Michael Lippautz (Gerrit)
8:41 AM (13 hours ago) 8:41 AM
to Dominik Inführ, Hannes Payer, mlippau...@chromium.org, v8-re...@googlegroups.com
Attention needed from Dominik Inführ
Michael Lippautz voted and added 3 comments![]( "Open in Gerrit")
Votes added by Michael Lippautz
| Commit-Queue | +1 |
3 comments
Patchset-level comments
File-level comment, Patchset 1 (Latest):
Michael Lippautz . resolved
Just the cast fixes and a few stylistic improvements
File src/heap/base-page.h
Line 48, Patchset 1 (Latest):
bool IsReadOnlyPage() const { return IsReadOnlyPageField::decode(flags_); }Michael Lippautz . resolved
Merely moving the methods to the top as they are used to check the concrete types of the BasePage.
File src/heap/memory-allocator.cc
Line 278, Patchset 1 (Latest):
void MemoryAllocator::UnregisterMemoryChunk(BasePage* base_page) {Michael Lippautz . resolved
This is merely a rename.
Related details
Attention is currently required from:
- Dominik Inführ
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Dominik Inführ (Gerrit)
8:51 AM (13 hours ago) 8:51 AM
to Michael Lippautz, V8 LUCI CQ, Hannes Payer, mlippau...@chromium.org, v8-re...@googlegroups.com
Attention needed from Michael Lippautz
Dominik Inführ voted and added 2 comments![]( "Open in Gerrit")
Votes added by Dominik Inführ
| Code-Review | +1 |
2 comments
Patchset-level comments
Dominik Inführ . resolved
Thanks, LGTM
File src/heap/memory-allocator.cc
Line 301, Patchset 1 (Latest):
reinterpret_cast<MutablePage*>(base_page)->set_is_unregistered();Dominik Inführ . unresolved
Nit: Should we use a DCHECK here?
Related details
Attention is currently required from:
- Michael Lippautz
Submit Requirements:
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Michael Lippautz (Gerrit)
8:52 AM (13 hours ago) 8:52 AM
to Dominik Inführ, V8 LUCI CQ, Hannes Payer, mlippau...@chromium.org, v8-re...@googlegroups.com
Michael Lippautz voted and added 1 comment![]( "Open in Gerrit")
Votes added by Michael Lippautz
| Commit-Queue | +2 |
1 comment
File src/heap/memory-allocator.cc
Line 301, Patchset 1 (Latest):
reinterpret_cast<MutablePage*>(base_page)->set_is_unregistered();Dominik Inführ . resolved
Nit: Should we use a DCHECK here?
Michael Lippautz
For the cast? I think with the next CL we make this (and all other casts) proper SBXCHECK() anyways.
Related details
Attention set is empty
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Michael Lippautz (Gerrit)
9:11 AM (13 hours ago) 9:11 AM
to Dominik Inführ, V8 LUCI CQ, Hannes Payer, mlippau...@chromium.org, v8-re...@googlegroups.com
Michael Lippautz removed a vote from this change![]( "Open in Gerrit")
Removed Commit-Queue+2 by Michael Lippautz <mlip...@chromium.org>
Related details
Attention set is empty
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Dominik Inführ (Gerrit)
9:22 AM (13 hours ago) 9:22 AM
to Michael Lippautz, V8 LUCI CQ, Hannes Payer, mlippau...@chromium.org, v8-re...@googlegroups.com
Attention needed from Michael Lippautz
Dominik Inführ voted and added 1 comment![]( "Open in Gerrit")
Votes added by Dominik Inführ
| Code-Review | +1 |
1 comment
Patchset-level comments
Related details
Attention is currently required from:
- Michael Lippautz
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Michael Lippautz (Gerrit)
9:23 AM (13 hours ago) 9:23 AM
to Dominik Inführ, V8 LUCI CQ, Hannes Payer, mlippau...@chromium.org, v8-re...@googlegroups.com
Michael Lippautz voted Commit-Queue+2![]( "Open in Gerrit")
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
V8 LUCI CQ (Gerrit)
10:24 AM (12 hours ago) 10:24 AM
to Michael Lippautz, Dominik Inführ, Hannes Payer, mlippau...@chromium.org, v8-re...@googlegroups.com
V8 LUCI CQ submitted the change![]( "Open in Gerrit")
Change information
Commit message:
[heap] Fix wrong page-related casts
Bug: 474140208
Change-Id: Ie90916b541f230e32cc3a62a3331f944d374862f
Reviewed-by: Dominik Inführ <dinf...@chromium.org>
Commit-Queue: Michael Lippautz <mlip...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#104643}
Files:
- M src/heap/base-page-inl.h
- M src/heap/base-page.h
- M src/heap/heap-allocator.cc
- M src/heap/heap.cc
- M src/heap/large-spaces.cc
- M src/heap/memory-allocator.cc
- M src/heap/mutable-page-inl.h
- M src/heap/mutable-page.h
- M src/heap/paged-spaces-inl.h
- M src/roots/roots-inl.h
- M test/cctest/heap/test-heap.cc
Change size: M
Delta: 11 files changed, 53 insertions(+), 35 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Dominik Inführ
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages