[maglev] truncate passed arguments length to known js functions when they are unreachable [v8/v8 : main]

0 views
Skip to first unread message

Toon Verwaest (Gerrit)

unread,
Oct 22, 2025, 8:12:29 AM (yesterday) Oct 22
to Dan Carney, V8 LUCI CQ, leszek...@chromium.org, v8-re...@googlegroups.com, verwaes...@chromium.org, victorgo...@chromium.org
Attention needed from Dan Carney

Toon Verwaest voted Code-Review+1

Code-Review+1
Open in Gerrit

Related details

Attention is currently required from:
  • Dan Carney
Submit Requirements:
  • requirement satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: v8/v8
Gerrit-Branch: main
Gerrit-Change-Id: I151825fbda0596d12e397fadf80a0fe5a244fa26
Gerrit-Change-Number: 7053222
Gerrit-PatchSet: 14
Gerrit-Owner: Dan Carney <dca...@chromium.org>
Gerrit-Reviewer: Dan Carney <dca...@chromium.org>
Gerrit-Reviewer: Toon Verwaest <verw...@chromium.org>
Gerrit-Attention: Dan Carney <dca...@chromium.org>
Gerrit-Comment-Date: Wed, 22 Oct 2025 12:12:23 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

Victor Gomes (Gerrit)

unread,
Oct 22, 2025, 10:32:46 AM (yesterday) Oct 22
to Dan Carney, Toon Verwaest, V8 LUCI CQ, leszek...@chromium.org, v8-re...@googlegroups.com, verwaes...@chromium.org, victorgo...@chromium.org
Attention needed from Dan Carney

Victor Gomes added 1 comment

File test/unittests/maglev/maglev-graph-builder-unittest.cc
Line 1, Patchset 14 (Latest):// Copyright 2023 the V8 project authors. All rights reserved.
Victor Gomes . unresolved

Nit: 2025

Open in Gerrit

Related details

Attention is currently required from:
  • Dan Carney
Submit Requirements:
    • requirement satisfiedCode-Owners
    • requirement is not satisfiedCode-Review
    • requirement is not satisfiedNo-Unresolved-Comments
    • requirement is not satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: v8/v8
    Gerrit-Branch: main
    Gerrit-Change-Id: I151825fbda0596d12e397fadf80a0fe5a244fa26
    Gerrit-Change-Number: 7053222
    Gerrit-PatchSet: 14
    Gerrit-Owner: Dan Carney <dca...@chromium.org>
    Gerrit-Reviewer: Dan Carney <dca...@chromium.org>
    Gerrit-Reviewer: Toon Verwaest <verw...@chromium.org>
    Gerrit-CC: Victor Gomes <victo...@chromium.org>
    Gerrit-Attention: Dan Carney <dca...@chromium.org>
    Gerrit-Comment-Date: Wed, 22 Oct 2025 14:32:40 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: No
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy

    Dan Carney (Gerrit)

    unread,
    Oct 22, 2025, 2:24:56 PM (21 hours ago) Oct 22
    to Victor Gomes, Toon Verwaest, V8 LUCI CQ, leszek...@chromium.org, v8-re...@googlegroups.com, verwaes...@chromium.org, victorgo...@chromium.org
    Attention needed from Toon Verwaest and Victor Gomes

    Dan Carney added 1 comment

    File test/unittests/maglev/maglev-graph-builder-unittest.cc
    Line 1, Patchset 14:// Copyright 2023 the V8 project authors. All rights reserved.
    Victor Gomes . resolved

    Nit: 2025

    Dan Carney

    Whoops

    Open in Gerrit

    Related details

    Attention is currently required from:
    • Toon Verwaest
    • Victor Gomes
    Submit Requirements:
      • requirement satisfiedCode-Owners
      • requirement is not satisfiedCode-Review
      • requirement is not satisfiedReview-Enforcement
      Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
      Gerrit-MessageType: comment
      Gerrit-Project: v8/v8
      Gerrit-Branch: main
      Gerrit-Change-Id: I151825fbda0596d12e397fadf80a0fe5a244fa26
      Gerrit-Change-Number: 7053222
      Gerrit-PatchSet: 15
      Gerrit-Owner: Dan Carney <dca...@chromium.org>
      Gerrit-Reviewer: Dan Carney <dca...@chromium.org>
      Gerrit-Reviewer: Toon Verwaest <verw...@chromium.org>
      Gerrit-CC: Victor Gomes <victo...@chromium.org>
      Gerrit-Attention: Toon Verwaest <verw...@chromium.org>
      Gerrit-Attention: Victor Gomes <victo...@chromium.org>
      Gerrit-Comment-Date: Wed, 22 Oct 2025 18:24:52 +0000
      Gerrit-HasComments: Yes
      Gerrit-Has-Labels: No
      Comment-In-Reply-To: Victor Gomes <victo...@chromium.org>
      satisfied_requirement
      unsatisfied_requirement
      open
      diffy
      Reply all
      Reply to author
      Forward
      0 new messages