[maglev] Remove uses for identity-like and conversion nodes in deopt frames [v8/v8 : main]
0 views
Skip to first unread message
Victor Gomes (Gerrit)
Sep 4, 2025, 11:07:30 AM (3 days ago) Sep 4
to Darius Mercadier, chrom...@appspot.gserviceaccount.com, V8 LUCI CQ, leszek...@chromium.org, v8-re...@googlegroups.com, verwaes...@chromium.org, victorgo...@chromium.org
Attention needed from Darius Mercadier
Victor Gomes voted and added 1 comment![]( "Open in Gerrit")
Votes added by Victor Gomes
| Auto-Submit | +1 |
| Commit-Queue | +1 |
1 comment
Patchset-level comments
File-level comment, Patchset 3 (Latest):
Victor Gomes . resolved
This is to ensure we visit all frames (even those removed from the graph) and unwrap ReturnedValue uses. Needed for a follow up improving phi representation in crypto-sha1 loop.
PTAL!
Related details
Attention is currently required from:
- Darius Mercadier
Submit Requirements:
Code-Owners
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Darius Mercadier (Gerrit)
Sep 5, 2025, 3:33:42 AM (2 days ago) Sep 5
to Victor Gomes, chrom...@appspot.gserviceaccount.com, V8 LUCI CQ, leszek...@chromium.org, v8-re...@googlegroups.com, verwaes...@chromium.org, victorgo...@chromium.org
Attention needed from Victor Gomes
Darius Mercadier voted and added 1 comment![]( "Open in Gerrit")
Votes added by Darius Mercadier
| Code-Review | +1 |
| Commit-Queue | +2 |
1 comment
Patchset-level comments
Related details
Attention is currently required from:
- Victor Gomes
Submit Requirements:
Code-Owners
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
V8 LUCI CQ (Gerrit)
Sep 5, 2025, 3:35:15 AM (2 days ago) Sep 5
to Victor Gomes, Darius Mercadier, chrom...@appspot.gserviceaccount.com, leszek...@chromium.org, v8-re...@googlegroups.com, verwaes...@chromium.org, victorgo...@chromium.org
V8 LUCI CQ submitted the change![]( "Open in Gerrit")
Change information
Commit message:
[maglev] Remove uses for identity-like and conversion nodes in deopt frames
Since top frames are shared between deopt infos, we save them
in the Maglev graph for quick traversal.
Conversion nodes should not end up in deopt frames, but this
can happen due to non-eager inlining emitting returned value.
And identity unwrapping.
Bug: 431933185
Change-Id: I68cb77be2150955f259f19afa3ee6190d5bd5174
Auto-Submit: Victor Gomes <victo...@chromium.org>
Reviewed-by: Darius Mercadier <dmerc...@chromium.org>
Commit-Queue: Darius Mercadier <dmerc...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#102262}
Files:
- M src/maglev/maglev-deopt-frame-visitor.h
- M src/maglev/maglev-graph.h
- M src/maglev/maglev-inlining.cc
- M src/maglev/maglev-inlining.h
- M src/maglev/maglev-ir-inl.h
- M src/maglev/maglev-ir.h
- M src/maglev/maglev-post-hoc-optimizations-processors.h
- M src/maglev/maglev-reducer-inl.h
Change size: M
Delta: 8 files changed, 52 insertions(+), 58 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Darius Mercadier
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages