[turbolev] Support HoleyFloat64Constant in AddVirtualObjectNestedValue [v8/v8 : main]
0 views
Skip to first unread message
Marco Vitale (Gerrit)
Aug 14, 2026, 5:33:18 AM (yesterday) Aug 14
to Victor Gomes, v8-s...@luci-project-accounts.iam.gserviceaccount.com, dmercadi...@chromium.org, v8-re...@googlegroups.com
Attention needed from Victor Gomes
Marco Vitale voted and added 1 comment![]( "Open in Gerrit")
Votes added by Marco Vitale
| Auto-Submit | +1 |
1 comment
Patchset-level comments
Related details
Attention is currently required from:
- Victor Gomes
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Victor Gomes (Gerrit)
Aug 14, 2026, 7:26:15 AM (yesterday) Aug 14
to Marco Vitale, v8-s...@luci-project-accounts.iam.gserviceaccount.com, dmercadi...@chromium.org, v8-re...@googlegroups.com
Attention needed from Marco Vitale
Victor Gomes voted![]( "Open in Gerrit")
Attention is currently required from:
- Marco Vitale
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Victor Gomes (Gerrit)
Aug 14, 2026, 7:26:21 AM (yesterday) Aug 14
to Marco Vitale, v8-s...@luci-project-accounts.iam.gserviceaccount.com, dmercadi...@chromium.org, v8-re...@googlegroups.com
Attention needed from Marco Vitale
Victor Gomes added 1 comment![]( "Open in Gerrit")
Patchset-level comments
Victor Gomes . resolved
Thanks!
Related details
Attention is currently required from:
- Marco Vitale
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
v8-scoped@luci-project-accounts.iam.gserviceaccount.com (Gerrit)
Aug 14, 2026, 7:28:46 AM (yesterday) Aug 14
to Marco Vitale, Victor Gomes, dmercadi...@chromium.org, v8-re...@googlegroups.com
v8-s...@luci-project-accounts.iam.gserviceaccount.com submitted the change![]( "Open in Gerrit")
Change information
Commit message:
[turbolev] Support HoleyFloat64Constant in AddVirtualObjectNestedValue
AddVirtualObjectNestedValue handles constant nodes when serializing
dematerialized objects into frame state data for Turboshaft deopts.
While IsConstantNode is true for HoleyFloat64Constant, the opcode switch
was missing a case for it, falling through to UNREACHABLE().
Fixed: 546127404
Change-Id: I723f572fa6964407481c65bcfe90eded3f35817e
Reviewed-by: Victor Gomes <victo...@chromium.org>
Auto-Submit: Marco Vitale <mrc...@chromium.org>
Commit-Queue: Victor Gomes <victo...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#109257}
Files:
- M src/compiler/turboshaft/turbolev-graph-builder.cc
Change size: XS
Delta: 1 file changed, 5 insertions(+), 2 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Victor Gomes
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages