[sandbox][wasm] Un-expose dispatch_table_for_imports [v8/v8 : main]

0 views

Skip to first unread message

Jakob Kummerow (Gerrit)

unread,

Oct 24, 2025, 8:44:35 AM (yesterday) Oct 24

to Jakob Kummerow, Clemens Backes, v8-re...@googlegroups.com, was...@google.com

Attention needed from Clemens Backes

Jakob Kummerow voted and added 2 comments

Votes added by Jakob Kummerow

Auto-Submit	+1
Commit-Queue	+1

2 comments

Patchset-level comments

File-level comment, Patchset 1 (Latest):

Jakob Kummerow . resolved

As discussed. PTAL.

File test/mjsunit/sandbox/regress/regress-446113730.js

Line 38, Patchset 1 (Latest):gc();

Jakob Kummerow . resolved

Drive-by: making this test faster and more concise, keeping it in sync with the newly added test.

Open in Gerrit

Related details

Attention is currently required from:

Clemens Backes

Submit Requirements:

Code-Owners
Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Clemens Backes (Gerrit)

unread,

Oct 24, 2025, 10:23:05 AM (yesterday) Oct 24

to Jakob Kummerow, V8 LUCI CQ, v8-re...@googlegroups.com, was...@google.com

Attention needed from Jakob Kummerow

Clemens Backes voted and added 2 comments

Votes added by Clemens Backes

Code-Review

2 comments

Patchset-level comments

File-level comment, Patchset 2 (Latest):

Clemens Backes . resolved

LGTM, but doesn't LGTtheGC.

File src/wasm/wasm-objects.cc

Line 1710, Patchset 2 (Latest): // Make sure the dispatch table for imports is in accessible from regular

Clemens Backes . unresolved

Isn't that one word?