[runtime] Fixes in RunSingleMicrotask implementation [v8/v8 : main]
0 views
Skip to first unread message
Igor Sheludko (Gerrit)
Feb 3, 2026, 5:47:19 AM (23 hours ago) Feb 3
to Patrick Thier, v8-re...@googlegroups.com
Attention needed from Patrick Thier
Igor Sheludko voted and added 2 comments![]( "Open in Gerrit")
Votes added by Igor Sheludko
| Auto-Submit | +1 |
| Commit-Queue | +1 |
2 comments
File src/builtins/builtins-microtask-queue-gen.cc
Line 220, Patchset 1 (Parent):
ScopedExceptionHandler handler(this, &if_exception, &var_exception);Igor Sheludko . unresolved
Here we could have jumped to if_exception and fail a CSA_DCHECK at line 464.
Line 358, Patchset 1 (Parent):
CallRuntime(Runtime::kReportMessageFromMicrotask, GetCurrentContext(),Igor Sheludko . unresolved
Lazy deopt of fast Api call clears `Isolate::context()` and then we try to use NoContext context.
Related details
Attention is currently required from:
- Patrick Thier
Submit Requirements:
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Patrick Thier (Gerrit)
Feb 3, 2026, 7:37:50 AM (21 hours ago) Feb 3
to Igor Sheludko, V8 LUCI CQ, v8-re...@googlegroups.com
Attention needed from Igor Sheludko
Patrick Thier voted and added 3 comments![]( "Open in Gerrit")
Votes added by Patrick Thier
| Code-Review | +1 |
3 comments
Patchset-level comments
File src/builtins/builtins-microtask-queue-gen.cc
Line 220, Patchset 1 (Parent):
ScopedExceptionHandler handler(this, &if_exception, &var_exception);Igor Sheludko . resolved
Here we could have jumped to if_exception and fail a CSA_DCHECK at line 464.
Patrick Thier
Acknowledged
Line 358, Patchset 1 (Parent):
CallRuntime(Runtime::kReportMessageFromMicrotask, GetCurrentContext(),Igor Sheludko . resolved
Lazy deopt of fast Api call clears `Isolate::context()` and then we try to use NoContext context.
Attention is currently required from:
- Igor Sheludko
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Igor Sheludko (Gerrit)
Feb 3, 2026, 7:43:27 AM (21 hours ago) Feb 3
to Patrick Thier, V8 LUCI CQ, v8-re...@googlegroups.com
Igor Sheludko voted Commit-Queue+2![]( "Open in Gerrit")
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
V8 LUCI CQ (Gerrit)
Feb 3, 2026, 8:59:46 AM (19 hours ago) Feb 3
to Igor Sheludko, Patrick Thier, v8-re...@googlegroups.com
V8 LUCI CQ submitted the change![]( "Open in Gerrit")
Change information
Commit message:
[runtime] Fixes in RunSingleMicrotask implementation
In particular:
- don't call RewindEnteredContext(..) for C++ microtasks since to
contexts were pushed to the stack, this fixes CSA_DCHECK(0 < size)
failure in RewindEnteredContext(..),
- make sure that we use microtask's native context for rendering
unhandled exception report instead of arbitrary current context.
Fixed: 479691843, 420643998
Change-Id: Ib879856c5ca0295864f36b9cb623cf8edb21c286
Auto-Submit: Igor Sheludko <ish...@chromium.org>
Commit-Queue: Igor Sheludko <ish...@chromium.org>
Reviewed-by: Patrick Thier <pth...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#105061}
Files:
- M src/builtins/builtins-microtask-queue-gen.cc
- M src/runtime/runtime-internal.cc
Change size: M
Delta: 2 files changed, 96 insertions(+), 45 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Patrick Thier
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages