[maglev] Merge throw state from eager-inlined callees [v8/v8 : main]
0 views
Skip to first unread message
Victor Gomes (Gerrit)
Jul 24, 2026, 7:52:21 AM (21 hours ago) Jul 24
to Darius Mercadier, dmercadi...@chromium.org, leszek...@chromium.org, v8-re...@googlegroups.com, verwaes...@chromium.org, victorgo...@chromium.org
Attention needed from Darius Mercadier
Victor Gomes voted and added 1 comment![]( "Open in Gerrit")
Votes added by Victor Gomes
| Auto-Submit | +1 |
| Commit-Queue | +1 |
1 comment
Patchset-level comments
Related details
Attention is currently required from:
- Darius Mercadier
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Darius Mercadier (Gerrit)
Jul 24, 2026, 10:28:42 AM (19 hours ago) Jul 24
to Victor Gomes, v8-s...@luci-project-accounts.iam.gserviceaccount.com, dmercadi...@chromium.org, leszek...@chromium.org, v8-re...@googlegroups.com, verwaes...@chromium.org, victorgo...@chromium.org
Attention needed from Victor Gomes
Darius Mercadier voted and added 1 comment![]( "Open in Gerrit")
Votes added by Darius Mercadier
| Code-Review | +1 |
| Commit-Queue | +2 |
1 comment
Patchset-level comments
Attention is currently required from:
- Victor Gomes
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
v8-scoped@luci-project-accounts.iam.gserviceaccount.com (Gerrit)
Jul 24, 2026, 10:31:40 AM (18 hours ago) Jul 24
to Victor Gomes, Darius Mercadier, dmercadi...@chromium.org, leszek...@chromium.org, v8-re...@googlegroups.com, verwaes...@chromium.org, victorgo...@chromium.org
v8-s...@luci-project-accounts.iam.gserviceaccount.com submitted the change![]( "Open in Gerrit")
Change information
Commit message:
[maglev] Merge throw state from eager-inlined callees
Throws from eagerly inlined callees skipped MergeThrow, because
IsInsideTryBlock() is always false in the inner builder, leaving the
caller's catch handler with stale known node aspects. Merging needs the
builder that owns the try, so CatchBlockDetails now carries it.
Fixed: 500311033
Change-Id: If5312bdbbdbe38ec5d5ed44aa5b57ae925761133
Auto-Submit: Victor Gomes <victo...@chromium.org>
Reviewed-by: Darius Mercadier <dmerc...@chromium.org>
Commit-Queue: Darius Mercadier <dmerc...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#108870}
Files:
- M src/maglev/maglev-graph-builder.cc
- M src/maglev/maglev-graph-builder.h
- M src/maglev/maglev-graph-optimizer.cc
- M src/maglev/maglev-interpreter-frame-state.cc
- M src/maglev/maglev-interpreter-frame-state.h
- A test/mjsunit/maglev/regress/regress-500311033.js
Change size: M
Delta: 6 files changed, 99 insertions(+), 25 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Darius Mercadier
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages