[maglev] Reduce Builtin::kReturnReceiver in MaglevGraphBuilder [v8/v8 : main]

0 views
Skip to first unread message

chromeperf@appspot.gserviceaccount.com (Gerrit)

unread,
Aug 14, 2026, 6:11:38 AM (yesterday) Aug 14
to Marco Vitale, v8-s...@luci-project-accounts.iam.gserviceaccount.com, dmercadi...@chromium.org, leszek...@chromium.org, v8-re...@googlegroups.com, verwaes...@chromium.org, victorgo...@chromium.org
Attention needed from Marco Vitale

Message from chrom...@appspot.gserviceaccount.com

📍 Job mac-m4-pro-perf/jetstream-main.crossbench complete.

See results at: https://pinpoint-dot-chromeperf.appspot.com/job/13026a71a90000

Open in Gerrit

Related details

Attention is currently required from:
  • Marco Vitale
Submit Requirements:
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: v8/v8
Gerrit-Branch: main
Gerrit-Change-Id: Ie0afea6dfd7d56a1a0c440264743b32f58091125
Gerrit-Change-Number: 8256455
Gerrit-PatchSet: 2
Gerrit-Owner: Marco Vitale <mrc...@chromium.org>
Gerrit-Reviewer: Marco Vitale <mrc...@chromium.org>
Gerrit-Attention: Marco Vitale <mrc...@chromium.org>
Gerrit-Comment-Date: Fri, 14 Aug 2026 10:11:35 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
unsatisfied_requirement
open
diffy

Marco Vitale (Gerrit)

unread,
Aug 14, 2026, 6:17:03 AM (yesterday) Aug 14
to Victor Gomes, chrom...@appspot.gserviceaccount.com, v8-s...@luci-project-accounts.iam.gserviceaccount.com, dmercadi...@chromium.org, leszek...@chromium.org, v8-re...@googlegroups.com, verwaes...@chromium.org, victorgo...@chromium.org
Attention needed from Victor Gomes

Marco Vitale added 1 comment

Patchset-level comments
File-level comment, Patchset 2 (Latest):
Marco Vitale . resolved

PTAL 😊

Open in Gerrit

Related details

Attention is currently required from:
  • Victor Gomes
Submit Requirements:
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: v8/v8
Gerrit-Branch: main
Gerrit-Change-Id: Ie0afea6dfd7d56a1a0c440264743b32f58091125
Gerrit-Change-Number: 8256455
Gerrit-PatchSet: 2
Gerrit-Owner: Marco Vitale <mrc...@chromium.org>
Gerrit-Reviewer: Marco Vitale <mrc...@chromium.org>
Gerrit-Reviewer: Victor Gomes <victo...@chromium.org>
Gerrit-Attention: Victor Gomes <victo...@chromium.org>
Gerrit-Comment-Date: Fri, 14 Aug 2026 10:16:57 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
unsatisfied_requirement
open
diffy

Victor Gomes (Gerrit)

unread,
Aug 14, 2026, 7:27:38 AM (yesterday) Aug 14
to Marco Vitale, chrom...@appspot.gserviceaccount.com, v8-s...@luci-project-accounts.iam.gserviceaccount.com, dmercadi...@chromium.org, leszek...@chromium.org, v8-re...@googlegroups.com, verwaes...@chromium.org, victorgo...@chromium.org
Attention needed from Marco Vitale

Victor Gomes added 1 comment

File src/maglev/maglev-graph-builder.h
Line 879, Patchset 2 (Latest): V(ReturnReceiver) \
Victor Gomes . unresolved

Put in on maglev-reducer instead.

Open in Gerrit

Related details

Attention is currently required from:
  • Marco Vitale
Submit Requirements:
    • requirement is not satisfiedCode-Owners
    • requirement is not satisfiedCode-Review
    • requirement is not satisfiedNo-Unresolved-Comments
    • requirement is not satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: v8/v8
    Gerrit-Branch: main
    Gerrit-Change-Id: Ie0afea6dfd7d56a1a0c440264743b32f58091125
    Gerrit-Change-Number: 8256455
    Gerrit-PatchSet: 2
    Gerrit-Owner: Marco Vitale <mrc...@chromium.org>
    Gerrit-Reviewer: Marco Vitale <mrc...@chromium.org>
    Gerrit-Reviewer: Victor Gomes <victo...@chromium.org>
    Gerrit-Attention: Marco Vitale <mrc...@chromium.org>
    Gerrit-Comment-Date: Fri, 14 Aug 2026 11:27:33 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: No
    unsatisfied_requirement
    open
    diffy
    Reply all
    Reply to author
    Forward
    0 new messages