[libsampler] Capture LR from context on Apple ARM64 [v8/v8 : main]
0 views
Skip to first unread message
Alexander Semashko (Gerrit)
Apr 3, 2026, 4:04:01 PM (2 days ago) Apr 3
to Michael Lippautz, Leszek Swirski, V8 LUCI CQ, devtools-...@chromium.org, v8-re...@googlegroups.com
Attention needed from Leszek Swirski and Michael Lippautz
Alexander Semashko added 1 comment![]( "Open in Gerrit")
Patchset-level comments
File-level comment, Patchset 1 (Latest):
Alexander Semashko . resolved
Note from Opus: "Without LR, StackFrameIteratorForProfiler cannot correctly unwind the top frame when it hasn't yet pushed LR to the stack, which can lead to crashes during profiler stack walks."
I'm not totally sure about the correctness of this statement, but we're seeing a considerable amount of crashes in v8::internal::CpuSampler::SampleStack on mac, which might be related.
Hope that the test coverage is decent, also checked by hand that profiler is working with these changes on macos - looks ok.
Related details
Attention is currently required from:
- Leszek Swirski
- Michael Lippautz
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages