[wasmfx] Fix cmp width in WasmFXResumeThrow [v8/v8 : main]
0 views
Skip to first unread message
Thibaud Michaud (Gerrit)
Jan 8, 2026, 10:18:40 AM (20 hours ago) Jan 8
to Clemens Backes, v8-mip...@googlegroups.com, v8-ppc...@googlegroups.com, v8-re...@googlegroups.com, v8-risc...@chromium.org
Attention needed from Clemens Backes
Thibaud Michaud added 1 comment![]( "Open in Gerrit")
Patchset-level comments
File-level comment, Patchset 1 (Latest):
Thibaud Michaud . resolved
PTAL. Milad asked about this comparison while doing the PPC port:
https://chromium-review.googlesource.com/c/v8/v8/+/7411322
and indeed I mistakenly used a Smi operand which would use the tagged cmp overload, when it should be a full pointer comparison.
Related details
Attention is currently required from:
- Clemens Backes
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Clemens Backes (Gerrit)
Jan 8, 2026, 10:27:53 AM (20 hours ago) Jan 8
to Thibaud Michaud, v8-mip...@googlegroups.com, v8-ppc...@googlegroups.com, v8-re...@googlegroups.com, v8-risc...@chromium.org
Attention needed from Thibaud Michaud
Clemens Backes voted Code-Review+1![]( "Open in Gerrit")
Attention is currently required from:
- Thibaud Michaud
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Thibaud Michaud (Gerrit)
Jan 8, 2026, 10:28:27 AM (20 hours ago) Jan 8
to Clemens Backes, v8-mip...@googlegroups.com, v8-ppc...@googlegroups.com, v8-re...@googlegroups.com, v8-risc...@chromium.org
Thibaud Michaud voted Commit-Queue+2![]( "Open in Gerrit")
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Thibaud Michaud (Gerrit)
Jan 8, 2026, 10:54:32 AM (19 hours ago) Jan 8
to V8 LUCI CQ, Clemens Backes, v8-mip...@googlegroups.com, v8-ppc...@googlegroups.com, v8-re...@googlegroups.com, v8-risc...@chromium.org
Thibaud Michaud voted Commit-Queue+2![]( "Open in Gerrit")
| Commit-Queue | +2 |
Related details
Attention set is empty
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Thibaud Michaud (Gerrit)
Jan 8, 2026, 11:05:59 AM (19 hours ago) Jan 8
to V8 LUCI CQ, Clemens Backes, v8-mip...@googlegroups.com, v8-ppc...@googlegroups.com, v8-re...@googlegroups.com, v8-risc...@chromium.org
Thibaud Michaud voted Commit-Queue+2![]( "Open in Gerrit")
| Commit-Queue | +2 |
Related details
Attention set is empty
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
V8 LUCI CQ (Gerrit)
Jan 8, 2026, 12:10:40 PM (18 hours ago) Jan 8
to Thibaud Michaud, Clemens Backes, v8-mip...@googlegroups.com, v8-ppc...@googlegroups.com, v8-re...@googlegroups.com, v8-risc...@chromium.org
V8 LUCI CQ submitted the change with unreviewed changes![]( "Open in Gerrit")
Unreviewed changes
1 is the latest approved patch-set.
The change was submitted with unreviewed changes in the following files:
```
The name of the file: src/builtins/ia32/builtins-ia32.cc
Insertions: 1, Deletions: 1.
@@ -3860,7 +3860,7 @@
Register target_stack = WasmFXResumeThrowDescriptor::GetRegisterParameter(0);
// The target stack may not have a frame yet. In that case, do not switch
// stacks and throw the exception immediately instead.
- __ cmp(Operand(target_stack, wasm::kStackFpOffset), Immediate(kNullAddress));
+ __ cmp(Operand(target_stack, wasm::kStackFpOffset), Immediate(0));
Label throw_;
__ j(equal, &throw_);
Register tag = WasmFXResumeThrowDescriptor::GetRegisterParameter(1);
```
Change information
Commit message:
[wasmfx] Fix cmp width in WasmFXResumeThrow
Use a full pointer comparison to check if the target FP is null, not a
Smi comparison.
R=clem...@chromium.org
Bug: 388533754
Change-Id: I26e9015cf9623894d0fcec15d501f0790cd222f2
Reviewed-by: Clemens Backes <clem...@chromium.org>
Commit-Queue: Thibaud Michaud <thib...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#104568}
Files:
- M src/builtins/arm/builtins-arm.cc
- M src/builtins/arm64/builtins-arm64.cc
- M src/builtins/ia32/builtins-ia32.cc
- M src/builtins/x64/builtins-x64.cc
Change size: S
Delta: 4 files changed, 6 insertions(+), 7 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Clemens Backes
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Ji Qiu (Gerrit)
Jan 8, 2026, 8:43:24 PM (10 hours ago) Jan 8
to Yahan Lu (LuYahan), v8-re...@googlegroups.com, v8-risc...@chromium.org
Attention needed from Yahan Lu (LuYahan)
Ji Qiu voted Code-Review+1![]( "Open in Gerrit")
| Code-Review | +1 |
Related details
Attention is currently required from:
- Yahan Lu (LuYahan)
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Liu Yu (Gerrit)
Jan 8, 2026, 9:39:55 PM (9 hours ago) Jan 8
to Zhao Jiazhong, v8-loongar...@chromium.org, v8-re...@googlegroups.com
Attention needed from Zhao Jiazhong
Liu Yu voted Auto-Submit+1![]( "Open in Gerrit")
Attention is currently required from:
- Zhao Jiazhong
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Zhao Jiazhong (Gerrit)
Jan 8, 2026, 9:43:17 PM (9 hours ago) Jan 8
to Liu Yu, v8-loongar...@chromium.org, v8-re...@googlegroups.com
Attention needed from Liu Yu
Zhao Jiazhong voted and added 1 comment![]( "Open in Gerrit")
Votes added by Zhao Jiazhong
| Code-Review | +1 |
| Commit-Queue | +2 |
1 comment
Patchset-level comments
Attention is currently required from:
- Liu Yu
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
V8 LUCI CQ (Gerrit)
Jan 8, 2026, 10:21:57 PM (8 hours ago) Jan 8
to Liu Yu, Zhao Jiazhong, v8-loongar...@chromium.org, v8-re...@googlegroups.com
V8 LUCI CQ submitted the change![]( "Open in Gerrit")
Change information
Commit message:
[loong64][wasmfx] Fix cmp width in WasmFXResumeThrow
Port commit fdba89b5a1f187ad17be5d332f9908bf0b70b0f0
Bug: 388533754
Change-Id: I1d886330a3119fcbd1b1ad8d1bb51bdc5829f9f8
Reviewed-by: Zhao Jiazhong <zhaojia...@loongson.cn>
Commit-Queue: Zhao Jiazhong <zhaojia...@loongson.cn>
Auto-Submit: Liu Yu <li...@loongson.cn>
Cr-Commit-Position: refs/heads/main@{#104574}
Files:
- M src/builtins/loong64/builtins-loong64.cc
Change size: XS
Delta: 1 file changed, 2 insertions(+), 2 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Zhao Jiazhong
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Yahan Lu (LuYahan) (Gerrit)
2:32 AM (4 hours ago) 2:32 AM
to V8 LUCI CQ, Ji Qiu, v8-re...@googlegroups.com, v8-risc...@chromium.org
Yahan Lu (LuYahan) voted![]( "Open in Gerrit")
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages