objects: add UncheckedAdd to explicit external instantiations [v8/v8 : main]

0 views
Skip to first unread message

George Burgess (Gerrit)

unread,
Mar 12, 2026, 12:41:44 PM (4 days ago) Mar 12
to Nikolaos Papaspyrou, V8 LUCI CQ, v8-re...@googlegroups.com
Attention needed from Nikolaos Papaspyrou

New activity on the change

Open in Gerrit

Related details

Attention is currently required from:
  • Nikolaos Papaspyrou
Submit Requirements:
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: v8/v8
Gerrit-Branch: main
Gerrit-Change-Id: Ibf755d406e7089937e517ec08d89f9929996011b
Gerrit-Change-Number: 7658975
Gerrit-PatchSet: 1
Gerrit-Owner: George Burgess <gb...@chromium.org>
Gerrit-Reviewer: George Burgess <gb...@chromium.org>
Gerrit-Reviewer: Nikolaos Papaspyrou <niko...@chromium.org>
Gerrit-Attention: Nikolaos Papaspyrou <niko...@chromium.org>
Gerrit-Comment-Date: Thu, 12 Mar 2026 16:41:41 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
unsatisfied_requirement
open
diffy

George Burgess (Gerrit)

unread,
Mar 13, 2026, 9:09:51 AM (3 days ago) Mar 13
to Nikolaos Papaspyrou, V8 LUCI CQ, v8-re...@googlegroups.com
Attention needed from Nikolaos Papaspyrou

George Burgess added 1 comment

Patchset-level comments
File-level comment, Patchset 1 (Latest):
George Burgess . resolved

friendly ping :)

Open in Gerrit

Related details

Attention is currently required from:
  • Nikolaos Papaspyrou
Submit Requirements:
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: v8/v8
Gerrit-Branch: main
Gerrit-Change-Id: Ibf755d406e7089937e517ec08d89f9929996011b
Gerrit-Change-Number: 7658975
Gerrit-PatchSet: 1
Gerrit-Owner: George Burgess <gb...@chromium.org>
Gerrit-Reviewer: George Burgess <gb...@chromium.org>
Gerrit-Reviewer: Nikolaos Papaspyrou <niko...@chromium.org>
Gerrit-Attention: Nikolaos Papaspyrou <niko...@chromium.org>
Gerrit-Comment-Date: Fri, 13 Mar 2026 13:09:47 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
unsatisfied_requirement
open
diffy

Nikolaos Papaspyrou (Gerrit)

unread,
Mar 13, 2026, 2:21:51 PM (3 days ago) Mar 13
to George Burgess, V8 LUCI CQ, v8-re...@googlegroups.com
Attention needed from George Burgess

Nikolaos Papaspyrou voted and added 1 comment

Votes added by Nikolaos Papaspyrou

Code-Review+1

1 comment

Patchset-level comments
Nikolaos Papaspyrou . resolved

LGTM.
I don't have access to the bug and I have no context.
However, these template instantiations would not hurt.

Open in Gerrit

Related details

Attention is currently required from:
  • George Burgess
Submit Requirements:
  • requirement satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: v8/v8
Gerrit-Branch: main
Gerrit-Change-Id: Ibf755d406e7089937e517ec08d89f9929996011b
Gerrit-Change-Number: 7658975
Gerrit-PatchSet: 1
Gerrit-Owner: George Burgess <gb...@chromium.org>
Gerrit-Reviewer: George Burgess <gb...@chromium.org>
Gerrit-Reviewer: Nikolaos Papaspyrou <niko...@chromium.org>
Gerrit-Attention: George Burgess <gb...@chromium.org>
Gerrit-Comment-Date: Fri, 13 Mar 2026 18:21:45 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

George Burgess (Gerrit)

unread,
Mar 13, 2026, 2:23:22 PM (3 days ago) Mar 13
to Nikolaos Papaspyrou, V8 LUCI CQ, v8-re...@googlegroups.com

George Burgess voted and added 1 comment

Votes added by George Burgess

Commit-Queue+2

1 comment

Patchset-level comments
Nikolaos Papaspyrou . resolved

LGTM.
I don't have access to the bug and I have no context.
However, these template instantiations would not hurt.

George Burgess

Thanks! FWIW, the bug just says in many words what the commit message says: "extern template was promised in a header, but not provided in a cc file, so if inlining doesn't happen, we get link errors." :)

Open in Gerrit

Related details

Attention set is empty
Submit Requirements:
  • requirement satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: v8/v8
Gerrit-Branch: main
Gerrit-Change-Id: Ibf755d406e7089937e517ec08d89f9929996011b
Gerrit-Change-Number: 7658975
Gerrit-PatchSet: 1
Gerrit-Owner: George Burgess <gb...@chromium.org>
Gerrit-Reviewer: George Burgess <gb...@chromium.org>
Gerrit-Reviewer: Nikolaos Papaspyrou <niko...@chromium.org>
Gerrit-Comment-Date: Fri, 13 Mar 2026 18:23:19 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Nikolaos Papaspyrou <niko...@chromium.org>
satisfied_requirement
unsatisfied_requirement
open
diffy

George Burgess (Gerrit)

unread,
1:35 PM (6 hours ago) 1:35 PM
to Igor Sheludko, Nikolaos Papaspyrou, V8 LUCI CQ, v8-re...@googlegroups.com
Attention needed from Igor Sheludko

George Burgess voted Commit-Queue+1

Commit-Queue+1
Open in Gerrit

Related details

Attention is currently required from:
  • Igor Sheludko
Submit Requirements:
  • requirement satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: v8/v8
Gerrit-Branch: main
Gerrit-Change-Id: Ibf755d406e7089937e517ec08d89f9929996011b
Gerrit-Change-Number: 7658975
Gerrit-PatchSet: 1
Gerrit-Owner: George Burgess <gb...@chromium.org>
Gerrit-Reviewer: George Burgess <gb...@chromium.org>
Gerrit-Reviewer: Igor Sheludko <ish...@chromium.org>
Gerrit-Reviewer: Nikolaos Papaspyrou <niko...@chromium.org>
Gerrit-Attention: Igor Sheludko <ish...@chromium.org>
Gerrit-Comment-Date: Mon, 16 Mar 2026 17:35:51 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy
Reply all
Reply to author
Forward
0 new messages