objects: add UncheckedAdd to explicit external instantiations [v8/v8 : main]
0 views
Skip to first unread message
George Burgess (Gerrit)
Mar 12, 2026, 12:41:44 PM (4 days ago) Mar 12
to Nikolaos Papaspyrou, V8 LUCI CQ, v8-re...@googlegroups.com
Attention needed from Nikolaos Papaspyrou
New activity on the change![]( "Open in Gerrit")
Related details
Attention is currently required from:
- Nikolaos Papaspyrou
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
George Burgess (Gerrit)
Mar 13, 2026, 9:09:51 AM (3 days ago) Mar 13
to Nikolaos Papaspyrou, V8 LUCI CQ, v8-re...@googlegroups.com
Attention needed from Nikolaos Papaspyrou
George Burgess added 1 comment![]( "Open in Gerrit")
Patchset-level comments
Related details
Attention is currently required from:
- Nikolaos Papaspyrou
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Nikolaos Papaspyrou (Gerrit)
Mar 13, 2026, 2:21:51 PM (3 days ago) Mar 13
to George Burgess, V8 LUCI CQ, v8-re...@googlegroups.com
Attention needed from George Burgess
Nikolaos Papaspyrou voted and added 1 comment![]( "Open in Gerrit")
Votes added by Nikolaos Papaspyrou
| Code-Review | +1 |
1 comment
Patchset-level comments
Nikolaos Papaspyrou . resolved
LGTM.
I don't have access to the bug and I have no context.
However, these template instantiations would not hurt.
Related details
Attention is currently required from:
- George Burgess
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
George Burgess (Gerrit)
Mar 13, 2026, 2:23:22 PM (3 days ago) Mar 13
to Nikolaos Papaspyrou, V8 LUCI CQ, v8-re...@googlegroups.com
George Burgess voted and added 1 comment![]( "Open in Gerrit")
Votes added by George Burgess
| Commit-Queue | +2 |
1 comment
Patchset-level comments
Nikolaos Papaspyrou . resolved
LGTM.
I don't have access to the bug and I have no context.
However, these template instantiations would not hurt.
George Burgess
Thanks! FWIW, the bug just says in many words what the commit message says: "extern template was promised in a header, but not provided in a cc file, so if inlining doesn't happen, we get link errors." :)
Related details
Attention set is empty
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
George Burgess (Gerrit)
1:35 PM (6 hours ago) 1:35 PM
to Igor Sheludko, Nikolaos Papaspyrou, V8 LUCI CQ, v8-re...@googlegroups.com
Attention needed from Igor Sheludko
George Burgess voted Commit-Queue+1![]( "Open in Gerrit")
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages