[parser] Skip redundant re-parsed RegExp validation [v8/v8 : main]
0 views
Skip to first unread message
Marco Vitale (Gerrit)
Mar 16, 2026, 10:29:33 AM (14 hours ago) Mar 16
to Toon Verwaest, Jakob Linke, chrom...@appspot.gserviceaccount.com, marja...@chromium.org, v8-re...@googlegroups.com
Attention needed from Jakob Linke and Toon Verwaest
New activity on the change![]( "Open in Gerrit")
Related details
Attention is currently required from:
- Jakob Linke
- Toon Verwaest
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Toon Verwaest (Gerrit)
Mar 16, 2026, 12:02:54 PM (12 hours ago) Mar 16
to Marco Vitale, Jakob Linke, chrom...@appspot.gserviceaccount.com, marja...@chromium.org, v8-re...@googlegroups.com
Attention needed from Jakob Linke and Marco Vitale
Toon Verwaest voted and added 2 comments![]( "Open in Gerrit")
Votes added by Toon Verwaest
| Code-Review | +1 |
2 comments
Patchset-level comments
File src/parsing/parser-base.h
Line 2066, Patchset 3 (Latest):
// Lazy compilation implies this function already passed the PreParser.Toon Verwaest . unresolved
This isn't entirely technically correct. It was either parsed or preparsed. Either way, the ParseBase has seen this literal before and has already called ValidateRegExpLiteral on it.
Related details
Attention is currently required from:
- Jakob Linke
- Marco Vitale
Submit Requirements:
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Marco Vitale (Gerrit)
Mar 16, 2026, 1:18:03 PM (11 hours ago) Mar 16
to Toon Verwaest, Jakob Linke, chrom...@appspot.gserviceaccount.com, marja...@chromium.org, v8-re...@googlegroups.com
Attention needed from Jakob Linke
Marco Vitale voted and added 1 comment![]( "Open in Gerrit")
Votes added by Marco Vitale
| Auto-Submit | +1 |
| Commit-Queue | +2 |
1 comment
File src/parsing/parser-base.h
Line 2066, Patchset 3:
// Lazy compilation implies this function already passed the PreParser.Toon Verwaest . resolved
This isn't entirely technically correct. It was either parsed or preparsed. Either way, the ParseBase has seen this literal before and has already called ValidateRegExpLiteral on it.
Marco Vitale
Done
Related details
Attention is currently required from:
- Jakob Linke
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
V8 LUCI CQ (Gerrit)
Mar 16, 2026, 3:08:00 PM (9 hours ago) Mar 16
to Marco Vitale, Toon Verwaest, Jakob Linke, chrom...@appspot.gserviceaccount.com, marja...@chromium.org, v8-re...@googlegroups.com
V8 LUCI CQ submitted the change with unreviewed changes![]( "Open in Gerrit")
Unreviewed changes
3 is the latest approved patch-set.
The change was submitted with unreviewed changes in the following files:
```
The name of the file: src/parsing/parser-base.h
Insertions: 1, Deletions: 3.
@@ -2063,9 +2063,7 @@
RegExpFlags flags,
RegExpError* regexp_error) {
if (this->flags().is_lazy_compile()) {
- // Lazy compilation implies this function already passed the PreParser.
- // Since the PreParser throws early SyntaxErrors for invalid RegExp
- // literals, we know they are guaranteed to be valid here.
+ // Lazy compilation implies this has already been validated.
return true;
}
```
Change information
Commit message:
[parser] Skip redundant re-parsed RegExp validation
During lazy compilation, the full parser redundantly re-validates the
syntax of RegExp literals. However, a SharedFunctionInfo can only be
created if the function's source code was successfully parsed during a
previous compilation phase.
This yields a 6% performance gain for prismjs-startup-es6 on Jetstream3.
Change-Id: I16ca3bcd385c596bd70b84e0e3876549360de503
Bug: 493189218
Commit-Queue: Marco Vitale <mrc...@chromium.org>
Reviewed-by: Toon Verwaest <verw...@chromium.org>
Auto-Submit: Marco Vitale <mrc...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#105834}
Files:
- M src/parsing/parser-base.h
Change size: XS
Delta: 1 file changed, 5 insertions(+), 2 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Toon Verwaest
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages