[maglev] Unwrap fast/slow closure in getcontext/feedbackcell [v8/v8 : main]

0 views
Skip to first unread message

Toon Verwaest (Gerrit)

unread,
Dec 15, 2025, 9:02:07 AM (yesterday) Dec 15
to Leszek Swirski, AyeAye, leszek...@chromium.org, v8-re...@googlegroups.com, verwaes...@chromium.org, victorgo...@chromium.org
Attention needed from Leszek Swirski

Toon Verwaest voted and added 1 comment

Votes added by Toon Verwaest

Auto-Submit+1
Commit-Queue+1

1 comment

Patchset-level comments
File-level comment, Patchset 1 (Latest):
Toon Verwaest . resolved

ptal

Open in Gerrit

Related details

Attention is currently required from:
  • Leszek Swirski
Submit Requirements:
  • requirement satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: v8/v8
Gerrit-Branch: main
Gerrit-Change-Id: I5744eb9ff8afdc7d7905222cbbf7271014d771c5
Gerrit-Change-Number: 7261257
Gerrit-PatchSet: 1
Gerrit-Owner: Toon Verwaest <verw...@chromium.org>
Gerrit-Reviewer: Leszek Swirski <les...@chromium.org>
Gerrit-Reviewer: Toon Verwaest <verw...@chromium.org>
Gerrit-Attention: Leszek Swirski <les...@chromium.org>
Gerrit-Comment-Date: Mon, 15 Dec 2025 14:02:02 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

Leszek Swirski (Gerrit)

unread,
Dec 15, 2025, 9:09:31 AM (yesterday) Dec 15
to Toon Verwaest, V8 LUCI CQ, AyeAye, leszek...@chromium.org, v8-re...@googlegroups.com, verwaes...@chromium.org, victorgo...@chromium.org
Attention needed from Toon Verwaest

Leszek Swirski voted and added 1 comment

Votes added by Leszek Swirski

Code-Review+1

1 comment

File src/maglev/maglev-graph-builder.cc
Line 5216, Patchset 1 (Latest): if (auto slow_closure = closure->TryCast<CreateClosure>()) {
Leszek Swirski . unresolved

maybe add this to MaglevGraphOptimizer::VisitLoadTaggedField too

Open in Gerrit

Related details

Attention is currently required from:
  • Toon Verwaest
Submit Requirements:
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement is not satisfiedNo-Unresolved-Comments
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: v8/v8
Gerrit-Branch: main
Gerrit-Change-Id: I5744eb9ff8afdc7d7905222cbbf7271014d771c5
Gerrit-Change-Number: 7261257
Gerrit-PatchSet: 1
Gerrit-Owner: Toon Verwaest <verw...@chromium.org>
Gerrit-Reviewer: Leszek Swirski <les...@chromium.org>
Gerrit-Reviewer: Toon Verwaest <verw...@chromium.org>
Gerrit-Attention: Toon Verwaest <verw...@chromium.org>
Gerrit-Comment-Date: Mon, 15 Dec 2025 14:09:26 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

Leszek Swirski (Gerrit)

unread,
Dec 15, 2025, 10:27:07 AM (yesterday) Dec 15
to Toon Verwaest, V8 LUCI CQ, AyeAye, leszek...@chromium.org, v8-re...@googlegroups.com, verwaes...@chromium.org, victorgo...@chromium.org
Attention needed from Toon Verwaest

Leszek Swirski voted

Code-Review+1
Commit-Queue+2
Open in Gerrit

Related details

Attention is currently required from:
  • Toon Verwaest
Submit Requirements:
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement is not satisfiedNo-Unresolved-Comments
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: v8/v8
Gerrit-Branch: main
Gerrit-Change-Id: I5744eb9ff8afdc7d7905222cbbf7271014d771c5
Gerrit-Change-Number: 7261257
Gerrit-PatchSet: 2
Gerrit-Owner: Toon Verwaest <verw...@chromium.org>
Gerrit-Reviewer: Leszek Swirski <les...@chromium.org>
Gerrit-Reviewer: Toon Verwaest <verw...@chromium.org>
Gerrit-Attention: Toon Verwaest <verw...@chromium.org>
Gerrit-Comment-Date: Mon, 15 Dec 2025 15:27:02 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

Leszek Swirski (Gerrit)

unread,
Dec 15, 2025, 10:34:40 AM (yesterday) Dec 15
to Toon Verwaest, V8 LUCI CQ, AyeAye, leszek...@chromium.org, v8-re...@googlegroups.com, verwaes...@chromium.org, victorgo...@chromium.org
Attention needed from Toon Verwaest

Leszek Swirski voted and added 1 comment

Votes added by Leszek Swirski

Commit-Queue+2

1 comment

File src/maglev/maglev-graph-builder.cc
Line 5216, Patchset 1: if (auto slow_closure = closure->TryCast<CreateClosure>()) {
Leszek Swirski . resolved

maybe add this to MaglevGraphOptimizer::VisitLoadTaggedField too

Leszek Swirski

Done

Open in Gerrit

Related details

Attention is currently required from:
  • Toon Verwaest
Submit Requirements:
    • requirement satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: v8/v8
    Gerrit-Branch: main
    Gerrit-Change-Id: I5744eb9ff8afdc7d7905222cbbf7271014d771c5
    Gerrit-Change-Number: 7261257
    Gerrit-PatchSet: 2
    Gerrit-Owner: Toon Verwaest <verw...@chromium.org>
    Gerrit-Reviewer: Leszek Swirski <les...@chromium.org>
    Gerrit-Reviewer: Toon Verwaest <verw...@chromium.org>
    Gerrit-Attention: Toon Verwaest <verw...@chromium.org>
    Gerrit-Comment-Date: Mon, 15 Dec 2025 15:34:35 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: Yes
    Comment-In-Reply-To: Leszek Swirski <les...@chromium.org>
    satisfied_requirement
    open
    diffy

    V8 LUCI CQ (Gerrit)

    unread,
    Dec 15, 2025, 11:12:00 AM (yesterday) Dec 15
    to Toon Verwaest, Leszek Swirski, AyeAye, leszek...@chromium.org, v8-re...@googlegroups.com, verwaes...@chromium.org, victorgo...@chromium.org

    V8 LUCI CQ submitted the change

    Change information

    Commit message:
    [maglev] Unwrap fast/slow closure in getcontext/feedbackcell
    Change-Id: I5744eb9ff8afdc7d7905222cbbf7271014d771c5
    Commit-Queue: Leszek Swirski <les...@chromium.org>
    Reviewed-by: Leszek Swirski <les...@chromium.org>
    Auto-Submit: Toon Verwaest <verw...@chromium.org>
    Cr-Commit-Position: refs/heads/main@{#104327}
    Files:
    • M src/maglev/maglev-graph-builder.cc
    • M src/maglev/maglev-graph-optimizer.cc
    Change size: S
    Delta: 2 files changed, 20 insertions(+), 0 deletions(-)
    Branch: refs/heads/main
    Submit Requirements:
    • requirement satisfiedCode-Review: +1 by Leszek Swirski
    Open in Gerrit
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: merged
    Gerrit-Project: v8/v8
    Gerrit-Branch: main
    Gerrit-Change-Id: I5744eb9ff8afdc7d7905222cbbf7271014d771c5
    Gerrit-Change-Number: 7261257
    Gerrit-PatchSet: 3
    Gerrit-Owner: Toon Verwaest <verw...@chromium.org>
    Gerrit-Reviewer: Leszek Swirski <les...@chromium.org>
    Gerrit-Reviewer: Toon Verwaest <verw...@chromium.org>
    open
    diffy
    satisfied_requirement
    Reply all
    Reply to author
    Forward
    0 new messages