[maglev] Unwrap fast/slow closure in getcontext/feedbackcell [v8/v8 : main]
0 views
Skip to first unread message
Toon Verwaest (Gerrit)
Dec 15, 2025, 9:02:07 AM (yesterday) Dec 15
to Leszek Swirski, AyeAye, leszek...@chromium.org, v8-re...@googlegroups.com, verwaes...@chromium.org, victorgo...@chromium.org
Attention needed from Leszek Swirski
Toon Verwaest voted and added 1 comment![]( "Open in Gerrit")
Votes added by Toon Verwaest
| Auto-Submit | +1 |
| Commit-Queue | +1 |
1 comment
Patchset-level comments
Related details
Attention is currently required from:
- Leszek Swirski
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Leszek Swirski (Gerrit)
Dec 15, 2025, 9:09:31 AM (yesterday) Dec 15
to Toon Verwaest, V8 LUCI CQ, AyeAye, leszek...@chromium.org, v8-re...@googlegroups.com, verwaes...@chromium.org, victorgo...@chromium.org
Attention needed from Toon Verwaest
Leszek Swirski voted and added 1 comment![]( "Open in Gerrit")
Votes added by Leszek Swirski
| Code-Review | +1 |
1 comment
File src/maglev/maglev-graph-builder.cc
Line 5216, Patchset 1 (Latest):
if (auto slow_closure = closure->TryCast<CreateClosure>()) {Leszek Swirski . unresolved
maybe add this to MaglevGraphOptimizer::VisitLoadTaggedField too
Related details
Attention is currently required from:
- Toon Verwaest
Submit Requirements:
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Leszek Swirski (Gerrit)
Dec 15, 2025, 10:27:07 AM (yesterday) Dec 15
to Toon Verwaest, V8 LUCI CQ, AyeAye, leszek...@chromium.org, v8-re...@googlegroups.com, verwaes...@chromium.org, victorgo...@chromium.org
Attention needed from Toon Verwaest
Leszek Swirski voted![]( "Open in Gerrit")
| Code-Review | +1 |
| Commit-Queue | +2 |
Related details
Attention is currently required from:
- Toon Verwaest
Submit Requirements:
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Leszek Swirski (Gerrit)
Dec 15, 2025, 10:34:40 AM (yesterday) Dec 15
to Toon Verwaest, V8 LUCI CQ, AyeAye, leszek...@chromium.org, v8-re...@googlegroups.com, verwaes...@chromium.org, victorgo...@chromium.org
Attention needed from Toon Verwaest
Leszek Swirski voted and added 1 comment![]( "Open in Gerrit")
Votes added by Leszek Swirski
| Commit-Queue | +2 |
1 comment
File src/maglev/maglev-graph-builder.cc
Line 5216, Patchset 1:
if (auto slow_closure = closure->TryCast<CreateClosure>()) {Leszek Swirski . resolved
maybe add this to MaglevGraphOptimizer::VisitLoadTaggedField too
Leszek Swirski
Done
Related details
Attention is currently required from:
- Toon Verwaest
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
V8 LUCI CQ (Gerrit)
Dec 15, 2025, 11:12:00 AM (yesterday) Dec 15
to Toon Verwaest, Leszek Swirski, AyeAye, leszek...@chromium.org, v8-re...@googlegroups.com, verwaes...@chromium.org, victorgo...@chromium.org
V8 LUCI CQ submitted the change![]( "Open in Gerrit")
Change information
Commit message:
[maglev] Unwrap fast/slow closure in getcontext/feedbackcell
Change-Id: I5744eb9ff8afdc7d7905222cbbf7271014d771c5
Commit-Queue: Leszek Swirski <les...@chromium.org>
Reviewed-by: Leszek Swirski <les...@chromium.org>
Auto-Submit: Toon Verwaest <verw...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#104327}
Files:
- M src/maglev/maglev-graph-builder.cc
- M src/maglev/maglev-graph-optimizer.cc
Change size: S
Delta: 2 files changed, 20 insertions(+), 0 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Leszek Swirski
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages