Zero-initialize proxy padding [v8/v8 : main]

0 views
Skip to first unread message

Joyee Cheung (Gerrit)

unread,
10:42 AM (9 hours ago) 10:42 AM
to Jakob Kummerow, V8 LUCI CQ, Hannes Payer, mlippau...@chromium.org, v8-re...@googlegroups.com
Attention needed from Jakob Kummerow

Joyee Cheung added 1 comment

Patchset-level comments
File-level comment, Patchset 2 (Latest):
Joyee Cheung . resolved

PTAL, thanks!

Open in Gerrit

Related details

Attention is currently required from:
  • Jakob Kummerow
Submit Requirements:
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: v8/v8
Gerrit-Branch: main
Gerrit-Change-Id: I01fac5e18c73cd482a1ae63750dbadf42a12e08a
Gerrit-Change-Number: 7666243
Gerrit-PatchSet: 2
Gerrit-Owner: Joyee Cheung <jo...@igalia.com>
Gerrit-Reviewer: Jakob Kummerow <jkum...@chromium.org>
Gerrit-Reviewer: Joyee Cheung <jo...@igalia.com>
Gerrit-CC: Hannes Payer <hpa...@chromium.org>
Gerrit-Attention: Jakob Kummerow <jkum...@chromium.org>
Gerrit-Comment-Date: Mon, 16 Mar 2026 14:42:50 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
unsatisfied_requirement
open
diffy

Jakob Kummerow (Gerrit)

unread,
12:10 PM (7 hours ago) 12:10 PM
to Joyee Cheung, Jakob Kummerow, V8 LUCI CQ, Hannes Payer, mlippau...@chromium.org, v8-re...@googlegroups.com
Attention needed from Joyee Cheung

Jakob Kummerow voted Code-Review+1

Code-Review+1
Open in Gerrit

Related details

Attention is currently required from:
  • Joyee Cheung
Submit Requirements:
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: v8/v8
Gerrit-Branch: main
Gerrit-Change-Id: I01fac5e18c73cd482a1ae63750dbadf42a12e08a
Gerrit-Change-Number: 7666243
Gerrit-PatchSet: 2
Gerrit-Owner: Joyee Cheung <jo...@igalia.com>
Gerrit-Reviewer: Jakob Kummerow <jkum...@chromium.org>
Gerrit-Reviewer: Joyee Cheung <jo...@igalia.com>
Gerrit-CC: Hannes Payer <hpa...@chromium.org>
Gerrit-Attention: Joyee Cheung <jo...@igalia.com>
Gerrit-Comment-Date: Mon, 16 Mar 2026 16:10:38 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

Joyee Cheung (Gerrit)

unread,
12:27 PM (7 hours ago) 12:27 PM
to Jakob Kummerow, V8 LUCI CQ, Hannes Payer, mlippau...@chromium.org, v8-re...@googlegroups.com

Joyee Cheung voted Commit-Queue+2

Commit-Queue+2
Open in Gerrit

Related details

Attention set is empty
Submit Requirements:
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: v8/v8
Gerrit-Branch: main
Gerrit-Change-Id: I01fac5e18c73cd482a1ae63750dbadf42a12e08a
Gerrit-Change-Number: 7666243
Gerrit-PatchSet: 2
Gerrit-Owner: Joyee Cheung <jo...@igalia.com>
Gerrit-Reviewer: Jakob Kummerow <jkum...@chromium.org>
Gerrit-Reviewer: Joyee Cheung <jo...@igalia.com>
Gerrit-CC: Hannes Payer <hpa...@chromium.org>
Gerrit-Comment-Date: Mon, 16 Mar 2026 16:27:42 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

V8 LUCI CQ (Gerrit)

unread,
1:48 PM (6 hours ago) 1:48 PM
to Joyee Cheung, Jakob Kummerow, Hannes Payer, mlippau...@chromium.org, v8-re...@googlegroups.com

V8 LUCI CQ submitted the change

Change information

Commit message:
Zero-initialize proxy padding

So that snapshots with proxies can be reproducible.
Change-Id: I01fac5e18c73cd482a1ae63750dbadf42a12e08a
Reviewed-by: Jakob Kummerow <jkum...@chromium.org>
Commit-Queue: Joyee Cheung <jo...@igalia.com>
Cr-Commit-Position: refs/heads/main@{#105830}
Files:
  • M src/builtins/builtins-proxy-gen.cc
  • M src/heap/factory.cc
Change size: XS
Delta: 2 files changed, 7 insertions(+), 0 deletions(-)
Branch: refs/heads/main
Submit Requirements:
  • requirement satisfiedCode-Review: +1 by Jakob Kummerow
Open in Gerrit
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: merged
Gerrit-Project: v8/v8
Gerrit-Branch: main
Gerrit-Change-Id: I01fac5e18c73cd482a1ae63750dbadf42a12e08a
Gerrit-Change-Number: 7666243
Gerrit-PatchSet: 3
Gerrit-Owner: Joyee Cheung <jo...@igalia.com>
Gerrit-Reviewer: Jakob Kummerow <jkum...@chromium.org>
Gerrit-Reviewer: Joyee Cheung <jo...@igalia.com>
Gerrit-CC: Hannes Payer <hpa...@chromium.org>
open
diffy
satisfied_requirement
Reply all
Reply to author
Forward
0 new messages