[heap] Refactor GCTracer to use base::TimeDelta for durations [v8/v8 : main]
0 views
Skip to first unread message
Tony Seaward (Gerrit)
Apr 2, 2026, 6:03:04 PM (3 days ago) Apr 2
to Hannes Payer, v8-re...@googlegroups.com, mlippau...@chromium.org
Tony Seaward has uploaded the change for review![]( "Open in Gerrit")
Commit message
[heap] Refactor GCTracer to use base::TimeDelta for durations
This patch refactors the GCTracer class to use base::TimeDelta and
base::TimeTicks for representing durations and timestamps, replacing
the previous use of double.
Key changes:
- Updated GCTracer::Event and BackgroundCounter to use base::TimeDelta
for scope durations.
- Changed Event start_time and end_time to base::TimeTicks.
- Updated various GCTracer members (average durations, pause times)
to use appropriate base::TimeDelta or base::TimeTicks types.
- Adjusted methods like AddScopeSample, AddCompactionEvent, and
AddIncrementalMarkingStep to handle the new types.
- Updated metrics reporting and trace events to perform necessary
conversions (e.g., InMicroseconds()).
- Updated call sites and unit tests accordingly.
Bug: v8:1154636
Change-Id: I20f46de2493e98dbec9dade2dc62a83a7a9557dc
Change diff
Change information
Files:
- M src/heap/gc-tracer-inl.h
- M src/heap/gc-tracer.cc
- M src/heap/gc-tracer.h
- M src/heap/incremental-marking.cc
- M src/heap/mark-compact.cc
- M test/unittests/heap/gc-tracer-unittest.cc
Change size: L
Delta: 6 files changed, 254 insertions(+), 163 deletions(-)
Related details
Attention set is empty
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Tony Seaward (Gerrit)
Apr 2, 2026, 8:09:24 PM (3 days ago) Apr 2
to mlippau...@chromium.org, v8-re...@googlegroups.com
Tony Seaward added 1 comment![]( "Open in Gerrit")
Patchset-level comments
Related details
Attention set is empty
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Tony Seaward (Gerrit)
Apr 2, 2026, 8:10:37 PM (3 days ago) Apr 2
to v8-re...@googlegroups.com
Tony Seaward added 1 comment![]( "Open in Gerrit")
Patchset-level comments
Tony Seaward . resolved
Testing with jetski and gemini
Related details
Attention set is empty
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages