[threading] Add missing ScopedBoostablePriority default constructor [v8/v8 : main]

0 views
Skip to first unread message

Etienne Pierre-Doray (Gerrit)

unread,
Dec 12, 2025, 8:53:44 AM (4 days ago) Dec 12
to Michael Lippautz, V8 LUCI CQ, cbruni...@chromium.org, v8-re...@googlegroups.com
Attention needed from Michael Lippautz

Etienne Pierre-Doray voted and added 1 comment

Votes added by Etienne Pierre-Doray

Commit-Queue+1

1 comment

Patchset-level comments
File-level comment, Patchset 3 (Latest):
Etienne Pierre-Doray . resolved

PTAL

Open in Gerrit

Related details

Attention is currently required from:
  • Michael Lippautz
Submit Requirements:
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: v8/v8
Gerrit-Branch: main
Gerrit-Change-Id: I95a0a656cf74a3ec690f5a687ef19c68fb9f13e0
Gerrit-Change-Number: 7254881
Gerrit-PatchSet: 3
Gerrit-Owner: Etienne Pierre-Doray <etie...@chromium.org>
Gerrit-Reviewer: Etienne Pierre-Doray <etie...@chromium.org>
Gerrit-Reviewer: Michael Lippautz <mlip...@chromium.org>
Gerrit-Attention: Michael Lippautz <mlip...@chromium.org>
Gerrit-Comment-Date: Fri, 12 Dec 2025 13:53:41 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
unsatisfied_requirement
open
diffy

Michael Lippautz (Gerrit)

unread,
Dec 15, 2025, 5:04:09 AM (yesterday) Dec 15
to Etienne Pierre-Doray, V8 LUCI CQ, cbruni...@chromium.org, v8-re...@googlegroups.com
Attention needed from Etienne Pierre-Doray

Michael Lippautz voted Code-Review+1

Code-Review+1
Open in Gerrit

Related details

Attention is currently required from:
  • Etienne Pierre-Doray
Submit Requirements:
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: v8/v8
Gerrit-Branch: main
Gerrit-Change-Id: I95a0a656cf74a3ec690f5a687ef19c68fb9f13e0
Gerrit-Change-Number: 7254881
Gerrit-PatchSet: 3
Gerrit-Owner: Etienne Pierre-Doray <etie...@chromium.org>
Gerrit-Reviewer: Etienne Pierre-Doray <etie...@chromium.org>
Gerrit-Reviewer: Michael Lippautz <mlip...@chromium.org>
Gerrit-Attention: Etienne Pierre-Doray <etie...@chromium.org>
Gerrit-Comment-Date: Mon, 15 Dec 2025 10:04:04 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

Etienne Pierre-Doray (Gerrit)

unread,
Dec 15, 2025, 10:12:08 AM (yesterday) Dec 15
to Michael Lippautz, V8 LUCI CQ, cbruni...@chromium.org, v8-re...@googlegroups.com

Etienne Pierre-Doray voted Commit-Queue+2

Commit-Queue+2
Open in Gerrit

Related details

Attention set is empty
Submit Requirements:
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: v8/v8
Gerrit-Branch: main
Gerrit-Change-Id: I95a0a656cf74a3ec690f5a687ef19c68fb9f13e0
Gerrit-Change-Number: 7254881
Gerrit-PatchSet: 3
Gerrit-Owner: Etienne Pierre-Doray <etie...@chromium.org>
Gerrit-Reviewer: Etienne Pierre-Doray <etie...@chromium.org>
Gerrit-Reviewer: Michael Lippautz <mlip...@chromium.org>
Gerrit-Comment-Date: Mon, 15 Dec 2025 15:12:05 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

V8 LUCI CQ (Gerrit)

unread,
Dec 15, 2025, 10:48:46 AM (yesterday) Dec 15
to Etienne Pierre-Doray, Michael Lippautz, cbruni...@chromium.org, v8-re...@googlegroups.com

V8 LUCI CQ submitted the change

Change information

Commit message:
[threading] Add missing ScopedBoostablePriority default constructor

While implementing the embedder (gin), I realized that
ScopedBoostablePriority is unusable because it's missing its default
constructor (implicitly deleted by deleted copy constructor).
Change-Id: I95a0a656cf74a3ec690f5a687ef19c68fb9f13e0
Reviewed-by: Michael Lippautz <mlip...@chromium.org>
Commit-Queue: Etienne Pierre-Doray <etie...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#104326}
Files:
  • M include/v8-platform.h
Change size: XS
Delta: 1 file changed, 1 insertion(+), 0 deletions(-)
Branch: refs/heads/main
Submit Requirements:
  • requirement satisfiedCode-Review: +1 by Michael Lippautz
Open in Gerrit
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: merged
Gerrit-Project: v8/v8
Gerrit-Branch: main
Gerrit-Change-Id: I95a0a656cf74a3ec690f5a687ef19c68fb9f13e0
Gerrit-Change-Number: 7254881
Gerrit-PatchSet: 4
Gerrit-Owner: Etienne Pierre-Doray <etie...@chromium.org>
Gerrit-Reviewer: Etienne Pierre-Doray <etie...@chromium.org>
Gerrit-Reviewer: Michael Lippautz <mlip...@chromium.org>
open
diffy
satisfied_requirement
Reply all
Reply to author
Forward
0 new messages