[object] Remove `PROHIBITS_OVERWRITING` API [v8/v8 : main]

Ho Cheung (Gerrit)

unread,

Sep 7, 2023, 10:11:26 PM9/7/23

to Michael Lippautz, cbruni...@chromium.org, v8-re...@googlegroups.com

Attention is currently required from: Ho Cheung, Michael Lippautz.

Ho Cheung would like Michael Lippautz to review this change.

[object] Remove `PROHIBITS_OVERWRITING` API

This API has been deprecated and no longer used, plus V8 has reached a
new branch, this patch will delete this API.

Bug:None
Change-Id: I7671175e92362f4de4162ff2d75b280a68fe80a9
---
M include/v8-object.h
1 file changed, 1 insertion(+), 6 deletions(-)

diff --git a/include/v8-object.h b/include/v8-object.h
index 4566092..7fe114e 100644
--- a/include/v8-object.h
+++ b/include/v8-object.h
@@ -170,12 +170,7 @@
  * the kind of cross-context access that should be allowed.
  *
  */
-enum AccessControl {
-  DEFAULT = 0,
-  ALL_CAN_READ = 1,
-  ALL_CAN_WRITE = 1 << 1,
-  PROHIBITS_OVERWRITING V8_ENUM_DEPRECATE_SOON("unused") = 1 << 2
-};
+enum AccessControl { DEFAULT = 0, ALL_CAN_READ = 1, ALL_CAN_WRITE = 1 << 1 };
 
 /**
  * Property filter bits. They can be or'ed to build a composite filter.

To view, visit change 4852977. To unsubscribe, or for help writing mail filters, visit settings.

Ho Cheung (Gerrit)

unread,

Sep 7, 2023, 10:11:28 PM9/7/23

to cbruni...@chromium.org, v8-re...@googlegroups.com, Michael Lippautz, V8 LUCI CQ

Attention is currently required from: Ho Cheung, Michael Lippautz.

View Change

1 comment:

Patchset:
- Patch Set #1:
  Michael@
  PTAL thank you

To view, visit change 4852977. To unsubscribe, or for help writing mail filters, visit settings.

Michael Lippautz (Gerrit)

unread,

Sep 11, 2023, 3:40:03 AM9/11/23

to Ho Cheung, cbruni...@chromium.org, v8-re...@googlegroups.com, V8 LUCI CQ

Attention is currently required from: Ho Cheung.

View Change

1 comment:

File include/v8-object.h:
- Patch Set #1, Line 177: V8_ENUM_DEPRECATE_SOON
  The next step here is V8_ENUM_DEPRECATE for one more release.

To view, visit change 4852977. To unsubscribe, or for help writing mail filters, visit settings.

Reply all

Reply to author

Forward